Allowing for custom yum repo #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/etc/yum.repos.d/datadog.repo is still being created, but its content is customizable
olivielpeau
suggested changes
Oct 23, 2017
Member
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
just one comment, other than that LGTM 👍
defaults/main.yml
Outdated
| # default yum repo and keys | ||
| datadog_yum_repo: "https://yum.datadoghq.com/rpm/{{ ansible_userspace_architecture }}/" | ||
| datadog_yum_gpgkey: "https://yum.datadoghq.com/DATADOG_RPM_KEY.public" | ||
| datadog_rpm_gpgkey: "http://yum.datadoghq.com/DATADOG_RPM_KEY_E09422B3.public" |
Member
There was a problem hiding this comment.
can you rename this one datadog_yum_gpgkey_new?
as per olivielpeau's comment
olivielpeau
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/etc/yum.repos.d/datadog.repo is still being created, but its URL content is customizable
Repo name and filename remain