Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] product features activation #1151

Closed
wants to merge 2 commits into from

Conversation

eliottness
Copy link
Collaborator

@eliottness eliottness commented Apr 25, 2024

What does this PR do?

This PR adds the ASM features activation under the feature.asm field in the DatadogAgent crd. Its only goal is to propagate environment variables to the cluster-agent admission controller (cf. DataDog/datadog-agent#23618)

Sister PR of DataDog/helm-charts#1337

Motivation

Part of Single Step Activation for ASM products

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Cluster Agent: v7.53.0

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies

@eliottness
Copy link
Collaborator Author

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies

I don't have access to the labels from a fork

@eliottness eliottness changed the title asm product features activation [ASM] product features activation Apr 25, 2024
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness eliottness marked this pull request as ready for review April 29, 2024 08:00
@eliottness eliottness requested review from a team as code owners April 29, 2024 08:00
@levan-m levan-m added this to the v1.7.0 milestone Apr 29, 2024
@eliottness
Copy link
Collaborator Author

Cloned by #1165

@eliottness eliottness closed this May 2, 2024
@eliottness eliottness deleted the eliott.bouhana/asm-ssi branch May 2, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants