-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASM] product features activation #1165
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
+ Coverage 59.16% 59.23% +0.06%
==========================================
Files 175 176 +1
Lines 21944 22031 +87
==========================================
+ Hits 12984 13050 +66
- Misses 8164 8181 +17
- Partials 796 800 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of small suggestions from Docs and approved the PR.
bfd46d9
to
2da48c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you also need to "register" this feature here
I made some suggestions, feel free to ping me if you have questions or need another review
f27346a
to
40d9748
Compare
b3b873b
to
560c1ea
Compare
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com> Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Co-authored-by: Celene <celene@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
560c1ea
to
34ad7f9
Compare
* asm product configuration & activation Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com> * setup asm feature Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com> * run make generate Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com> * Apply suggestions from code review Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com> Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com> * Apply suggestions from code review Co-authored-by: Celene <celene@datadoghq.com> * apply code reviez suggestion Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com> * Fix Admission Controller check and add tests * Apply suggestion from @celenechang Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com> --------- Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com> Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com> Co-authored-by: Celene <celene@datadoghq.com> Co-authored-by: Levan Machablishvili <levan.machablishvili@datadoghq.com>
What does this PR do?
This PR adds the ASM features activation under the
feature.asm
field in theDatadogAgent
crd. Its only goal is to propagate environment variables to the cluster-agent admission controller (cf. DataDog/datadog-agent#23618)Sister PR of DataDog/helm-charts#1337
Clone of #1151
Motivation
Part of Single Step Activation for ASM products
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
labelTest Instruction
if the admission controller is not disabled, then there is a OneToOne relation between the DatadogAgent manifest and the env of the cluster agent like this:
Manifest example: