Update datadog.trace.agent.tooling.bytebuddy.outline.TypeOutline to work with ByteBuddy 1.17.6

[nikita-tkachenko-datadog]

What Does This Do

Fixes some of the methods in datadog.trace.agent.tooling.bytebuddy.outline.TypeOutline that stopped working with ByteBuddy 1.17.6 release.

There is a chain of inheritance: TypeOutline -> ... -> WithDelegation -> ... -> ModifierReviewable.AbstractBase.

Some of the methods (isInterface, isAnnotation and others) used to be inherited by TypeOutline from ModifierReviewable.AbstractBase. The abstract base implementations relied on getModifiers() (overridden in TypeOutline).

This ByteBuddy commit overrides these methods in WithDelegation (so now TypeOutline inherits them from that class), and the new implementations delegate to what is returned by delegate().

delegate() method is not implemented in TypeOutline (it throws an exception), so with the introduction of the new methods things broke in TypeOutline.

This PR implements the affected methods in directly in TypeOutline. They rely on getModifiers() as before.

Motivation

Additional Notes

This was uncovered when trying to bump dependencies in the Selenium instrumentation module. Selenium depends on ByteBuddy, so bumping selenium-java from 4.33.0 to 4.34.0 transitively pulled in byte-buddy 1.17.6 instead of the previously used 1.17.5

Contributor Checklist

• Format the title according the contribution guidelines
• Assign the type: and (comp: or inst:) labels in addition to any usefull labels
• Don't use close, fix or any linking keywords when referencing an issue.
  Use solves instead, and assign the PR milestone to the issue
• Update the CODEOWNERS file on source file addition, move, or deletion
• Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

[datadog-official]

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 59.25% (+1.60%)

View detailed report

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ca28c79 | Docs | Was this helpful? Give us feedback!}

[AlexeyKuznetsov-DD]

LGTM to me, but please get approval from real expert in this area.

[mcculls]

LGTM - thanks!