-
Notifications
You must be signed in to change notification settings - Fork 312
Exclude long running partial versions from stats #9495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎯 Code Coverage 🔗 Commit SHA: 93aa163 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~93aa163f5c, baseline=1.54.0-SNAPSHOT~42be7a0b68
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054513
Total [baseline] (8.645 s) : 0, 8644882
Agent [candidate] (1.043 s) : 0, 1043356
Total [candidate] (8.632 s) : 0, 8631767
section iast
Agent [baseline] (1.18 s) : 0, 1180173
Total [baseline] (9.345 s) : 0, 9344963
Agent [candidate] (1.188 s) : 0, 1187879
Total [candidate] (9.362 s) : 0, 9361798
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~93aa163f5c, baseline=1.54.0-SNAPSHOT~42be7a0b68
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (737.538 ms) : 0, 737538
BytebuddyAgent [candidate] (731.964 ms) : 0, 731964
GlobalTracer [baseline] (242.689 ms) : 0, 242689
GlobalTracer [candidate] (241.82 ms) : 0, 241820
AppSec [baseline] (30.63 ms) : 0, 30630
AppSec [candidate] (29.988 ms) : 0, 29988
Debugger [baseline] (6.468 ms) : 0, 6468
Debugger [candidate] (6.384 ms) : 0, 6384
Remote Config [baseline] (679.041 µs) : 0, 679
Remote Config [candidate] (673.587 µs) : 0, 674
Telemetry [baseline] (13.975 ms) : 0, 13975
Telemetry [candidate] (10.072 ms) : 0, 10072
section iast
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (851.377 ms) : 0, 851377
BytebuddyAgent [candidate] (857.191 ms) : 0, 857191
GlobalTracer [baseline] (232.703 ms) : 0, 232703
GlobalTracer [candidate] (233.833 ms) : 0, 233833
AppSec [baseline] (29.64 ms) : 0, 29640
AppSec [candidate] (28.284 ms) : 0, 28284
Debugger [baseline] (7.021 ms) : 0, 7021
Debugger [candidate] (7.892 ms) : 0, 7892
Remote Config [baseline] (626.28 µs) : 0, 626
Remote Config [candidate] (617.223 µs) : 0, 617
Telemetry [baseline] (8.366 ms) : 0, 8366
Telemetry [candidate] (8.525 ms) : 0, 8525
IAST [baseline] (27.883 ms) : 0, 27883
IAST [candidate] (28.922 ms) : 0, 28922
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~93aa163f5c, baseline=1.54.0-SNAPSHOT~42be7a0b68
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043004
Total [baseline] (10.659 s) : 0, 10658702
Agent [candidate] (1.053 s) : 0, 1053334
Total [candidate] (10.81 s) : 0, 10810384
section appsec
Agent [baseline] (1.224 s) : 0, 1223895
Total [baseline] (10.909 s) : 0, 10908934
Agent [candidate] (1.221 s) : 0, 1221039
Total [candidate] (10.852 s) : 0, 10852444
section iast
Agent [baseline] (1.19 s) : 0, 1189599
Total [baseline] (11.008 s) : 0, 11008168
Agent [candidate] (1.188 s) : 0, 1187879
Total [candidate] (10.992 s) : 0, 10992053
section profiling
Agent [baseline] (1.195 s) : 0, 1194926
Total [baseline] (10.806 s) : 0, 10806406
Agent [candidate] (1.201 s) : 0, 1201077
Total [candidate] (11.025 s) : 0, 11025107
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~93aa163f5c, baseline=1.54.0-SNAPSHOT~42be7a0b68
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (730.852 ms) : 0, 730852
BytebuddyAgent [candidate] (737.85 ms) : 0, 737850
GlobalTracer [baseline] (241.446 ms) : 0, 241446
GlobalTracer [candidate] (243.615 ms) : 0, 243615
AppSec [baseline] (30.329 ms) : 0, 30329
AppSec [candidate] (30.405 ms) : 0, 30405
Debugger [baseline] (6.41 ms) : 0, 6410
Debugger [candidate] (6.474 ms) : 0, 6474
Remote Config [baseline] (685.703 µs) : 0, 686
Remote Config [candidate] (669.448 µs) : 0, 669
Telemetry [baseline] (10.85 ms) : 0, 10850
Telemetry [candidate] (11.705 ms) : 0, 11705
section appsec
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (755.756 ms) : 0, 755756
BytebuddyAgent [candidate] (753.559 ms) : 0, 753559
GlobalTracer [baseline] (235.543 ms) : 0, 235543
GlobalTracer [candidate] (234.911 ms) : 0, 234911
AppSec [baseline] (169.741 ms) : 0, 169741
AppSec [candidate] (167.703 ms) : 0, 167703
Debugger [baseline] (7.53 ms) : 0, 7530
Debugger [candidate] (8.358 ms) : 0, 8358
Remote Config [baseline] (650.737 µs) : 0, 651
Remote Config [candidate] (632.987 µs) : 0, 633
Telemetry [baseline] (8.536 ms) : 0, 8536
Telemetry [candidate] (10.08 ms) : 0, 10080
IAST [baseline] (23.655 ms) : 0, 23655
IAST [candidate] (23.342 ms) : 0, 23342
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.48 ms) : 0, 1480
BytebuddyAgent [baseline] (858.961 ms) : 0, 858961
BytebuddyAgent [candidate] (858.899 ms) : 0, 858899
GlobalTracer [baseline] (234.36 ms) : 0, 234360
GlobalTracer [candidate] (233.476 ms) : 0, 233476
AppSec [baseline] (28.024 ms) : 0, 28024
AppSec [candidate] (26.624 ms) : 0, 26624
Debugger [baseline] (6.905 ms) : 0, 6905
Debugger [candidate] (6.15 ms) : 0, 6150
Remote Config [baseline] (614.97 µs) : 0, 615
Remote Config [candidate] (606.109 µs) : 0, 606
Telemetry [baseline] (8.396 ms) : 0, 8396
Telemetry [candidate] (8.362 ms) : 0, 8362
IAST [baseline] (29.581 ms) : 0, 29581
IAST [candidate] (31.068 ms) : 0, 31068
section profiling
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (758.551 ms) : 0, 758551
BytebuddyAgent [candidate] (762.173 ms) : 0, 762173
GlobalTracer [baseline] (222.664 ms) : 0, 222664
GlobalTracer [candidate] (224.382 ms) : 0, 224382
AppSec [baseline] (30.761 ms) : 0, 30761
AppSec [candidate] (30.816 ms) : 0, 30816
Debugger [baseline] (6.681 ms) : 0, 6681
Debugger [candidate] (7.497 ms) : 0, 7497
Remote Config [baseline] (708.93 µs) : 0, 709
Remote Config [candidate] (716.416 µs) : 0, 716
Telemetry [baseline] (15.655 ms) : 0, 15655
Telemetry [candidate] (15.652 ms) : 0, 15652
ProfilingAgent [baseline] (108.19 ms) : 0, 108190
ProfilingAgent [candidate] (107.894 ms) : 0, 107894
Profiling [baseline] (108.895 ms) : 0, 108895
Profiling [candidate] (108.586 ms) : 0, 108586
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~93aa163f5c, baseline=1.54.0-SNAPSHOT~42be7a0b68
dateFormat X
axisFormat %s
section baseline
no_agent (36.212 ms) : 35920, 36504
. : milestone, 36212,
appsec (46.813 ms) : 46396, 47230
. : milestone, 46813,
code_origins (44.735 ms) : 44358, 45112
. : milestone, 44735,
iast (43.918 ms) : 43545, 44291
. : milestone, 43918,
profiling (49.115 ms) : 48642, 49589
. : milestone, 49115,
tracing (44.637 ms) : 44246, 45028
. : milestone, 44637,
section candidate
no_agent (36.842 ms) : 36547, 37137
. : milestone, 36842,
appsec (49.077 ms) : 48650, 49503
. : milestone, 49077,
code_origins (43.93 ms) : 43555, 44305
. : milestone, 43930,
iast (44.855 ms) : 44443, 45267
. : milestone, 44855,
profiling (46.156 ms) : 45740, 46571
. : milestone, 46156,
tracing (44.408 ms) : 44048, 44767
. : milestone, 44408,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~93aa163f5c, baseline=1.54.0-SNAPSHOT~42be7a0b68
dateFormat X
axisFormat %s
section baseline
no_agent (4.417 ms) : 4359, 4474
. : milestone, 4417,
iast (9.706 ms) : 9546, 9867
. : milestone, 9706,
iast_FULL (14.223 ms) : 13933, 14512
. : milestone, 14223,
iast_GLOBAL (10.441 ms) : 10258, 10624
. : milestone, 10441,
profiling (8.676 ms) : 8543, 8808
. : milestone, 8676,
tracing (7.525 ms) : 7404, 7646
. : milestone, 7525,
section candidate
no_agent (4.33 ms) : 4276, 4385
. : milestone, 4330,
iast (9.711 ms) : 9551, 9872
. : milestone, 9711,
iast_FULL (13.54 ms) : 13272, 13808
. : milestone, 13540,
iast_GLOBAL (10.805 ms) : 10610, 11001
. : milestone, 10805,
profiling (8.739 ms) : 8602, 8876
. : milestone, 8739,
tracing (7.555 ms) : 7439, 7671
. : milestone, 7555,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~93aa163f5c, baseline=1.54.0-SNAPSHOT~42be7a0b68
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.723 ms) : 3507, 3940
. : milestone, 3723,
iast (2.213 ms) : 2150, 2275
. : milestone, 2213,
iast_GLOBAL (2.242 ms) : 2179, 2305
. : milestone, 2242,
profiling (2.044 ms) : 1995, 2094
. : milestone, 2044,
tracing (2.021 ms) : 1972, 2069
. : milestone, 2021,
section candidate
no_agent (1.49 ms) : 1478, 1502
. : milestone, 1490,
appsec (3.702 ms) : 3484, 3919
. : milestone, 3702,
iast (2.228 ms) : 2165, 2291
. : milestone, 2228,
iast_GLOBAL (2.254 ms) : 2191, 2317
. : milestone, 2254,
profiling (2.074 ms) : 2022, 2126
. : milestone, 2074,
tracing (2.054 ms) : 2004, 2103
. : milestone, 2054,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~93aa163f5c, baseline=1.54.0-SNAPSHOT~42be7a0b68
dateFormat X
axisFormat %s
section baseline
no_agent (15.502 s) : 15502000, 15502000
. : milestone, 15502000,
appsec (14.907 s) : 14907000, 14907000
. : milestone, 14907000,
iast (18.944 s) : 18944000, 18944000
. : milestone, 18944000,
iast_GLOBAL (17.846 s) : 17846000, 17846000
. : milestone, 17846000,
profiling (15.475 s) : 15475000, 15475000
. : milestone, 15475000,
tracing (15.101 s) : 15101000, 15101000
. : milestone, 15101000,
section candidate
no_agent (14.834 s) : 14834000, 14834000
. : milestone, 14834000,
appsec (14.743 s) : 14743000, 14743000
. : milestone, 14743000,
iast (18.385 s) : 18385000, 18385000
. : milestone, 18385000,
iast_GLOBAL (18.006 s) : 18006000, 18006000
. : milestone, 18006000,
profiling (15.591 s) : 15591000, 15591000
. : milestone, 15591000,
tracing (14.801 s) : 14801000, 14801000
. : milestone, 14801000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but I have two suggestions
dd-trace-core/src/main/java/datadog/trace/common/metrics/ConflatingMetricsAggregator.java
Outdated
Show resolved
Hide resolved
...race-core/src/test/groovy/datadog/trace/common/metrics/ConflatingMetricAggregatorTest.groovy
Outdated
Show resolved
Hide resolved
…atingMetricsAggregator.java Co-authored-by: Brice Dutheil <brice.dutheil@gmail.com>
What Does This Do
For customers using DJM, long running snapshot should not be counted in the stats. Rather we should count either non long running (partial version = 0) or finished long running (partial version < 0)
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]