-
Notifications
You must be signed in to change notification settings - Fork 312
Use the built-in CPU profiler on JDK 25 and Linux #9502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎯 Code Coverage 🔗 Commit SHA: 7f29569 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 15 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~7f29569c5d, baseline=1.54.0-SNAPSHOT~dacc5a50ca
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060840
Total [baseline] (8.639 s) : 0, 8639049
Agent [candidate] (1.064 s) : 0, 1064065
Total [candidate] (8.669 s) : 0, 8669130
section iast
Agent [baseline] (1.196 s) : 0, 1196368
Total [baseline] (9.34 s) : 0, 9340032
Agent [candidate] (1.183 s) : 0, 1182892
Total [candidate] (9.362 s) : 0, 9362146
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~7f29569c5d, baseline=1.54.0-SNAPSHOT~dacc5a50ca
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.499 ms) : 0, 1499
BytebuddyAgent [baseline] (732.386 ms) : 0, 732386
BytebuddyAgent [candidate] (745.971 ms) : 0, 745971
GlobalTracer [baseline] (252.102 ms) : 0, 252102
GlobalTracer [candidate] (245.499 ms) : 0, 245499
AppSec [baseline] (30.599 ms) : 0, 30599
AppSec [candidate] (30.655 ms) : 0, 30655
Debugger [baseline] (6.374 ms) : 0, 6374
Debugger [candidate] (6.51 ms) : 0, 6510
Remote Config [baseline] (691.948 µs) : 0, 692
Remote Config [candidate] (681.347 µs) : 0, 681
Telemetry [baseline] (16.15 ms) : 0, 16150
Telemetry [candidate] (11.893 ms) : 0, 11893
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (857.321 ms) : 0, 857321
BytebuddyAgent [candidate] (852.142 ms) : 0, 852142
GlobalTracer [baseline] (248.171 ms) : 0, 248171
GlobalTracer [candidate] (234.392 ms) : 0, 234392
AppSec [baseline] (25.577 ms) : 0, 25577
AppSec [candidate] (26.331 ms) : 0, 26331
Debugger [baseline] (6.053 ms) : 0, 6053
Debugger [candidate] (7.056 ms) : 0, 7056
Remote Config [baseline] (606.376 µs) : 0, 606
Remote Config [candidate] (609.474 µs) : 0, 609
Telemetry [baseline] (8.072 ms) : 0, 8072
Telemetry [candidate] (8.404 ms) : 0, 8404
IAST [baseline] (28.073 ms) : 0, 28073
IAST [candidate] (31.483 ms) : 0, 31483
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~7f29569c5d, baseline=1.54.0-SNAPSHOT~dacc5a50ca
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063762
Total [baseline] (10.724 s) : 0, 10723662
Agent [candidate] (1.045 s) : 0, 1045086
Total [candidate] (10.766 s) : 0, 10765619
section appsec
Agent [baseline] (1.237 s) : 0, 1237053
Total [baseline] (10.95 s) : 0, 10950499
Agent [candidate] (1.232 s) : 0, 1231506
Total [candidate] (10.858 s) : 0, 10857923
section iast
Agent [baseline] (1.191 s) : 0, 1190806
Total [baseline] (11.041 s) : 0, 11040511
Agent [candidate] (1.18 s) : 0, 1180196
Total [candidate] (10.934 s) : 0, 10934030
section profiling
Agent [baseline] (1.21 s) : 0, 1210316
Total [baseline] (10.869 s) : 0, 10869400
Agent [candidate] (1.198 s) : 0, 1198298
Total [candidate] (10.879 s) : 0, 10878750
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~7f29569c5d, baseline=1.54.0-SNAPSHOT~dacc5a50ca
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (733.039 ms) : 0, 733039
BytebuddyAgent [candidate] (730.777 ms) : 0, 730777
GlobalTracer [baseline] (254.132 ms) : 0, 254132
GlobalTracer [candidate] (241.586 ms) : 0, 241586
AppSec [baseline] (30.776 ms) : 0, 30776
AppSec [candidate] (29.975 ms) : 0, 29975
Debugger [baseline] (6.421 ms) : 0, 6421
Debugger [candidate] (6.429 ms) : 0, 6429
Remote Config [baseline] (697.44 µs) : 0, 697
Remote Config [candidate] (676.306 µs) : 0, 676
Telemetry [baseline] (16.084 ms) : 0, 16084
Telemetry [candidate] (13.128 ms) : 0, 13128
section appsec
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (757.704 ms) : 0, 757704
BytebuddyAgent [candidate] (760.689 ms) : 0, 760689
GlobalTracer [baseline] (246.258 ms) : 0, 246258
GlobalTracer [candidate] (236.572 ms) : 0, 236572
AppSec [baseline] (171.35 ms) : 0, 171350
AppSec [candidate] (170.115 ms) : 0, 170115
Debugger [baseline] (6.025 ms) : 0, 6025
Debugger [candidate] (8.422 ms) : 0, 8422
Remote Config [baseline] (606.736 µs) : 0, 607
Remote Config [candidate] (639.685 µs) : 0, 640
Telemetry [baseline] (8.469 ms) : 0, 8469
Telemetry [candidate] (8.541 ms) : 0, 8541
IAST [baseline] (23.783 ms) : 0, 23783
IAST [candidate] (23.844 ms) : 0, 23844
section iast
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (852.041 ms) : 0, 852041
BytebuddyAgent [candidate] (850.997 ms) : 0, 850997
GlobalTracer [baseline] (247.079 ms) : 0, 247079
GlobalTracer [candidate] (233.362 ms) : 0, 233362
AppSec [baseline] (25.501 ms) : 0, 25501
AppSec [candidate] (26.911 ms) : 0, 26911
Debugger [baseline] (6.037 ms) : 0, 6037
Debugger [candidate] (7.044 ms) : 0, 7044
Remote Config [baseline] (594.653 µs) : 0, 595
Remote Config [candidate] (640.94 µs) : 0, 641
Telemetry [baseline] (8.196 ms) : 0, 8196
Telemetry [candidate] (8.34 ms) : 0, 8340
IAST [baseline] (28.818 ms) : 0, 28818
IAST [candidate] (30.35 ms) : 0, 30350
section profiling
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (761.611 ms) : 0, 761611
BytebuddyAgent [candidate] (761.281 ms) : 0, 761281
GlobalTracer [baseline] (233.676 ms) : 0, 233676
GlobalTracer [candidate] (223.095 ms) : 0, 223095
AppSec [baseline] (30.485 ms) : 0, 30485
AppSec [candidate] (30.412 ms) : 0, 30412
Debugger [baseline] (10.575 ms) : 0, 10575
Debugger [candidate] (7.475 ms) : 0, 7475
Remote Config [baseline] (743.511 µs) : 0, 744
Remote Config [candidate] (692.567 µs) : 0, 693
Telemetry [baseline] (11.707 ms) : 0, 11707
Telemetry [candidate] (15.696 ms) : 0, 15696
ProfilingAgent [baseline] (108.907 ms) : 0, 108907
ProfilingAgent [candidate] (107.694 ms) : 0, 107694
Profiling [baseline] (109.575 ms) : 0, 109575
Profiling [candidate] (108.392 ms) : 0, 108392
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~7f29569c5d, baseline=1.54.0-SNAPSHOT~dacc5a50ca
dateFormat X
axisFormat %s
section baseline
no_agent (37.489 ms) : 37186, 37792
. : milestone, 37489,
appsec (47.319 ms) : 46902, 47735
. : milestone, 47319,
code_origins (45.805 ms) : 45424, 46185
. : milestone, 45805,
iast (45.112 ms) : 44721, 45503
. : milestone, 45112,
profiling (49.457 ms) : 48991, 49923
. : milestone, 49457,
tracing (44.521 ms) : 44146, 44897
. : milestone, 44521,
section candidate
no_agent (36.336 ms) : 36045, 36627
. : milestone, 36336,
appsec (47.212 ms) : 46777, 47648
. : milestone, 47212,
code_origins (45.611 ms) : 45210, 46013
. : milestone, 45611,
iast (44.974 ms) : 44581, 45367
. : milestone, 44974,
profiling (50.599 ms) : 50134, 51064
. : milestone, 50599,
tracing (43.628 ms) : 43257, 43998
. : milestone, 43628,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~7f29569c5d, baseline=1.54.0-SNAPSHOT~dacc5a50ca
dateFormat X
axisFormat %s
section baseline
no_agent (4.328 ms) : 4273, 4383
. : milestone, 4328,
iast (9.612 ms) : 9445, 9780
. : milestone, 9612,
iast_FULL (14.292 ms) : 14004, 14581
. : milestone, 14292,
iast_GLOBAL (10.109 ms) : 9929, 10290
. : milestone, 10109,
profiling (9.093 ms) : 8946, 9240
. : milestone, 9093,
tracing (7.68 ms) : 7571, 7789
. : milestone, 7680,
section candidate
no_agent (4.368 ms) : 4314, 4423
. : milestone, 4368,
iast (9.712 ms) : 9549, 9875
. : milestone, 9712,
iast_FULL (13.923 ms) : 13650, 14197
. : milestone, 13923,
iast_GLOBAL (10.273 ms) : 10091, 10454
. : milestone, 10273,
profiling (9.126 ms) : 8972, 9280
. : milestone, 9126,
tracing (8.069 ms) : 7949, 8189
. : milestone, 8069,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~7f29569c5d, baseline=1.54.0-SNAPSHOT~dacc5a50ca
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.722 ms) : 3503, 3940
. : milestone, 3722,
iast (2.194 ms) : 2131, 2256
. : milestone, 2194,
iast_GLOBAL (2.241 ms) : 2178, 2304
. : milestone, 2241,
profiling (2.066 ms) : 2014, 2118
. : milestone, 2066,
tracing (2.011 ms) : 1963, 2059
. : milestone, 2011,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.592 ms) : 3379, 3805
. : milestone, 3592,
iast (2.205 ms) : 2142, 2268
. : milestone, 2205,
iast_GLOBAL (2.237 ms) : 2174, 2300
. : milestone, 2237,
profiling (2.038 ms) : 1988, 2089
. : milestone, 2038,
tracing (2.007 ms) : 1959, 2056
. : milestone, 2007,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~7f29569c5d, baseline=1.54.0-SNAPSHOT~dacc5a50ca
dateFormat X
axisFormat %s
section baseline
no_agent (14.997 s) : 14997000, 14997000
. : milestone, 14997000,
appsec (15.072 s) : 15072000, 15072000
. : milestone, 15072000,
iast (18.897 s) : 18897000, 18897000
. : milestone, 18897000,
iast_GLOBAL (18.105 s) : 18105000, 18105000
. : milestone, 18105000,
profiling (15.347 s) : 15347000, 15347000
. : milestone, 15347000,
tracing (14.918 s) : 14918000, 14918000
. : milestone, 14918000,
section candidate
no_agent (15.616 s) : 15616000, 15616000
. : milestone, 15616000,
appsec (15.128 s) : 15128000, 15128000
. : milestone, 15128000,
iast (18.505 s) : 18505000, 18505000
. : milestone, 18505000,
iast_GLOBAL (18.142 s) : 18142000, 18142000
. : milestone, 18142000,
profiling (15.42 s) : 15420000, 15420000
. : milestone, 15420000,
tracing (15.045 s) : 15045000, 15045000
. : milestone, 15045000,
|
...roller-openjdk/src/main/java/com/datadog/profiling/controller/openjdk/OpenJdkController.java
Show resolved
Hide resolved
...ling-integration-tests/src/test/java/datadog/smoketest/JFRBasedProfilingIntegrationTest.java
Outdated
Show resolved
Hide resolved
...ling-integration-tests/src/test/java/datadog/smoketest/JFRBasedProfilingIntegrationTest.java
Outdated
Show resolved
Hide resolved
...ling-integration-tests/src/test/java/datadog/smoketest/JFRBasedProfilingIntegrationTest.java
Outdated
Show resolved
Hide resolved
Sorry about the churn. |
What Does This Do
The change makes the JDK 25+
CPUTimeSample
to be the event to generate the CPU profiles when using only JFR on supported platforms.Motivation
Use the better source of CPU profiling data where and when available.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: PROF-12473