-
Notifications
You must be signed in to change notification settings - Fork 312
Fix error logged for Bridge methods #9504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We avoid to instrument Bridge method but we don't want to log error for method not found. So introduce a skip status for method matching to differentiate if we skip instrumentation but still we have found the method
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (322.712 µs) : 293, 352
. : milestone, 323,
basic (279.508 µs) : 273, 286
. : milestone, 280,
loop (8.958 ms) : 8954, 8962
. : milestone, 8958,
section candidate
noprobe (317.428 µs) : 289, 346
. : milestone, 317,
basic (281.971 µs) : 275, 289
. : milestone, 282,
loop (8.965 ms) : 8959, 8970
. : milestone, 8965,
|
🎯 Code Coverage 🔗 Commit SHA: e5027d8 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~e5027d816b, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050733
Total [baseline] (8.676 s) : 0, 8676106
Agent [candidate] (1.056 s) : 0, 1055696
Total [candidate] (8.641 s) : 0, 8641340
section iast
Agent [baseline] (1.185 s) : 0, 1185114
Total [baseline] (9.401 s) : 0, 9400543
Agent [candidate] (1.186 s) : 0, 1185547
Total [candidate] (9.373 s) : 0, 9373489
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~e5027d816b, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (735.619 ms) : 0, 735619
BytebuddyAgent [candidate] (739.93 ms) : 0, 739930
GlobalTracer [baseline] (242.289 ms) : 0, 242289
GlobalTracer [candidate] (242.723 ms) : 0, 242723
AppSec [baseline] (30.56 ms) : 0, 30560
AppSec [candidate] (30.188 ms) : 0, 30188
Debugger [baseline] (6.401 ms) : 0, 6401
Debugger [candidate] (6.411 ms) : 0, 6411
Remote Config [baseline] (682.267 µs) : 0, 682
Remote Config [candidate] (676.535 µs) : 0, 677
Telemetry [baseline] (12.578 ms) : 0, 12578
Telemetry [candidate] (13.09 ms) : 0, 13090
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (854.573 ms) : 0, 854573
BytebuddyAgent [candidate] (855.638 ms) : 0, 855638
GlobalTracer [baseline] (233.949 ms) : 0, 233949
GlobalTracer [candidate] (233.589 ms) : 0, 233589
IAST [baseline] (28.87 ms) : 0, 28870
IAST [candidate] (31.483 ms) : 0, 31483
AppSec [baseline] (27.384 ms) : 0, 27384
AppSec [candidate] (25.35 ms) : 0, 25350
Debugger [baseline] (8.813 ms) : 0, 8813
Debugger [candidate] (7.958 ms) : 0, 7958
Remote Config [baseline] (620.919 µs) : 0, 621
Remote Config [candidate] (616.761 µs) : 0, 617
Telemetry [baseline] (8.323 ms) : 0, 8323
Telemetry [candidate] (8.396 ms) : 0, 8396
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~e5027d816b, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047724
Total [baseline] (10.769 s) : 0, 10769148
Agent [candidate] (1.056 s) : 0, 1056125
Total [candidate] (10.786 s) : 0, 10786378
section appsec
Agent [baseline] (1.227 s) : 0, 1227330
Total [baseline] (10.835 s) : 0, 10834836
Agent [candidate] (1.226 s) : 0, 1225660
Total [candidate] (10.854 s) : 0, 10853537
section iast
Agent [baseline] (1.184 s) : 0, 1183784
Total [baseline] (10.952 s) : 0, 10951681
Agent [candidate] (1.182 s) : 0, 1181725
Total [candidate] (10.979 s) : 0, 10979150
section profiling
Agent [baseline] (1.201 s) : 0, 1200901
Total [baseline] (10.953 s) : 0, 10952544
Agent [candidate] (1.201 s) : 0, 1200820
Total [candidate] (10.938 s) : 0, 10938162
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~e5027d816b, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (732.622 ms) : 0, 732622
BytebuddyAgent [candidate] (737.846 ms) : 0, 737846
GlobalTracer [baseline] (242.618 ms) : 0, 242618
GlobalTracer [candidate] (244.251 ms) : 0, 244251
AppSec [baseline] (30.476 ms) : 0, 30476
AppSec [candidate] (30.339 ms) : 0, 30339
Debugger [baseline] (6.471 ms) : 0, 6471
Debugger [candidate] (6.473 ms) : 0, 6473
Remote Config [baseline] (686.349 µs) : 0, 686
Remote Config [candidate] (680.398 µs) : 0, 680
Telemetry [baseline] (12.199 ms) : 0, 12199
Telemetry [candidate] (13.796 ms) : 0, 13796
section appsec
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (756.745 ms) : 0, 756745
BytebuddyAgent [candidate] (755.356 ms) : 0, 755356
GlobalTracer [baseline] (236.658 ms) : 0, 236658
GlobalTracer [candidate] (236.322 ms) : 0, 236322
IAST [baseline] (23.65 ms) : 0, 23650
IAST [candidate] (23.755 ms) : 0, 23755
AppSec [baseline] (169.58 ms) : 0, 169580
AppSec [candidate] (168.599 ms) : 0, 168599
Debugger [baseline] (8.402 ms) : 0, 8402
Debugger [candidate] (8.385 ms) : 0, 8385
Remote Config [baseline] (646.365 µs) : 0, 646
Remote Config [candidate] (635.118 µs) : 0, 635
Telemetry [baseline] (9.212 ms) : 0, 9212
Telemetry [candidate] (10.055 ms) : 0, 10055
section iast
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (853.21 ms) : 0, 853210
BytebuddyAgent [candidate] (853.771 ms) : 0, 853771
GlobalTracer [baseline] (233.9 ms) : 0, 233900
GlobalTracer [candidate] (232.382 ms) : 0, 232382
IAST [baseline] (27.908 ms) : 0, 27908
IAST [candidate] (28.613 ms) : 0, 28613
AppSec [baseline] (30.11 ms) : 0, 30110
AppSec [candidate] (27.537 ms) : 0, 27537
Debugger [baseline] (6.984 ms) : 0, 6984
Debugger [candidate] (7.001 ms) : 0, 7001
Remote Config [baseline] (611.111 µs) : 0, 611
Remote Config [candidate] (605.616 µs) : 0, 606
Telemetry [baseline] (8.332 ms) : 0, 8332
Telemetry [candidate] (9.192 ms) : 0, 9192
section profiling
crashtracking [baseline] (1.429 ms) : 0, 1429
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (762.606 ms) : 0, 762606
BytebuddyAgent [candidate] (763.035 ms) : 0, 763035
GlobalTracer [baseline] (223.302 ms) : 0, 223302
GlobalTracer [candidate] (222.953 ms) : 0, 222953
AppSec [baseline] (30.879 ms) : 0, 30879
AppSec [candidate] (30.653 ms) : 0, 30653
Debugger [baseline] (8.199 ms) : 0, 8199
Debugger [candidate] (6.721 ms) : 0, 6721
Remote Config [baseline] (725.277 µs) : 0, 725
Remote Config [candidate] (707.974 µs) : 0, 708
Telemetry [baseline] (14.891 ms) : 0, 14891
Telemetry [candidate] (16.358 ms) : 0, 16358
ProfilingAgent [baseline] (108.345 ms) : 0, 108345
ProfilingAgent [candidate] (108.326 ms) : 0, 108326
Profiling [baseline] (109.031 ms) : 0, 109031
Profiling [candidate] (109.009 ms) : 0, 109009
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~e5027d816b, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section baseline
no_agent (4.355 ms) : 4305, 4405
. : milestone, 4355,
iast (9.189 ms) : 9034, 9344
. : milestone, 9189,
iast_FULL (13.725 ms) : 13447, 14002
. : milestone, 13725,
iast_GLOBAL (10.644 ms) : 10456, 10832
. : milestone, 10644,
profiling (8.946 ms) : 8797, 9095
. : milestone, 8946,
tracing (7.979 ms) : 7855, 8103
. : milestone, 7979,
section candidate
no_agent (4.489 ms) : 4438, 4540
. : milestone, 4489,
iast (9.72 ms) : 9557, 9883
. : milestone, 9720,
iast_FULL (14.154 ms) : 13867, 14440
. : milestone, 14154,
iast_GLOBAL (10.075 ms) : 9899, 10250
. : milestone, 10075,
profiling (8.952 ms) : 8813, 9091
. : milestone, 8952,
tracing (7.797 ms) : 7686, 7908
. : milestone, 7797,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~e5027d816b, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section baseline
no_agent (37.776 ms) : 37468, 38083
. : milestone, 37776,
appsec (48.966 ms) : 48536, 49397
. : milestone, 48966,
code_origins (45.217 ms) : 44835, 45599
. : milestone, 45217,
iast (43.764 ms) : 43391, 44137
. : milestone, 43764,
profiling (48.833 ms) : 48346, 49320
. : milestone, 48833,
tracing (43.4 ms) : 43042, 43759
. : milestone, 43400,
section candidate
no_agent (37.99 ms) : 37688, 38292
. : milestone, 37990,
appsec (48.7 ms) : 48269, 49131
. : milestone, 48700,
code_origins (44.173 ms) : 43801, 44545
. : milestone, 44173,
iast (44.792 ms) : 44387, 45196
. : milestone, 44792,
profiling (48.843 ms) : 48391, 49294
. : milestone, 48843,
tracing (46.37 ms) : 45969, 46770
. : milestone, 46370,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~e5027d816b, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section baseline
no_agent (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
appsec (14.878 s) : 14878000, 14878000
. : milestone, 14878000,
iast (18.445 s) : 18445000, 18445000
. : milestone, 18445000,
iast_GLOBAL (18.245 s) : 18245000, 18245000
. : milestone, 18245000,
profiling (15.408 s) : 15408000, 15408000
. : milestone, 15408000,
tracing (14.91 s) : 14910000, 14910000
. : milestone, 14910000,
section candidate
no_agent (14.758 s) : 14758000, 14758000
. : milestone, 14758000,
appsec (14.778 s) : 14778000, 14778000
. : milestone, 14778000,
iast (18.433 s) : 18433000, 18433000
. : milestone, 18433000,
iast_GLOBAL (18.021 s) : 18021000, 18021000
. : milestone, 18021000,
profiling (15.262 s) : 15262000, 15262000
. : milestone, 15262000,
tracing (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~e5027d816b, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.504 ms) : 2451, 2558
. : milestone, 2504,
iast (2.202 ms) : 2139, 2265
. : milestone, 2202,
iast_GLOBAL (2.235 ms) : 2172, 2298
. : milestone, 2235,
profiling (2.031 ms) : 1980, 2081
. : milestone, 2031,
tracing (2.003 ms) : 1955, 2052
. : milestone, 2003,
section candidate
no_agent (1.475 ms) : 1463, 1487
. : milestone, 1475,
appsec (2.441 ms) : 2389, 2494
. : milestone, 2441,
iast (2.192 ms) : 2129, 2254
. : milestone, 2192,
iast_GLOBAL (2.234 ms) : 2171, 2297
. : milestone, 2234,
profiling (2.054 ms) : 2002, 2106
. : milestone, 2054,
tracing (2.004 ms) : 1956, 2053
. : milestone, 2004,
|
What Does This Do
We avoid to instrument Bridge method but we don't want to log error for method not found. So introduce a skip status for method matching to differentiate if we skip instrumentation but still we have found the method
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-4428