-
Notifications
You must be signed in to change notification settings - Fork 312
Migrate tests and ConfigInversionMetricCollector
to config-utils
module
#9566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 3 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~16b9315e0e, baseline=1.54.0-SNAPSHOT~11e677e239
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1013734
Total [baseline] (10.686 s) : 0, 10685706
Agent [candidate] (1.027 s) : 0, 1026754
Total [candidate] (10.76 s) : 0, 10759581
section appsec
Agent [baseline] (1.192 s) : 0, 1192223
Total [baseline] (11.026 s) : 0, 11025835
Agent [candidate] (1.19 s) : 0, 1190037
Total [candidate] (10.956 s) : 0, 10955745
section iast
Agent [baseline] (1.156 s) : 0, 1156127
Total [baseline] (11.084 s) : 0, 11084218
Agent [candidate] (1.151 s) : 0, 1151439
Total [candidate] (10.981 s) : 0, 10980863
section profiling
Agent [baseline] (1.151 s) : 0, 1150685
Total [baseline] (9.682 s) : 0, 9681834
Agent [candidate] (1.156 s) : 0, 1156337
Total [candidate] (11.062 s) : 0, 11061953
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~16b9315e0e, baseline=1.54.0-SNAPSHOT~11e677e239
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.48 ms) : 0, 1480
BytebuddyAgent [baseline] (693.871 ms) : 0, 693871
BytebuddyAgent [candidate] (702.643 ms) : 0, 702643
GlobalTracer [baseline] (249.693 ms) : 0, 249693
GlobalTracer [candidate] (252.827 ms) : 0, 252827
AppSec [baseline] (31.4 ms) : 0, 31400
AppSec [candidate] (32.003 ms) : 0, 32003
Debugger [baseline] (6.436 ms) : 0, 6436
Debugger [candidate] (6.547 ms) : 0, 6547
Remote Config [baseline] (685.149 µs) : 0, 685
Remote Config [candidate] (706.104 µs) : 0, 706
Telemetry [baseline] (8.996 ms) : 0, 8996
Telemetry [candidate] (9.204 ms) : 0, 9204
section appsec
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (714.78 ms) : 0, 714780
BytebuddyAgent [candidate] (713.92 ms) : 0, 713920
GlobalTracer [baseline] (241.354 ms) : 0, 241354
GlobalTracer [candidate] (240.756 ms) : 0, 240756
AppSec [baseline] (172.628 ms) : 0, 172628
AppSec [candidate] (171.289 ms) : 0, 171289
Debugger [baseline] (6.023 ms) : 0, 6023
Debugger [candidate] (6.044 ms) : 0, 6044
Remote Config [baseline] (648.91 µs) : 0, 649
Remote Config [candidate] (641.71 µs) : 0, 642
Telemetry [baseline] (9.311 ms) : 0, 9311
Telemetry [candidate] (9.933 ms) : 0, 9933
IAST [baseline] (24.757 ms) : 0, 24757
IAST [candidate] (24.826 ms) : 0, 24826
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (817.754 ms) : 0, 817754
BytebuddyAgent [candidate] (814.179 ms) : 0, 814179
GlobalTracer [baseline] (239.882 ms) : 0, 239882
GlobalTracer [candidate] (239.149 ms) : 0, 239149
AppSec [baseline] (33.971 ms) : 0, 33971
AppSec [candidate] (33.717 ms) : 0, 33717
Debugger [baseline] (6.165 ms) : 0, 6165
Debugger [candidate] (6.15 ms) : 0, 6150
Remote Config [baseline] (613.606 µs) : 0, 614
Remote Config [candidate] (599.024 µs) : 0, 599
Telemetry [baseline] (8.439 ms) : 0, 8439
Telemetry [candidate] (8.408 ms) : 0, 8408
IAST [baseline] (26.499 ms) : 0, 26499
IAST [candidate] (26.283 ms) : 0, 26283
section profiling
ProfilingAgent [baseline] (100.638 ms) : 0, 100638
ProfilingAgent [candidate] (101.244 ms) : 0, 101244
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (717.558 ms) : 0, 717558
BytebuddyAgent [candidate] (720.967 ms) : 0, 720967
GlobalTracer [baseline] (224.059 ms) : 0, 224059
GlobalTracer [candidate] (225.258 ms) : 0, 225258
AppSec [baseline] (31.378 ms) : 0, 31378
AppSec [candidate] (31.326 ms) : 0, 31326
Debugger [baseline] (6.649 ms) : 0, 6649
Debugger [candidate] (6.531 ms) : 0, 6531
Remote Config [baseline] (719.79 µs) : 0, 720
Remote Config [candidate] (710.499 µs) : 0, 710
Telemetry [baseline] (16.233 ms) : 0, 16233
Telemetry [candidate] (16.368 ms) : 0, 16368
Profiling [baseline] (101.234 ms) : 0, 101234
Profiling [candidate] (101.842 ms) : 0, 101842
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~16b9315e0e, baseline=1.54.0-SNAPSHOT~11e677e239
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1016162
Total [baseline] (8.672 s) : 0, 8672312
Agent [candidate] (1.01 s) : 0, 1010477
Total [candidate] (8.675 s) : 0, 8675161
section iast
Agent [baseline] (1.15 s) : 0, 1150442
Total [baseline] (9.249 s) : 0, 9248845
Agent [candidate] (1.159 s) : 0, 1158810
Total [candidate] (9.273 s) : 0, 9273099
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~16b9315e0e, baseline=1.54.0-SNAPSHOT~11e677e239
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (695.073 ms) : 0, 695073
BytebuddyAgent [candidate] (691.495 ms) : 0, 691495
GlobalTracer [baseline] (250.471 ms) : 0, 250471
GlobalTracer [candidate] (248.898 ms) : 0, 248898
AppSec [baseline] (31.635 ms) : 0, 31635
AppSec [candidate] (31.337 ms) : 0, 31337
Debugger [baseline] (6.49 ms) : 0, 6490
Debugger [candidate] (6.378 ms) : 0, 6378
Remote Config [baseline] (693.369 µs) : 0, 693
Remote Config [candidate] (679.134 µs) : 0, 679
Telemetry [baseline] (9.215 ms) : 0, 9215
Telemetry [candidate] (9.061 ms) : 0, 9061
section iast
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.488 ms) : 0, 1488
BytebuddyAgent [baseline] (814.957 ms) : 0, 814957
BytebuddyAgent [candidate] (819.966 ms) : 0, 819966
GlobalTracer [baseline] (237.556 ms) : 0, 237556
GlobalTracer [candidate] (240.191 ms) : 0, 240191
AppSec [baseline] (33.92 ms) : 0, 33920
AppSec [candidate] (33.932 ms) : 0, 33932
Debugger [baseline] (6.053 ms) : 0, 6053
Debugger [candidate] (6.16 ms) : 0, 6160
Remote Config [baseline] (584.142 µs) : 0, 584
Remote Config [candidate] (609.686 µs) : 0, 610
Telemetry [baseline] (8.335 ms) : 0, 8335
Telemetry [candidate] (8.442 ms) : 0, 8442
IAST [baseline] (26.212 ms) : 0, 26212
IAST [candidate] (26.616 ms) : 0, 26616
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 3 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~16b9315e0e, baseline=1.54.0-SNAPSHOT~11e677e239
dateFormat X
axisFormat %s
section baseline
no_agent (37.216 ms) : 36918, 37514
. : milestone, 37216,
appsec (48.456 ms) : 48024, 48889
. : milestone, 48456,
code_origins (43.195 ms) : 42819, 43570
. : milestone, 43195,
iast (45.882 ms) : 45493, 46271
. : milestone, 45882,
profiling (45.408 ms) : 44995, 45820
. : milestone, 45408,
tracing (45.347 ms) : 44957, 45737
. : milestone, 45347,
section candidate
no_agent (35.999 ms) : 35708, 36289
. : milestone, 35999,
appsec (46.829 ms) : 46403, 47255
. : milestone, 46829,
code_origins (43.715 ms) : 43328, 44102
. : milestone, 43715,
iast (45.54 ms) : 45162, 45918
. : milestone, 45540,
profiling (48.336 ms) : 47885, 48787
. : milestone, 48336,
tracing (43.255 ms) : 42888, 43621
. : milestone, 43255,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~16b9315e0e, baseline=1.54.0-SNAPSHOT~11e677e239
dateFormat X
axisFormat %s
section baseline
no_agent (4.373 ms) : 4323, 4423
. : milestone, 4373,
iast (10.281 ms) : 10107, 10455
. : milestone, 10281,
iast_FULL (13.692 ms) : 13423, 13961
. : milestone, 13692,
iast_GLOBAL (10.859 ms) : 10657, 11061
. : milestone, 10859,
profiling (8.977 ms) : 8826, 9129
. : milestone, 8977,
tracing (7.671 ms) : 7555, 7788
. : milestone, 7671,
section candidate
no_agent (4.388 ms) : 4339, 4438
. : milestone, 4388,
iast (9.926 ms) : 9749, 10104
. : milestone, 9926,
iast_FULL (15.339 ms) : 15028, 15651
. : milestone, 15339,
iast_GLOBAL (10.987 ms) : 10785, 11189
. : milestone, 10987,
profiling (9.145 ms) : 9000, 9289
. : milestone, 9145,
tracing (7.995 ms) : 7876, 8113
. : milestone, 7995,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~16b9315e0e, baseline=1.54.0-SNAPSHOT~11e677e239
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.517 ms) : 2464, 2571
. : milestone, 2517,
iast (2.203 ms) : 2140, 2265
. : milestone, 2203,
iast_GLOBAL (2.243 ms) : 2181, 2306
. : milestone, 2243,
profiling (2.076 ms) : 2024, 2128
. : milestone, 2076,
tracing (2.027 ms) : 1978, 2076
. : milestone, 2027,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.742 ms) : 3526, 3958
. : milestone, 3742,
iast (2.202 ms) : 2139, 2265
. : milestone, 2202,
iast_GLOBAL (2.24 ms) : 2177, 2302
. : milestone, 2240,
profiling (2.059 ms) : 2007, 2111
. : milestone, 2059,
tracing (2.035 ms) : 1986, 2084
. : milestone, 2035,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~16b9315e0e, baseline=1.54.0-SNAPSHOT~11e677e239
dateFormat X
axisFormat %s
section baseline
no_agent (14.841 s) : 14841000, 14841000
. : milestone, 14841000,
appsec (15.185 s) : 15185000, 15185000
. : milestone, 15185000,
iast (18.671 s) : 18671000, 18671000
. : milestone, 18671000,
iast_GLOBAL (17.854 s) : 17854000, 17854000
. : milestone, 17854000,
profiling (15.451 s) : 15451000, 15451000
. : milestone, 15451000,
tracing (15.055 s) : 15055000, 15055000
. : milestone, 15055000,
section candidate
no_agent (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
appsec (15.06 s) : 15060000, 15060000
. : milestone, 15060000,
iast (18.564 s) : 18564000, 18564000
. : milestone, 18564000,
iast_GLOBAL (18.136 s) : 18136000, 18136000
. : milestone, 18136000,
profiling (15.339 s) : 15339000, 15339000
. : milestone, 15339000,
tracing (15.1 s) : 15100000, 15100000
. : milestone, 15100000,
|
57483a2
to
1574d9b
Compare
🎯 Code Coverage 🔗 Commit SHA: 16b9315 | Docs | Was this helpful? Give us feedback! |
What Does This Do
This PR migrates the tests from the classes in #9426 to
config-utils
, and migrates an abstracted version ofConfigInversionMetricCollector
toconfig-utils
while keeping the implementation ininternal-api
. This way, the telemetry can be used inconfig-utils
but still registered within theConfig
object.Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]