Skip to content

Add downstream HTTP request/response analysis for OkHttp2 client #9572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 1, 2025
Merged

Add downstream HTTP request/response analysis for OkHttp2 client #9572

merged 9 commits into from
Oct 1, 2025

Conversation

manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Sep 19, 2025 •
edited
Loading

What Does This Do

Adds support for downstream HTTP request and response analysis in the OkHttp2 client instrumentation.

Motivation

Enable AppSec to analyze outbound requests made through OkHttp2. This expands coverage for API security and SSRF protections, while supporting downstream traffic inspection with configurable sampling.

Additional Notes

RFC

Contributor Checklist

Jira ticket: APPSEC-58613

@manuel-alvarez-alvarez manuel-alvarez-alvarez added inst: others All other instrumentations comp: asm waf Application Security Management (WAF) labels Sep 19, 2025
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title Add http downstream request analysis for OkHttp2 Add downstream HTTP request/response analysis for OkHttp2 client Sep 19, 2025
@pr-commenter
Copy link

pr-commenter bot commented Sep 19, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/appsec-downstream-http
git_commit_date 1758889621 1758903342
git_commit_sha 4cf7670 2768645
release_version 1.54.0-SNAPSHOT~4cf767062c 1.54.0-SNAPSHOT~2768645057
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1758905197 1758905197
ci_job_id 1150306655 1150306655
ci_pipeline_id 77674826 77674826
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-8ffl738y 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-8ffl738y 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 3 performance regressions! Performance is the same for 55 metrics, 7 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast:AppSec worse
[+1.093ms; +2.014ms] or [+3.266%; +6.019%]		 35.005ms 33.452ms
scenario:startup:petclinic:profiling:AppSec worse
[+1.132ms; +1.750ms] or [+3.604%; +5.573%]		 32.846ms 31.405ms
scenario:startup:petclinic:profiling:Profiling worse
[+5.346ms; +7.073ms] or [+5.261%; +6.960%]		 107.830ms 101.621ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~2768645057, baseline=1.54.0-SNAPSHOT~4cf767062c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018910
Total [baseline] (8.669 s) : 0, 8668927
Agent [candidate] (1.015 s) : 0, 1015287
Total [candidate] (8.663 s) : 0, 8663401
section iast
Agent [baseline] (1.143 s) : 0, 1143447
Total [baseline] (9.245 s) : 0, 9245090
Agent [candidate] (1.146 s) : 0, 1145562
Total [candidate] (9.241 s) : 0, 9241452
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.019 s -
Agent iast 1.143 s 124.537 ms (12.2%)
Total tracing 8.669 s -
Total iast 9.245 s 576.163 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.015 s -
Agent iast 1.146 s 130.275 ms (12.8%)
Total tracing 8.663 s -
Total iast 9.241 s 578.051 ms (6.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~2768645057, baseline=1.54.0-SNAPSHOT~4cf767062c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (693.513 ms) : 0, 693513
BytebuddyAgent [candidate] (691.467 ms) : 0, 691467
GlobalTracer [baseline] (244.097 ms) : 0, 244097
GlobalTracer [candidate] (243.059 ms) : 0, 243059
AppSec [baseline] (31.536 ms) : 0, 31536
AppSec [candidate] (32.639 ms) : 0, 32639
Debugger [baseline] (6.353 ms) : 0, 6353
Debugger [candidate] (6.347 ms) : 0, 6347
Remote Config [baseline] (700.655 µs) : 0, 701
Remote Config [candidate] (676.223 µs) : 0, 676
Telemetry [baseline] (9.109 ms) : 0, 9109
Telemetry [candidate] (9.021 ms) : 0, 9021
Flare Poller [baseline] (10.892 ms) : 0, 10892
Flare Poller [candidate] (9.438 ms) : 0, 9438
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (809.776 ms) : 0, 809776
BytebuddyAgent [candidate] (809.622 ms) : 0, 809622
GlobalTracer [baseline] (232.071 ms) : 0, 232071
GlobalTracer [candidate] (233.041 ms) : 0, 233041
AppSec [baseline] (33.452 ms) : 0, 33452
AppSec [candidate] (35.005 ms) : 0, 35005
Debugger [baseline] (6.045 ms) : 0, 6045
Debugger [candidate] (6.083 ms) : 0, 6083
Remote Config [baseline] (582.692 µs) : 0, 583
Remote Config [candidate] (579.003 µs) : 0, 579
Telemetry [baseline] (8.171 ms) : 0, 8171
Telemetry [candidate] (8.054 ms) : 0, 8054
Flare Poller [baseline] (4.278 ms) : 0, 4278
Flare Poller [candidate] (4.295 ms) : 0, 4295
IAST [baseline] (26.246 ms) : 0, 26246
IAST [candidate] (26.285 ms) : 0, 26285
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~2768645057, baseline=1.54.0-SNAPSHOT~4cf767062c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020439
Total [baseline] (10.671 s) : 0, 10671494
Agent [candidate] (1.015 s) : 0, 1014519
Total [candidate] (10.64 s) : 0, 10640136
section appsec
Agent [baseline] (1.185 s) : 0, 1185095
Total [baseline] (11.017 s) : 0, 11017319
Agent [candidate] (1.191 s) : 0, 1190750
Total [candidate] (11.073 s) : 0, 11073211
section iast
Agent [baseline] (1.145 s) : 0, 1145133
Total [baseline] (10.981 s) : 0, 10980695
Agent [candidate] (1.144 s) : 0, 1144354
Total [candidate] (10.921 s) : 0, 10920947
section profiling
Agent [baseline] (1.152 s) : 0, 1151728
Total [baseline] (11.088 s) : 0, 11087939
Agent [candidate] (1.16 s) : 0, 1159644
Total [candidate] (11.067 s) : 0, 11066997
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.02 s -
Agent appsec 1.185 s 164.656 ms (16.1%)
Agent iast 1.145 s 124.694 ms (12.2%)
Agent profiling 1.152 s 131.29 ms (12.9%)
Total tracing 10.671 s -
Total appsec 11.017 s 345.825 ms (3.2%)
Total iast 10.981 s 309.201 ms (2.9%)
Total profiling 11.088 s 416.445 ms (3.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.015 s -
Agent appsec 1.191 s 176.232 ms (17.4%)
Agent iast 1.144 s 129.835 ms (12.8%)
Agent profiling 1.16 s 145.125 ms (14.3%)
Total tracing 10.64 s -
Total appsec 11.073 s 433.074 ms (4.1%)
Total iast 10.921 s 280.811 ms (2.6%)
Total profiling 11.067 s 426.861 ms (4.0%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~2768645057, baseline=1.54.0-SNAPSHOT~4cf767062c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (693.928 ms) : 0, 693928
BytebuddyAgent [candidate] (688.7 ms) : 0, 688700
GlobalTracer [baseline] (244.624 ms) : 0, 244624
GlobalTracer [candidate] (243.055 ms) : 0, 243055
AppSec [baseline] (31.534 ms) : 0, 31534
AppSec [candidate] (32.583 ms) : 0, 32583
Debugger [baseline] (6.409 ms) : 0, 6409
Debugger [candidate] (6.338 ms) : 0, 6338
Remote Config [baseline] (673.686 µs) : 0, 674
Remote Config [candidate] (672.172 µs) : 0, 672
Telemetry [baseline] (9.085 ms) : 0, 9085
Telemetry [candidate] (8.96 ms) : 0, 8960
Flare Poller [baseline] (11.432 ms) : 0, 11432
Flare Poller [candidate] (11.587 ms) : 0, 11587
section appsec
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (712.191 ms) : 0, 712191
BytebuddyAgent [candidate] (713.109 ms) : 0, 713109
GlobalTracer [baseline] (233.953 ms) : 0, 233953
GlobalTracer [candidate] (236.08 ms) : 0, 236080
AppSec [baseline] (170.94 ms) : 0, 170940
AppSec [candidate] (172.488 ms) : 0, 172488
Debugger [baseline] (6.804 ms) : 0, 6804
Debugger [candidate] (7.593 ms) : 0, 7593
Remote Config [baseline] (613.926 µs) : 0, 614
Remote Config [candidate] (631.36 µs) : 0, 631
Telemetry [baseline] (8.319 ms) : 0, 8319
Telemetry [candidate] (8.297 ms) : 0, 8297
Flare Poller [baseline] (4.924 ms) : 0, 4924
Flare Poller [candidate] (4.892 ms) : 0, 4892
IAST [baseline] (24.746 ms) : 0, 24746
IAST [candidate] (25.076 ms) : 0, 25076
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (810.162 ms) : 0, 810162
BytebuddyAgent [candidate] (808.931 ms) : 0, 808931
GlobalTracer [baseline] (232.859 ms) : 0, 232859
GlobalTracer [candidate] (232.638 ms) : 0, 232638
AppSec [baseline] (33.725 ms) : 0, 33725
AppSec [candidate] (34.768 ms) : 0, 34768
Debugger [baseline] (6.029 ms) : 0, 6029
Debugger [candidate] (6.069 ms) : 0, 6069
Remote Config [baseline] (593.053 µs) : 0, 593
Remote Config [candidate] (586.773 µs) : 0, 587
Telemetry [baseline] (8.194 ms) : 0, 8194
Telemetry [candidate] (8.269 ms) : 0, 8269
Flare Poller [baseline] (4.301 ms) : 0, 4301
Flare Poller [candidate] (4.219 ms) : 0, 4219
IAST [baseline] (26.4 ms) : 0, 26400
IAST [candidate] (26.107 ms) : 0, 26107
section profiling
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.413 ms) : 0, 1413
BytebuddyAgent [baseline] (718.46 ms) : 0, 718460
BytebuddyAgent [candidate] (719.441 ms) : 0, 719441
GlobalTracer [baseline] (219.095 ms) : 0, 219095
GlobalTracer [candidate] (218.551 ms) : 0, 218551
AppSec [baseline] (31.405 ms) : 0, 31405
AppSec [candidate] (32.846 ms) : 0, 32846
Debugger [baseline] (6.526 ms) : 0, 6526
Debugger [candidate] (7.276 ms) : 0, 7276
Remote Config [baseline] (731.558 µs) : 0, 732
Remote Config [candidate] (739.523 µs) : 0, 740
Telemetry [baseline] (16.567 ms) : 0, 16567
Telemetry [candidate] (15.556 ms) : 0, 15556
Flare Poller [baseline] (4.161 ms) : 0, 4161
Flare Poller [candidate] (4.171 ms) : 0, 4171
ProfilingAgent [baseline] (101.052 ms) : 0, 101052
ProfilingAgent [candidate] (104.094 ms) : 0, 104094
Profiling [baseline] (101.621 ms) : 0, 101621
Profiling [candidate] (107.83 ms) : 0, 107830
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/appsec-downstream-http
git_commit_date 1758889621 1758903342
git_commit_sha 4cf7670 2768645
release_version 1.54.0-SNAPSHOT~4cf767062c 1.54.0-SNAPSHOT~2768645057
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1758904783 1758904783
ci_job_id 1150306658 1150306658
ci_pipeline_id 77674826 77674826
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-9jvfzns9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-9jvfzns9 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:profiling:high_load worse
[+311.522µs; +603.537µs] or [+3.695%; +7.159%]		 unstable
[-99.492op/s; +43.617op/s] or [-18.088%; +7.930%]		 8.887ms 522.094op/s 8.430ms 550.031op/s
scenario:load:insecure-bank:iast:high_load better
[-688.194µs; -319.743µs] or [-6.617%; -3.074%]		 unstable
[-37.672op/s; +82.672op/s] or [-8.429%; +18.499%]		 9.896ms 469.406op/s 10.400ms 446.906op/s
scenario:load:petclinic:code_origins:high_load worse
[+3.935ms; +4.747ms] or [+9.354%; +11.285%]		 unstable
[-17.392op/s; -3.333op/s] or [-15.639%; -2.997%]		 46.407ms 100.850op/s 42.066ms 111.213op/s
scenario:load:petclinic:tracing:high_load better
[-2.482ms; -1.679ms] or [-5.510%; -3.727%]		 unstable
[-2.211op/s; +12.236op/s] or [-2.128%; +11.779%]		 42.968ms 108.888op/s 45.049ms 103.875op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~2768645057, baseline=1.54.0-SNAPSHOT~4cf767062c
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.496 ms) : 4446, 4546
.   : milestone, 4496,
iast (10.4 ms) : 10223, 10577
.   : milestone, 10400,
iast_FULL (13.883 ms) : 13609, 14157
.   : milestone, 13883,
iast_GLOBAL (10.575 ms) : 10384, 10766
.   : milestone, 10575,
profiling (8.43 ms) : 8301, 8559
.   : milestone, 8430,
tracing (7.615 ms) : 7506, 7724
.   : milestone, 7615,
section candidate
no_agent (4.379 ms) : 4329, 4429
.   : milestone, 4379,
iast (9.896 ms) : 9730, 10062
.   : milestone, 9896,
iast_FULL (13.971 ms) : 13692, 14251
.   : milestone, 13971,
iast_GLOBAL (10.814 ms) : 10623, 11005
.   : milestone, 10814,
profiling (8.887 ms) : 8745, 9030
.   : milestone, 8887,
tracing (7.809 ms) : 7698, 7920
.   : milestone, 7809,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.496 ms [4.446 ms, 4.546 ms] -
iast 10.4 ms [10.223 ms, 10.577 ms] 5.904 ms (131.3%)
iast_FULL 13.883 ms [13.609 ms, 14.157 ms] 9.387 ms (208.8%)
iast_GLOBAL 10.575 ms [10.384 ms, 10.766 ms] 6.079 ms (135.2%)
profiling 8.43 ms [8.301 ms, 8.559 ms] 3.934 ms (87.5%)
tracing 7.615 ms [7.506 ms, 7.724 ms] 3.119 ms (69.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.379 ms [4.329 ms, 4.429 ms] -
iast 9.896 ms [9.73 ms, 10.062 ms] 5.517 ms (126.0%)
iast_FULL 13.971 ms [13.692 ms, 14.251 ms] 9.592 ms (219.0%)
iast_GLOBAL 10.814 ms [10.623 ms, 11.005 ms] 6.435 ms (146.9%)
profiling 8.887 ms [8.745 ms, 9.03 ms] 4.508 ms (103.0%)
tracing 7.809 ms [7.698 ms, 7.92 ms] 3.43 ms (78.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~2768645057, baseline=1.54.0-SNAPSHOT~4cf767062c
    dateFormat X
    axisFormat %s
section baseline
no_agent (38.119 ms) : 37804, 38433
.   : milestone, 38119,
appsec (47.173 ms) : 46749, 47596
.   : milestone, 47173,
code_origins (42.066 ms) : 41707, 42426
.   : milestone, 42066,
iast (44.442 ms) : 44057, 44828
.   : milestone, 44442,
profiling (48.983 ms) : 48530, 49437
.   : milestone, 48983,
tracing (45.049 ms) : 44661, 45436
.   : milestone, 45049,
section candidate
no_agent (37.119 ms) : 36820, 37418
.   : milestone, 37119,
appsec (48.039 ms) : 47618, 48460
.   : milestone, 48039,
code_origins (46.407 ms) : 46013, 46802
.   : milestone, 46407,
iast (45.591 ms) : 45204, 45978
.   : milestone, 45591,
profiling (47.951 ms) : 47538, 48364
.   : milestone, 47951,
tracing (42.968 ms) : 42610, 43326
.   : milestone, 42968,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 38.119 ms [37.804 ms, 38.433 ms] -
appsec 47.173 ms [46.749 ms, 47.596 ms] 9.054 ms (23.8%)
code_origins 42.066 ms [41.707 ms, 42.426 ms] 3.948 ms (10.4%)
iast 44.442 ms [44.057 ms, 44.828 ms] 6.324 ms (16.6%)
profiling 48.983 ms [48.53 ms, 49.437 ms] 10.864 ms (28.5%)
tracing 45.049 ms [44.661 ms, 45.436 ms] 6.93 ms (18.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.119 ms [36.82 ms, 37.418 ms] -
appsec 48.039 ms [47.618 ms, 48.46 ms] 10.92 ms (29.4%)
code_origins 46.407 ms [46.013 ms, 46.802 ms] 9.289 ms (25.0%)
iast 45.591 ms [45.204 ms, 45.978 ms] 8.472 ms (22.8%)
profiling 47.951 ms [47.538 ms, 48.364 ms] 10.832 ms (29.2%)
tracing 42.968 ms [42.61 ms, 43.326 ms] 5.849 ms (15.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/appsec-downstream-http
git_commit_date 1758889621 1758903342
git_commit_sha 4cf7670 2768645
release_version 1.54.0-SNAPSHOT~4cf767062c 1.54.0-SNAPSHOT~2768645057
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1758905447 1758905447
ci_job_id 1150306659 1150306659
ci_pipeline_id 77674826 77674826
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-twpvn2v1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-twpvn2v1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~2768645057, baseline=1.54.0-SNAPSHOT~4cf767062c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1489
.   : milestone, 1477,
appsec (3.725 ms) : 3506, 3944
.   : milestone, 3725,
iast (2.209 ms) : 2146, 2272
.   : milestone, 2209,
iast_GLOBAL (2.256 ms) : 2194, 2319
.   : milestone, 2256,
profiling (2.066 ms) : 2014, 2118
.   : milestone, 2066,
tracing (2.021 ms) : 1973, 2070
.   : milestone, 2021,
section candidate
no_agent (1.482 ms) : 1471, 1494
.   : milestone, 1482,
appsec (3.737 ms) : 3520, 3954
.   : milestone, 3737,
iast (2.21 ms) : 2147, 2273
.   : milestone, 2210,
iast_GLOBAL (2.253 ms) : 2190, 2316
.   : milestone, 2253,
profiling (2.071 ms) : 2019, 2123
.   : milestone, 2071,
tracing (2.033 ms) : 1984, 2082
.   : milestone, 2033,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.465 ms, 1.489 ms] -
appsec 3.725 ms [3.506 ms, 3.944 ms] 2.248 ms (152.2%)
iast 2.209 ms [2.146 ms, 2.272 ms] 731.947 µs (49.6%)
iast_GLOBAL 2.256 ms [2.194 ms, 2.319 ms] 779.402 µs (52.8%)
profiling 2.066 ms [2.014 ms, 2.118 ms] 589.053 µs (39.9%)
tracing 2.021 ms [1.973 ms, 2.07 ms] 544.249 µs (36.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.471 ms, 1.494 ms] -
appsec 3.737 ms [3.52 ms, 3.954 ms] 2.255 ms (152.1%)
iast 2.21 ms [2.147 ms, 2.273 ms] 727.56 µs (49.1%)
iast_GLOBAL 2.253 ms [2.19 ms, 2.316 ms] 770.501 µs (52.0%)
profiling 2.071 ms [2.019 ms, 2.123 ms] 589.143 µs (39.7%)
tracing 2.033 ms [1.984 ms, 2.082 ms] 550.585 µs (37.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~2768645057, baseline=1.54.0-SNAPSHOT~4cf767062c
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.992 s) : 14992000, 14992000
.   : milestone, 14992000,
appsec (15.192 s) : 15192000, 15192000
.   : milestone, 15192000,
iast (18.652 s) : 18652000, 18652000
.   : milestone, 18652000,
iast_GLOBAL (18.16 s) : 18160000, 18160000
.   : milestone, 18160000,
profiling (15.428 s) : 15428000, 15428000
.   : milestone, 15428000,
tracing (15.083 s) : 15083000, 15083000
.   : milestone, 15083000,
section candidate
no_agent (15.404 s) : 15404000, 15404000
.   : milestone, 15404000,
appsec (15.029 s) : 15029000, 15029000
.   : milestone, 15029000,
iast (18.599 s) : 18599000, 18599000
.   : milestone, 18599000,
iast_GLOBAL (18.035 s) : 18035000, 18035000
.   : milestone, 18035000,
profiling (15.414 s) : 15414000, 15414000
.   : milestone, 15414000,
tracing (15.131 s) : 15131000, 15131000
.   : milestone, 15131000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.992 s [14.992 s, 14.992 s] -
appsec 15.192 s [15.192 s, 15.192 s] 200.0 ms (1.3%)
iast 18.652 s [18.652 s, 18.652 s] 3.66 s (24.4%)
iast_GLOBAL 18.16 s [18.16 s, 18.16 s] 3.168 s (21.1%)
profiling 15.428 s [15.428 s, 15.428 s] 436.0 ms (2.9%)
tracing 15.083 s [15.083 s, 15.083 s] 91.0 ms (0.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.404 s [15.404 s, 15.404 s] -
appsec 15.029 s [15.029 s, 15.029 s] -375.0 ms (-2.4%)
iast 18.599 s [18.599 s, 18.599 s] 3.195 s (20.7%)
iast_GLOBAL 18.035 s [18.035 s, 18.035 s] 2.631 s (17.1%)
profiling 15.414 s [15.414 s, 15.414 s] 10.0 ms (0.1%)
tracing 15.131 s [15.131 s, 15.131 s] -273.0 ms (-1.8%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/appsec-downstream-http branch from e10c32e to 094375b Compare September 19, 2025 15:39
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review September 19, 2025 15:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/appsec-downstream-http branch 2 times, most recently from fe39167 to 1dae6dc Compare September 19, 2025 15:59
@manuel-alvarez-alvarez manuel-alvarez-alvarez added the type: enhancement Enhancements and improvements label Sep 22, 2025
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/appsec-downstream-http branch 2 times, most recently from 86ba6d2 to 4ce366c Compare September 22, 2025 14:58
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Sep 22, 2025 •
edited by datadog-official bot
Loading

🎯 Code Coverage
• Patch Coverage: 79.70%
• Total Coverage: 57.90% (-0.04%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2768645 | Docs | Was this helpful? Give us feedback!

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/appsec-downstream-http branch 2 times, most recently from f331f45 to 88a00bf Compare September 24, 2025 09:40
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/appsec-downstream-http branch 2 times, most recently from 38bcd80 to d2992f6 Compare September 24, 2025 19:32
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/appsec-downstream-http branch from d2992f6 to 4c2a589 Compare September 26, 2025 09:46
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/appsec-downstream-http branch from 4c2a589 to 2768645 Compare September 26, 2025 16:16
@jandro996
Copy link
Member

🎯 Code Coverage• Patch Coverage: 79.70%• Total Coverage: 57.90% (-0.04%) View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2768645 | Docs | Was this helpful? Give us feedback!

I’m wondering if we could add a couple more tests to bring the patch coverage up to 100%.
Not sure if the bot is being imprecise, or if we’ve missed a small part of the code that isn’t covered yet cause right now is not available

jandro996
jandro996 approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@jandro996 jandro996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking this on!
I think it would be a good idea to expand the PR description a bit :) even after reading the RFC, there are some changes that could be useful to highlight for reviewers.

@manuel-alvarez-alvarez
Copy link
Member Author

🎯 Code Coverage• Patch Coverage: 79.70%• Total Coverage: 57.90% (-0.04%) View detailed report
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2768645 | Docs | Was this helpful? Give us feedback!

I’m wondering if we could add a couple more tests to bring the patch coverage up to 100%. Not sure if the bot is being imprecise, or if we’ve missed a small part of the code that isn’t covered yet cause right now is not available

Yeah seems that the bot is not updated with the latest changes, but coverage should have improved.

@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 6c26663 into master Oct 1, 2025
541 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/appsec-downstream-http branch October 1, 2025 16:14
@github-actions github-actions bot added this to the 1.54.0 milestone Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandro996 jandro996 jandro996 approved these changes

@sezen-datadog sezen-datadog sezen-datadog approved these changes

@robertpi robertpi Awaiting requested review from robertpi robertpi is a code owner automatically assigned from DataDog/asm-java

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) inst: others All other instrumentations type: enhancement Enhancements and improvements
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
3 participants
@manuel-alvarez-alvarez @jandro996 @sezen-datadog