-
Notifications
You must be signed in to change notification settings - Fork 312
Add CompletableFuture in WellKnownClasses #9622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
to be able to access result field in CompletableFuture JDK class we are adding a special access. The method resultNow() is the only method available to access result without side effects. It is available since JDK19.
🎯 Code Coverage 🔗 Commit SHA: 0672939 | Docs | Was this helpful? Give us feedback! |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (330.199 µs) : 274, 387
. : milestone, 330,
basic (276.683 µs) : 271, 283
. : milestone, 277,
loop (8.971 ms) : 8950, 8992
. : milestone, 8971,
section candidate
noprobe (313.138 µs) : 286, 340
. : milestone, 313,
basic (275.197 µs) : 269, 281
. : milestone, 275,
loop (8.958 ms) : 8953, 8962
. : milestone, 8958,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~06729391ae, baseline=1.54.0-SNAPSHOT~8f47b665c4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1022550
Total [baseline] (8.712 s) : 0, 8712076
Agent [candidate] (1.01 s) : 0, 1010208
Total [candidate] (8.671 s) : 0, 8670760
section iast
Agent [baseline] (1.146 s) : 0, 1146270
Total [baseline] (9.271 s) : 0, 9270645
Agent [candidate] (1.146 s) : 0, 1146038
Total [candidate] (9.234 s) : 0, 9234177
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~06729391ae, baseline=1.54.0-SNAPSHOT~8f47b665c4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.501 ms) : 0, 1501
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (695.927 ms) : 0, 695927
BytebuddyAgent [candidate] (691.987 ms) : 0, 691987
GlobalTracer [baseline] (245.242 ms) : 0, 245242
GlobalTracer [candidate] (248.426 ms) : 0, 248426
AppSec [baseline] (31.655 ms) : 0, 31655
AppSec [candidate] (31.15 ms) : 0, 31150
Debugger [baseline] (6.39 ms) : 0, 6390
Debugger [candidate] (6.389 ms) : 0, 6389
Remote Config [baseline] (688.025 µs) : 0, 688
Remote Config [candidate] (690.701 µs) : 0, 691
Telemetry [baseline] (9.125 ms) : 0, 9125
Telemetry [candidate] (8.949 ms) : 0, 8949
Flare Poller [baseline] (10.633 ms) : 0, 10633
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (810.215 ms) : 0, 810215
BytebuddyAgent [candidate] (811.32 ms) : 0, 811320
GlobalTracer [baseline] (233.247 ms) : 0, 233247
GlobalTracer [candidate] (237.113 ms) : 0, 237113
IAST [baseline] (26.501 ms) : 0, 26501
IAST [candidate] (27.032 ms) : 0, 27032
AppSec [baseline] (34.314 ms) : 0, 34314
AppSec [candidate] (32.812 ms) : 0, 32812
Debugger [baseline] (6.074 ms) : 0, 6074
Debugger [candidate] (6.055 ms) : 0, 6055
Remote Config [baseline] (599.088 µs) : 0, 599
Remote Config [candidate] (592.799 µs) : 0, 593
Telemetry [baseline] (8.188 ms) : 0, 8188
Telemetry [candidate] (8.293 ms) : 0, 8293
Flare Poller [baseline] (4.213 ms) : 0, 4213
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~06729391ae, baseline=1.54.0-SNAPSHOT~8f47b665c4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1013725
Total [baseline] (10.678 s) : 0, 10678458
Agent [candidate] (1.008 s) : 0, 1007900
Total [candidate] (10.691 s) : 0, 10690545
section appsec
Agent [baseline] (1.189 s) : 0, 1189171
Total [baseline] (11.083 s) : 0, 11082518
Agent [candidate] (1.192 s) : 0, 1191788
Total [candidate] (11.064 s) : 0, 11063596
section iast
Agent [baseline] (1.147 s) : 0, 1146636
Total [baseline] (10.934 s) : 0, 10934273
Agent [candidate] (1.154 s) : 0, 1154063
Total [candidate] (10.905 s) : 0, 10905173
section profiling
Agent [baseline] (1.159 s) : 0, 1159409
Total [baseline] (11.16 s) : 0, 11159926
Agent [candidate] (1.16 s) : 0, 1160254
Total [candidate] (11.175 s) : 0, 11174810
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~06729391ae, baseline=1.54.0-SNAPSHOT~8f47b665c4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (690.116 ms) : 0, 690116
BytebuddyAgent [candidate] (689.777 ms) : 0, 689777
GlobalTracer [baseline] (243.371 ms) : 0, 243371
GlobalTracer [candidate] (248.257 ms) : 0, 248257
AppSec [baseline] (31.373 ms) : 0, 31373
AppSec [candidate] (31.102 ms) : 0, 31102
Debugger [baseline] (6.329 ms) : 0, 6329
Debugger [candidate] (6.38 ms) : 0, 6380
Remote Config [baseline] (681.406 µs) : 0, 681
Remote Config [candidate] (674.467 µs) : 0, 674
Telemetry [baseline] (8.904 ms) : 0, 8904
Telemetry [candidate] (9.024 ms) : 0, 9024
Flare Poller [baseline] (10.223 ms) : 0, 10223
section appsec
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (713.064 ms) : 0, 713064
BytebuddyAgent [candidate] (715.06 ms) : 0, 715060
GlobalTracer [baseline] (235.571 ms) : 0, 235571
GlobalTracer [candidate] (240.468 ms) : 0, 240468
IAST [baseline] (24.786 ms) : 0, 24786
IAST [candidate] (24.831 ms) : 0, 24831
AppSec [baseline] (173.153 ms) : 0, 173153
AppSec [candidate] (172.972 ms) : 0, 172972
Debugger [baseline] (6.081 ms) : 0, 6081
Debugger [candidate] (5.994 ms) : 0, 5994
Remote Config [baseline] (663.268 µs) : 0, 663
Remote Config [candidate] (633.158 µs) : 0, 633
Telemetry [baseline] (8.361 ms) : 0, 8361
Telemetry [candidate] (9.179 ms) : 0, 9179
Flare Poller [baseline] (4.813 ms) : 0, 4813
section iast
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (810.793 ms) : 0, 810793
BytebuddyAgent [candidate] (816.286 ms) : 0, 816286
GlobalTracer [baseline] (233.157 ms) : 0, 233157
GlobalTracer [candidate] (239.585 ms) : 0, 239585
IAST [baseline] (26.268 ms) : 0, 26268
IAST [candidate] (26.218 ms) : 0, 26218
AppSec [baseline] (34.496 ms) : 0, 34496
AppSec [candidate] (33.919 ms) : 0, 33919
Debugger [baseline] (6.096 ms) : 0, 6096
Debugger [candidate] (6.078 ms) : 0, 6078
Remote Config [baseline] (584.202 µs) : 0, 584
Remote Config [candidate] (600.748 µs) : 0, 601
Telemetry [baseline] (8.082 ms) : 0, 8082
Telemetry [candidate] (8.445 ms) : 0, 8445
Flare Poller [baseline] (4.288 ms) : 0, 4288
section profiling
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (724.303 ms) : 0, 724303
BytebuddyAgent [candidate] (724.818 ms) : 0, 724818
GlobalTracer [baseline] (219.776 ms) : 0, 219776
GlobalTracer [candidate] (224.638 ms) : 0, 224638
AppSec [baseline] (31.555 ms) : 0, 31555
AppSec [candidate] (31.314 ms) : 0, 31314
Debugger [baseline] (7.301 ms) : 0, 7301
Debugger [candidate] (7.268 ms) : 0, 7268
Remote Config [baseline] (740.964 µs) : 0, 741
Remote Config [candidate] (708.02 µs) : 0, 708
Telemetry [baseline] (15.457 ms) : 0, 15457
Telemetry [candidate] (15.641 ms) : 0, 15641
Flare Poller [baseline] (4.258 ms) : 0, 4258
ProfilingAgent [baseline] (101.658 ms) : 0, 101658
ProfilingAgent [candidate] (101.037 ms) : 0, 101037
Profiling [baseline] (102.243 ms) : 0, 102243
Profiling [candidate] (102.277 ms) : 0, 102277
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~06729391ae, baseline=1.54.0-SNAPSHOT~8f47b665c4
dateFormat X
axisFormat %s
section baseline
no_agent (37.015 ms) : 36720, 37311
. : milestone, 37015,
appsec (48.461 ms) : 48008, 48913
. : milestone, 48461,
code_origins (44.555 ms) : 44173, 44937
. : milestone, 44555,
iast (45.871 ms) : 45482, 46260
. : milestone, 45871,
profiling (48.749 ms) : 48289, 49209
. : milestone, 48749,
tracing (45.793 ms) : 45390, 46196
. : milestone, 45793,
section candidate
no_agent (35.157 ms) : 34881, 35433
. : milestone, 35157,
appsec (48.038 ms) : 47589, 48487
. : milestone, 48038,
code_origins (44.06 ms) : 43686, 44434
. : milestone, 44060,
iast (44.667 ms) : 44285, 45049
. : milestone, 44667,
profiling (48.293 ms) : 47868, 48719
. : milestone, 48293,
tracing (45.282 ms) : 44896, 45668
. : milestone, 45282,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~06729391ae, baseline=1.54.0-SNAPSHOT~8f47b665c4
dateFormat X
axisFormat %s
section baseline
no_agent (4.323 ms) : 4271, 4375
. : milestone, 4323,
iast (10.293 ms) : 10119, 10468
. : milestone, 10293,
iast_FULL (14.153 ms) : 13873, 14433
. : milestone, 14153,
iast_GLOBAL (10.935 ms) : 10738, 11132
. : milestone, 10935,
profiling (9.275 ms) : 9129, 9422
. : milestone, 9275,
tracing (7.924 ms) : 7803, 8045
. : milestone, 7924,
section candidate
no_agent (4.331 ms) : 4282, 4379
. : milestone, 4331,
iast (9.459 ms) : 9302, 9616
. : milestone, 9459,
iast_FULL (14.22 ms) : 13936, 14505
. : milestone, 14220,
iast_GLOBAL (10.875 ms) : 10678, 11072
. : milestone, 10875,
profiling (8.935 ms) : 8797, 9074
. : milestone, 8935,
tracing (7.571 ms) : 7465, 7678
. : milestone, 7571,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~06729391ae, baseline=1.54.0-SNAPSHOT~8f47b665c4
dateFormat X
axisFormat %s
section baseline
no_agent (15.642 s) : 15642000, 15642000
. : milestone, 15642000,
appsec (15.035 s) : 15035000, 15035000
. : milestone, 15035000,
iast (18.452 s) : 18452000, 18452000
. : milestone, 18452000,
iast_GLOBAL (18.058 s) : 18058000, 18058000
. : milestone, 18058000,
profiling (15.548 s) : 15548000, 15548000
. : milestone, 15548000,
tracing (15.101 s) : 15101000, 15101000
. : milestone, 15101000,
section candidate
no_agent (15.262 s) : 15262000, 15262000
. : milestone, 15262000,
appsec (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
iast (19.058 s) : 19058000, 19058000
. : milestone, 19058000,
iast_GLOBAL (17.976 s) : 17976000, 17976000
. : milestone, 17976000,
profiling (15.485 s) : 15485000, 15485000
. : milestone, 15485000,
tracing (15.397 s) : 15397000, 15397000
. : milestone, 15397000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~06729391ae, baseline=1.54.0-SNAPSHOT~8f47b665c4
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.711 ms) : 3493, 3929
. : milestone, 3711,
iast (2.193 ms) : 2130, 2256
. : milestone, 2193,
iast_GLOBAL (2.243 ms) : 2179, 2306
. : milestone, 2243,
profiling (2.056 ms) : 2005, 2108
. : milestone, 2056,
tracing (2.036 ms) : 1986, 2085
. : milestone, 2036,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.718 ms) : 3500, 3936
. : milestone, 3718,
iast (2.192 ms) : 2129, 2254
. : milestone, 2192,
iast_GLOBAL (2.237 ms) : 2174, 2301
. : milestone, 2237,
profiling (2.078 ms) : 2025, 2131
. : milestone, 2078,
tracing (2.02 ms) : 1971, 2069
. : milestone, 2020,
|
What Does This Do
to be able to access result field in CompletableFuture JDK class we are adding a special access. The method resultNow() is the only method available to access result without side effects. It is available since JDK19.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-4532