-
Notifications
You must be signed in to change notification settings - Fork 312
Opt-out API Security endpoint discovery #9623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
🎯 Code Coverage 🔗 Commit SHA: 2a14d7a | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~2a14d7afa1, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.012 s) : 0, 1012483
Total [baseline] (10.772 s) : 0, 10772234
Agent [candidate] (1.014 s) : 0, 1014354
Total [candidate] (10.679 s) : 0, 10679035
section appsec
Agent [baseline] (1.197 s) : 0, 1197008
Total [baseline] (11.096 s) : 0, 11096190
Agent [candidate] (1.192 s) : 0, 1191611
Total [candidate] (10.971 s) : 0, 10971192
section iast
Agent [baseline] (1.157 s) : 0, 1156572
Total [baseline] (10.954 s) : 0, 10954016
Agent [candidate] (1.15 s) : 0, 1149711
Total [candidate] (10.912 s) : 0, 10912130
section profiling
Agent [baseline] (1.161 s) : 0, 1160530
Total [baseline] (11.163 s) : 0, 11162750
Agent [candidate] (1.153 s) : 0, 1152725
Total [candidate] (11.07 s) : 0, 11070054
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~2a14d7afa1, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.49 ms) : 0, 1490
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (688.562 ms) : 0, 688562
BytebuddyAgent [candidate] (689.068 ms) : 0, 689068
GlobalTracer [baseline] (243.091 ms) : 0, 243091
GlobalTracer [candidate] (243.561 ms) : 0, 243561
AppSec [baseline] (31.287 ms) : 0, 31287
AppSec [candidate] (31.199 ms) : 0, 31199
Debugger [baseline] (6.326 ms) : 0, 6326
Debugger [candidate] (6.287 ms) : 0, 6287
Remote Config [baseline] (685.448 µs) : 0, 685
Remote Config [candidate] (679.718 µs) : 0, 680
Telemetry [baseline] (8.863 ms) : 0, 8863
Telemetry [candidate] (9.339 ms) : 0, 9339
Flare Poller [baseline] (10.956 ms) : 0, 10956
Flare Poller [candidate] (11.495 ms) : 0, 11495
section appsec
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (718.97 ms) : 0, 718970
BytebuddyAgent [candidate] (714.762 ms) : 0, 714762
GlobalTracer [baseline] (236.924 ms) : 0, 236924
GlobalTracer [candidate] (236.571 ms) : 0, 236571
AppSec [baseline] (172.554 ms) : 0, 172554
AppSec [candidate] (172.574 ms) : 0, 172574
Debugger [baseline] (6.099 ms) : 0, 6099
Debugger [candidate] (6.048 ms) : 0, 6048
Remote Config [baseline] (643.813 µs) : 0, 644
Remote Config [candidate] (625.837 µs) : 0, 626
Telemetry [baseline] (8.429 ms) : 0, 8429
Telemetry [candidate] (8.64 ms) : 0, 8640
Flare Poller [baseline] (5.598 ms) : 0, 5598
Flare Poller [candidate] (4.796 ms) : 0, 4796
IAST [baseline] (25.059 ms) : 0, 25059
IAST [candidate] (24.907 ms) : 0, 24907
section iast
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (818.476 ms) : 0, 818476
BytebuddyAgent [candidate] (813.375 ms) : 0, 813375
GlobalTracer [baseline] (235.413 ms) : 0, 235413
GlobalTracer [candidate] (234.029 ms) : 0, 234029
AppSec [baseline] (34.093 ms) : 0, 34093
AppSec [candidate] (33.789 ms) : 0, 33789
Debugger [baseline] (6.021 ms) : 0, 6021
Debugger [candidate] (6.078 ms) : 0, 6078
Remote Config [baseline] (592.539 µs) : 0, 593
Remote Config [candidate] (585.192 µs) : 0, 585
Telemetry [baseline] (8.1 ms) : 0, 8100
Telemetry [candidate] (8.561 ms) : 0, 8561
Flare Poller [baseline] (4.217 ms) : 0, 4217
Flare Poller [candidate] (4.219 ms) : 0, 4219
IAST [baseline] (26.621 ms) : 0, 26621
IAST [candidate] (26.233 ms) : 0, 26233
section profiling
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (723.97 ms) : 0, 723970
BytebuddyAgent [candidate] (719.689 ms) : 0, 719689
GlobalTracer [baseline] (220.021 ms) : 0, 220021
GlobalTracer [candidate] (219.069 ms) : 0, 219069
AppSec [baseline] (31.559 ms) : 0, 31559
AppSec [candidate] (31.342 ms) : 0, 31342
Debugger [baseline] (6.603 ms) : 0, 6603
Debugger [candidate] (6.514 ms) : 0, 6514
Remote Config [baseline] (742.121 µs) : 0, 742
Remote Config [candidate] (725.185 µs) : 0, 725
Telemetry [baseline] (16.609 ms) : 0, 16609
Telemetry [candidate] (16.483 ms) : 0, 16483
Flare Poller [baseline] (4.239 ms) : 0, 4239
Flare Poller [candidate] (4.131 ms) : 0, 4131
ProfilingAgent [baseline] (102.534 ms) : 0, 102534
ProfilingAgent [candidate] (100.828 ms) : 0, 100828
Profiling [baseline] (103.116 ms) : 0, 103116
Profiling [candidate] (101.407 ms) : 0, 101407
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~2a14d7afa1, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.015 s) : 0, 1014744
Total [baseline] (8.726 s) : 0, 8726138
Agent [candidate] (1.016 s) : 0, 1015608
Total [candidate] (8.691 s) : 0, 8691157
section iast
Agent [baseline] (1.161 s) : 0, 1161183
Total [baseline] (9.319 s) : 0, 9318538
Agent [candidate] (1.143 s) : 0, 1143125
Total [candidate] (9.288 s) : 0, 9288198
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~2a14d7afa1, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (691.327 ms) : 0, 691327
BytebuddyAgent [candidate] (689.918 ms) : 0, 689918
GlobalTracer [baseline] (243.228 ms) : 0, 243228
GlobalTracer [candidate] (243.827 ms) : 0, 243827
AppSec [baseline] (31.157 ms) : 0, 31157
AppSec [candidate] (31.31 ms) : 0, 31310
Debugger [baseline] (6.336 ms) : 0, 6336
Debugger [candidate] (6.347 ms) : 0, 6347
Remote Config [baseline] (677.404 µs) : 0, 677
Remote Config [candidate] (673.115 µs) : 0, 673
Telemetry [baseline] (8.994 ms) : 0, 8994
Telemetry [candidate] (9.358 ms) : 0, 9358
Flare Poller [baseline] (10.311 ms) : 0, 10311
Flare Poller [candidate] (11.48 ms) : 0, 11480
section iast
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (821.902 ms) : 0, 821902
BytebuddyAgent [candidate] (809.091 ms) : 0, 809091
GlobalTracer [baseline] (235.677 ms) : 0, 235677
GlobalTracer [candidate] (232.167 ms) : 0, 232167
AppSec [baseline] (34.241 ms) : 0, 34241
AppSec [candidate] (34.179 ms) : 0, 34179
Debugger [baseline] (6.1 ms) : 0, 6100
Debugger [candidate] (6.033 ms) : 0, 6033
Remote Config [baseline] (604.636 µs) : 0, 605
Remote Config [candidate] (577.418 µs) : 0, 577
Telemetry [baseline] (8.394 ms) : 0, 8394
Telemetry [candidate] (8.39 ms) : 0, 8390
Flare Poller [baseline] (4.295 ms) : 0, 4295
Flare Poller [candidate] (4.13 ms) : 0, 4130
IAST [baseline] (26.882 ms) : 0, 26882
IAST [candidate] (25.912 ms) : 0, 25912
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 2 performance regressions! Performance is the same for 5 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~2a14d7afa1, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section baseline
no_agent (4.297 ms) : 4248, 4345
. : milestone, 4297,
iast (9.573 ms) : 9404, 9743
. : milestone, 9573,
iast_FULL (13.791 ms) : 13511, 14071
. : milestone, 13791,
iast_GLOBAL (11.469 ms) : 11256, 11682
. : milestone, 11469,
profiling (8.875 ms) : 8734, 9016
. : milestone, 8875,
tracing (7.699 ms) : 7590, 7807
. : milestone, 7699,
section candidate
no_agent (4.383 ms) : 4334, 4433
. : milestone, 4383,
iast (10.389 ms) : 10208, 10569
. : milestone, 10389,
iast_FULL (14.248 ms) : 13963, 14532
. : milestone, 14248,
iast_GLOBAL (10.7 ms) : 10512, 10889
. : milestone, 10700,
profiling (8.497 ms) : 8356, 8639
. : milestone, 8497,
tracing (7.744 ms) : 7632, 7856
. : milestone, 7744,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~2a14d7afa1, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section baseline
no_agent (37.363 ms) : 37056, 37669
. : milestone, 37363,
appsec (48.694 ms) : 48257, 49132
. : milestone, 48694,
code_origins (42.806 ms) : 42453, 43159
. : milestone, 42806,
iast (45.123 ms) : 44717, 45529
. : milestone, 45123,
profiling (49.678 ms) : 49170, 50185
. : milestone, 49678,
tracing (43.842 ms) : 43463, 44221
. : milestone, 43842,
section candidate
no_agent (35.88 ms) : 35596, 36164
. : milestone, 35880,
appsec (49.12 ms) : 48674, 49566
. : milestone, 49120,
code_origins (44.659 ms) : 44276, 45042
. : milestone, 44659,
iast (43.497 ms) : 43140, 43854
. : milestone, 43497,
profiling (48.142 ms) : 47718, 48565
. : milestone, 48142,
tracing (43.091 ms) : 42741, 43442
. : milestone, 43091,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~2a14d7afa1, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1482
. : milestone, 1471,
appsec (3.727 ms) : 3510, 3943
. : milestone, 3727,
iast (2.194 ms) : 2132, 2257
. : milestone, 2194,
iast_GLOBAL (2.231 ms) : 2168, 2294
. : milestone, 2231,
profiling (2.038 ms) : 1988, 2089
. : milestone, 2038,
tracing (2.005 ms) : 1957, 2054
. : milestone, 2005,
section candidate
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (2.448 ms) : 2398, 2499
. : milestone, 2448,
iast (2.2 ms) : 2136, 2263
. : milestone, 2200,
iast_GLOBAL (2.237 ms) : 2174, 2300
. : milestone, 2237,
profiling (2.057 ms) : 2005, 2109
. : milestone, 2057,
tracing (2.006 ms) : 1958, 2055
. : milestone, 2006,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~2a14d7afa1, baseline=1.54.0-SNAPSHOT~4cf767062c
dateFormat X
axisFormat %s
section baseline
no_agent (14.893 s) : 14893000, 14893000
. : milestone, 14893000,
appsec (14.956 s) : 14956000, 14956000
. : milestone, 14956000,
iast (18.568 s) : 18568000, 18568000
. : milestone, 18568000,
iast_GLOBAL (17.702 s) : 17702000, 17702000
. : milestone, 17702000,
profiling (16.032 s) : 16032000, 16032000
. : milestone, 16032000,
tracing (15.208 s) : 15208000, 15208000
. : milestone, 15208000,
section candidate
no_agent (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
appsec (15.082 s) : 15082000, 15082000
. : milestone, 15082000,
iast (18.424 s) : 18424000, 18424000
. : milestone, 18424000,
iast_GLOBAL (17.679 s) : 17679000, 17679000
. : milestone, 17679000,
profiling (15.928 s) : 15928000, 15928000
. : milestone, 15928000,
tracing (15.117 s) : 15117000, 15117000
. : milestone, 15117000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We were keeping this feature disabled for now because the backend does not support it yet. However, we’re actively working on adding support, and in the meantime, we need to measure the volume of data we’d need to handle once the feature is enabled.
As a result, this PR sets the default config flag to true:
ConfigDefaults.java#L120
Enabling the feature by default surfaced an issue during test execution:
an exception was thrown due to multiple beans of type RequestMappingHandlerMapping being present in the Spring context, which caused a NoUniqueBeanDefinitionException.
Error:
To resolve this, the instrumentations were updated to:
This avoids the error and ensures compatibility with Spring setups that register multiple handler mappings.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]