Skip to content

Implementation of http client request analysis for OkHttp3 #9654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2025
Merged

Implementation of http client request analysis for OkHttp3 #9654

merged 1 commit into from
Oct 6, 2025

Conversation

manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Oct 2, 2025 •
edited by atlassian bot
Loading

What Does This Do

Adds support for downstream HTTP request and response analysis in the OkHttp3 client instrumentation.

Motivation

Enable AppSec to analyze outbound requests made through OkHttp3. This expands coverage for API security and SSRF protections, while supporting downstream traffic inspection with configurable sampling.

Additional Notes

RFC

Contributor Checklist

Jira ticket: APPSEC-58613

@manuel-alvarez-alvarez manuel-alvarez-alvarez added type: enhancement Enhancements and improvements inst: others All other instrumentations comp: asm waf Application Security Management (WAF) labels Oct 2, 2025
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review October 2, 2025 12:30
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested review from a team as code owners October 2, 2025 12:30
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Oct 2, 2025 •
edited by datadog-official bot
Loading

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 68.73% (+10.62%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 95b71ca | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 2, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/appsec-downstream-okhttp3
git_commit_date 1759657538 1759735365
git_commit_sha 02cae20 95b71ca
release_version 1.54.0-SNAPSHOT~02cae20a94 1.54.0-SNAPSHOT~95b71ca9ca
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1759737206 1759737206
ci_job_id 1163951414 1163951414
ci_pipeline_id 78434438 78434438
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-o36o27qh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-o36o27qh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~95b71ca9ca, baseline=1.54.0-SNAPSHOT~02cae20a94

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1023945
Total [baseline] (8.649 s) : 0, 8649339
Agent [candidate] (1.018 s) : 0, 1018396
Total [candidate] (8.657 s) : 0, 8656754
section iast
Agent [baseline] (1.158 s) : 0, 1158333
Total [baseline] (9.262 s) : 0, 9261836
Agent [candidate] (1.157 s) : 0, 1157402
Total [candidate] (9.22 s) : 0, 9219878
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.024 s -
Agent iast 1.158 s 134.388 ms (13.1%)
Total tracing 8.649 s -
Total iast 9.262 s 612.497 ms (7.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.018 s -
Agent iast 1.157 s 139.006 ms (13.6%)
Total tracing 8.657 s -
Total iast 9.22 s 563.124 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~95b71ca9ca, baseline=1.54.0-SNAPSHOT~02cae20a94

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (699.12 ms) : 0, 699120
BytebuddyAgent [candidate] (694.261 ms) : 0, 694261
GlobalTracer [baseline] (242.722 ms) : 0, 242722
GlobalTracer [candidate] (241.981 ms) : 0, 241981
AppSec [baseline] (32.819 ms) : 0, 32819
AppSec [candidate] (32.715 ms) : 0, 32715
Debugger [baseline] (6.477 ms) : 0, 6477
Debugger [candidate] (6.38 ms) : 0, 6380
Remote Config [baseline] (681.439 µs) : 0, 681
Remote Config [candidate] (680.963 µs) : 0, 681
Telemetry [baseline] (9.381 ms) : 0, 9381
Telemetry [candidate] (9.188 ms) : 0, 9188
Flare Poller [baseline] (10.157 ms) : 0, 10157
Flare Poller [candidate] (10.762 ms) : 0, 10762
section iast
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (820.249 ms) : 0, 820249
BytebuddyAgent [candidate] (819.87 ms) : 0, 819870
GlobalTracer [baseline] (233.308 ms) : 0, 233308
GlobalTracer [candidate] (232.871 ms) : 0, 232871
IAST [baseline] (27.063 ms) : 0, 27063
IAST [candidate] (27.098 ms) : 0, 27098
AppSec [baseline] (35.373 ms) : 0, 35373
AppSec [candidate] (35.478 ms) : 0, 35478
Debugger [baseline] (6.144 ms) : 0, 6144
Debugger [candidate] (6.093 ms) : 0, 6093
Remote Config [baseline] (620.584 µs) : 0, 621
Remote Config [candidate] (599.598 µs) : 0, 600
Telemetry [baseline] (8.635 ms) : 0, 8635
Telemetry [candidate] (8.461 ms) : 0, 8461
Flare Poller [baseline] (4.237 ms) : 0, 4237
Flare Poller [candidate] (4.268 ms) : 0, 4268
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~95b71ca9ca, baseline=1.54.0-SNAPSHOT~02cae20a94

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1026594
Total [baseline] (10.661 s) : 0, 10660760
Agent [candidate] (1.02 s) : 0, 1019702
Total [candidate] (10.775 s) : 0, 10774996
section appsec
Agent [baseline] (1.197 s) : 0, 1196755
Total [baseline] (10.883 s) : 0, 10882770
Agent [candidate] (1.194 s) : 0, 1194286
Total [candidate] (10.956 s) : 0, 10955987
section iast
Agent [baseline] (1.15 s) : 0, 1150294
Total [baseline] (10.931 s) : 0, 10930545
Agent [candidate] (1.158 s) : 0, 1157666
Total [candidate] (10.907 s) : 0, 10906715
section profiling
Agent [baseline] (1.163 s) : 0, 1163400
Total [baseline] (11.011 s) : 0, 11010594
Agent [candidate] (1.167 s) : 0, 1166607
Total [candidate] (11.056 s) : 0, 11056267
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.027 s -
Agent appsec 1.197 s 170.161 ms (16.6%)
Agent iast 1.15 s 123.7 ms (12.0%)
Agent profiling 1.163 s 136.806 ms (13.3%)
Total tracing 10.661 s -
Total appsec 10.883 s 222.011 ms (2.1%)
Total iast 10.931 s 269.785 ms (2.5%)
Total profiling 11.011 s 349.834 ms (3.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.02 s -
Agent appsec 1.194 s 174.584 ms (17.1%)
Agent iast 1.158 s 137.965 ms (13.5%)
Agent profiling 1.167 s 146.906 ms (14.4%)
Total tracing 10.775 s -
Total appsec 10.956 s 180.99 ms (1.7%)
Total iast 10.907 s 131.719 ms (1.2%)
Total profiling 11.056 s 281.271 ms (2.6%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~95b71ca9ca, baseline=1.54.0-SNAPSHOT~02cae20a94

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (700.153 ms) : 0, 700153
BytebuddyAgent [candidate] (694.688 ms) : 0, 694688
GlobalTracer [baseline] (243.631 ms) : 0, 243631
GlobalTracer [candidate] (241.992 ms) : 0, 241992
AppSec [baseline] (33.076 ms) : 0, 33076
AppSec [candidate] (32.701 ms) : 0, 32701
Debugger [baseline] (6.465 ms) : 0, 6465
Debugger [candidate] (6.414 ms) : 0, 6414
Remote Config [baseline] (689.292 µs) : 0, 689
Remote Config [candidate] (683.223 µs) : 0, 683
Telemetry [baseline] (9.275 ms) : 0, 9275
Telemetry [candidate] (9.211 ms) : 0, 9211
Flare Poller [baseline] (10.602 ms) : 0, 10602
Flare Poller [candidate] (11.496 ms) : 0, 11496
section appsec
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (719.589 ms) : 0, 719589
BytebuddyAgent [candidate] (718.453 ms) : 0, 718453
GlobalTracer [baseline] (234.989 ms) : 0, 234989
GlobalTracer [candidate] (234.208 ms) : 0, 234208
AppSec [baseline] (174.581 ms) : 0, 174581
AppSec [candidate] (174.966 ms) : 0, 174966
Debugger [baseline] (6.159 ms) : 0, 6159
Debugger [candidate] (6.123 ms) : 0, 6123
Remote Config [baseline] (644.016 µs) : 0, 644
Remote Config [candidate] (640.216 µs) : 0, 640
Telemetry [baseline] (9.301 ms) : 0, 9301
Telemetry [candidate] (8.408 ms) : 0, 8408
Flare Poller [baseline] (4.0 ms) : 0, 4000
Flare Poller [candidate] (3.996 ms) : 0, 3996
IAST [baseline] (24.901 ms) : 0, 24901
IAST [candidate] (24.981 ms) : 0, 24981
section iast
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (814.3 ms) : 0, 814300
BytebuddyAgent [candidate] (819.864 ms) : 0, 819864
GlobalTracer [baseline] (231.97 ms) : 0, 231970
GlobalTracer [candidate] (233.322 ms) : 0, 233322
AppSec [baseline] (35.364 ms) : 0, 35364
AppSec [candidate] (35.307 ms) : 0, 35307
Debugger [baseline] (6.092 ms) : 0, 6092
Debugger [candidate] (6.092 ms) : 0, 6092
Remote Config [baseline] (603.136 µs) : 0, 603
Remote Config [candidate] (621.054 µs) : 0, 621
Telemetry [baseline] (8.411 ms) : 0, 8411
Telemetry [candidate] (8.497 ms) : 0, 8497
Flare Poller [baseline] (4.135 ms) : 0, 4135
Flare Poller [candidate] (4.196 ms) : 0, 4196
IAST [baseline] (26.719 ms) : 0, 26719
IAST [candidate] (27.051 ms) : 0, 27051
section profiling
ProfilingAgent [baseline] (106.531 ms) : 0, 106531
ProfilingAgent [candidate] (107.294 ms) : 0, 107294
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.418 ms) : 0, 1418
BytebuddyAgent [baseline] (723.193 ms) : 0, 723193
BytebuddyAgent [candidate] (725.352 ms) : 0, 725352
GlobalTracer [baseline] (218.07 ms) : 0, 218070
GlobalTracer [candidate] (218.425 ms) : 0, 218425
AppSec [baseline] (33.034 ms) : 0, 33034
AppSec [candidate] (33.165 ms) : 0, 33165
Debugger [baseline] (6.486 ms) : 0, 6486
Debugger [candidate] (7.253 ms) : 0, 7253
Remote Config [baseline] (684.964 µs) : 0, 685
Remote Config [candidate] (698.088 µs) : 0, 698
Telemetry [baseline] (16.526 ms) : 0, 16526
Telemetry [candidate] (15.844 ms) : 0, 15844
Flare Poller [baseline] (4.177 ms) : 0, 4177
Flare Poller [candidate] (4.153 ms) : 0, 4153
Profiling [baseline] (107.791 ms) : 0, 107791
Profiling [candidate] (108.195 ms) : 0, 108195
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/appsec-downstream-okhttp3
git_commit_date 1759657538 1759735365
git_commit_sha 02cae20 95b71ca
release_version 1.54.0-SNAPSHOT~02cae20a94 1.54.0-SNAPSHOT~95b71ca9ca
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1759737051 1759737051
ci_job_id 1163951415 1163951415
ci_pipeline_id 78434438 78434438
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-95x2r0az 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-95x2r0az 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:profiling:high_load better
[-536.691µs; -243.390µs] or [-5.960%; -2.703%]		 unstable
[-44.195op/s; +90.508op/s] or [-8.577%; +17.566%]		 8.615ms 538.406op/s 9.005ms 515.250op/s
scenario:load:petclinic:appsec:high_load better
[-3.631ms; -2.704ms] or [-7.169%; -5.338%]		 unstable
[-0.511op/s; +12.736op/s] or [-0.553%; +13.776%]		 47.481ms 98.562op/s 50.648ms 92.450op/s
scenario:load:petclinic:no_agent:high_load better
[-1.635ms; -1.004ms] or [-4.466%; -2.743%]		 unstable
[-3.884op/s; +13.434op/s] or [-3.040%; +10.517%]		 35.294ms 132.512op/s 36.614ms 127.737op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~95b71ca9ca, baseline=1.54.0-SNAPSHOT~02cae20a94
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.192 ms) : 4142, 4242
.   : milestone, 4192,
iast (9.341 ms) : 9188, 9493
.   : milestone, 9341,
iast_FULL (14.108 ms) : 13827, 14389
.   : milestone, 14108,
iast_GLOBAL (10.666 ms) : 10478, 10854
.   : milestone, 10666,
profiling (9.005 ms) : 8866, 9143
.   : milestone, 9005,
tracing (7.64 ms) : 7528, 7753
.   : milestone, 7640,
section candidate
no_agent (4.231 ms) : 4180, 4282
.   : milestone, 4231,
iast (9.33 ms) : 9178, 9482
.   : milestone, 9330,
iast_FULL (13.816 ms) : 13543, 14090
.   : milestone, 13816,
iast_GLOBAL (10.546 ms) : 10359, 10734
.   : milestone, 10546,
profiling (8.615 ms) : 8481, 8749
.   : milestone, 8615,
tracing (7.731 ms) : 7612, 7849
.   : milestone, 7731,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.192 ms [4.142 ms, 4.242 ms] -
iast 9.341 ms [9.188 ms, 9.493 ms] 5.148 ms (122.8%)
iast_FULL 14.108 ms [13.827 ms, 14.389 ms] 9.916 ms (236.5%)
iast_GLOBAL 10.666 ms [10.478 ms, 10.854 ms] 6.474 ms (154.4%)
profiling 9.005 ms [8.866 ms, 9.143 ms] 4.813 ms (114.8%)
tracing 7.64 ms [7.528 ms, 7.753 ms] 3.448 ms (82.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.231 ms [4.18 ms, 4.282 ms] -
iast 9.33 ms [9.178 ms, 9.482 ms] 5.099 ms (120.5%)
iast_FULL 13.816 ms [13.543 ms, 14.09 ms] 9.585 ms (226.5%)
iast_GLOBAL 10.546 ms [10.359 ms, 10.734 ms] 6.315 ms (149.3%)
profiling 8.615 ms [8.481 ms, 8.749 ms] 4.384 ms (103.6%)
tracing 7.731 ms [7.612 ms, 7.849 ms] 3.499 ms (82.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~95b71ca9ca, baseline=1.54.0-SNAPSHOT~02cae20a94
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.614 ms) : 36314, 36913
.   : milestone, 36614,
appsec (50.648 ms) : 50199, 51097
.   : milestone, 50648,
code_origins (44.591 ms) : 44209, 44973
.   : milestone, 44591,
iast (45.833 ms) : 45435, 46230
.   : milestone, 45833,
profiling (49.159 ms) : 48659, 49660
.   : milestone, 49159,
tracing (44.107 ms) : 43740, 44473
.   : milestone, 44107,
section candidate
no_agent (35.294 ms) : 35008, 35581
.   : milestone, 35294,
appsec (47.481 ms) : 47069, 47893
.   : milestone, 47481,
code_origins (43.963 ms) : 43602, 44324
.   : milestone, 43963,
iast (45.226 ms) : 44839, 45613
.   : milestone, 45226,
profiling (49.194 ms) : 48684, 49704
.   : milestone, 49194,
tracing (43.308 ms) : 42948, 43667
.   : milestone, 43308,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.614 ms [36.314 ms, 36.913 ms] -
appsec 50.648 ms [50.199 ms, 51.097 ms] 14.034 ms (38.3%)
code_origins 44.591 ms [44.209 ms, 44.973 ms] 7.977 ms (21.8%)
iast 45.833 ms [45.435 ms, 46.23 ms] 9.219 ms (25.2%)
profiling 49.159 ms [48.659 ms, 49.66 ms] 12.546 ms (34.3%)
tracing 44.107 ms [43.74 ms, 44.473 ms] 7.493 ms (20.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 35.294 ms [35.008 ms, 35.581 ms] -
appsec 47.481 ms [47.069 ms, 47.893 ms] 12.187 ms (34.5%)
code_origins 43.963 ms [43.602 ms, 44.324 ms] 8.669 ms (24.6%)
iast 45.226 ms [44.839 ms, 45.613 ms] 9.932 ms (28.1%)
profiling 49.194 ms [48.684 ms, 49.704 ms] 13.9 ms (39.4%)
tracing 43.308 ms [42.948 ms, 43.667 ms] 8.014 ms (22.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/appsec-downstream-okhttp3
git_commit_date 1759657538 1759735365
git_commit_sha 02cae20 95b71ca
release_version 1.54.0-SNAPSHOT~02cae20a94 1.54.0-SNAPSHOT~95b71ca9ca
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1759737582 1759737582
ci_job_id 1163951416 1163951416
ci_pipeline_id 78434438 78434438
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-987nyo70 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-987nyo70 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~95b71ca9ca, baseline=1.54.0-SNAPSHOT~02cae20a94
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (3.715 ms) : 3496, 3935
.   : milestone, 3715,
iast (2.208 ms) : 2144, 2271
.   : milestone, 2208,
iast_GLOBAL (2.253 ms) : 2189, 2317
.   : milestone, 2253,
profiling (2.511 ms) : 2339, 2683
.   : milestone, 2511,
tracing (2.028 ms) : 1978, 2077
.   : milestone, 2028,
section candidate
no_agent (1.481 ms) : 1470, 1493
.   : milestone, 1481,
appsec (3.743 ms) : 3524, 3963
.   : milestone, 3743,
iast (2.214 ms) : 2150, 2277
.   : milestone, 2214,
iast_GLOBAL (2.264 ms) : 2201, 2328
.   : milestone, 2264,
profiling (2.082 ms) : 2030, 2135
.   : milestone, 2082,
tracing (2.029 ms) : 1980, 2079
.   : milestone, 2029,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.466 ms, 1.489 ms] -
appsec 3.715 ms [3.496 ms, 3.935 ms] 2.238 ms (151.5%)
iast 2.208 ms [2.144 ms, 2.271 ms] 730.429 µs (49.4%)
iast_GLOBAL 2.253 ms [2.189 ms, 2.317 ms] 775.919 µs (52.5%)
profiling 2.511 ms [2.339 ms, 2.683 ms] 1.034 ms (70.0%)
tracing 2.028 ms [1.978 ms, 2.077 ms] 550.156 µs (37.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.481 ms [1.47 ms, 1.493 ms] -
appsec 3.743 ms [3.524 ms, 3.963 ms] 2.262 ms (152.7%)
iast 2.214 ms [2.15 ms, 2.277 ms] 732.237 µs (49.4%)
iast_GLOBAL 2.264 ms [2.201 ms, 2.328 ms] 782.956 µs (52.8%)
profiling 2.082 ms [2.03 ms, 2.135 ms] 600.822 µs (40.6%)
tracing 2.029 ms [1.98 ms, 2.079 ms] 547.848 µs (37.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~95b71ca9ca, baseline=1.54.0-SNAPSHOT~02cae20a94
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.576 s) : 15576000, 15576000
.   : milestone, 15576000,
appsec (14.987 s) : 14987000, 14987000
.   : milestone, 14987000,
iast (18.727 s) : 18727000, 18727000
.   : milestone, 18727000,
iast_GLOBAL (17.778 s) : 17778000, 17778000
.   : milestone, 17778000,
profiling (15.361 s) : 15361000, 15361000
.   : milestone, 15361000,
tracing (15.094 s) : 15094000, 15094000
.   : milestone, 15094000,
section candidate
no_agent (15.367 s) : 15367000, 15367000
.   : milestone, 15367000,
appsec (15.142 s) : 15142000, 15142000
.   : milestone, 15142000,
iast (18.437 s) : 18437000, 18437000
.   : milestone, 18437000,
iast_GLOBAL (18.033 s) : 18033000, 18033000
.   : milestone, 18033000,
profiling (15.966 s) : 15966000, 15966000
.   : milestone, 15966000,
tracing (15.105 s) : 15105000, 15105000
.   : milestone, 15105000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.576 s [15.576 s, 15.576 s] -
appsec 14.987 s [14.987 s, 14.987 s] -589.0 ms (-3.8%)
iast 18.727 s [18.727 s, 18.727 s] 3.151 s (20.2%)
iast_GLOBAL 17.778 s [17.778 s, 17.778 s] 2.202 s (14.1%)
profiling 15.361 s [15.361 s, 15.361 s] -215.0 ms (-1.4%)
tracing 15.094 s [15.094 s, 15.094 s] -482.0 ms (-3.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.367 s [15.367 s, 15.367 s] -
appsec 15.142 s [15.142 s, 15.142 s] -225.0 ms (-1.5%)
iast 18.437 s [18.437 s, 18.437 s] 3.07 s (20.0%)
iast_GLOBAL 18.033 s [18.033 s, 18.033 s] 2.666 s (17.3%)
profiling 15.966 s [15.966 s, 15.966 s] 599.0 ms (3.9%)
tracing 15.105 s [15.105 s, 15.105 s] -262.0 ms (-1.7%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/appsec-downstream-okhttp3 branch from 843aa9a to 31dd984 Compare October 3, 2025 07:20
jandro996
jandro996 approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@jandro996 jandro996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/appsec-downstream-okhttp3 branch from 31dd984 to 95b71ca Compare October 6, 2025 07:22
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 55230eb into master Oct 6, 2025
534 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/appsec-downstream-okhttp3 branch October 6, 2025 08:22
@github-actions github-actions bot added this to the 1.54.0 milestone Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandro996 jandro996 jandro996 approved these changes

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) inst: others All other instrumentations type: enhancement Enhancements and improvements
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
2 participants
@manuel-alvarez-alvarez @jandro996