-
Notifications
You must be signed in to change notification settings - Fork 312
Send process tags once per payload #9657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎯 Code Coverage 🔗 Commit SHA: dde2240 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~dde2240cc2, baseline=1.54.0-SNAPSHOT~bd0c1fb5ad
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042343
Total [baseline] (10.829 s) : 0, 10829266
Agent [candidate] (1.018 s) : 0, 1018073
Total [candidate] (10.761 s) : 0, 10761029
section appsec
Agent [baseline] (1.196 s) : 0, 1195636
Total [baseline] (10.994 s) : 0, 10993830
Agent [candidate] (1.193 s) : 0, 1192507
Total [candidate] (11.155 s) : 0, 11154785
section iast
Agent [baseline] (1.159 s) : 0, 1158722
Total [baseline] (10.887 s) : 0, 10886867
Agent [candidate] (1.156 s) : 0, 1155959
Total [candidate] (10.885 s) : 0, 10885088
section profiling
Agent [baseline] (1.168 s) : 0, 1167750
Total [baseline] (11.099 s) : 0, 11099461
Agent [candidate] (1.162 s) : 0, 1161752
Total [candidate] (11.051 s) : 0, 11050682
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~dde2240cc2, baseline=1.54.0-SNAPSHOT~bd0c1fb5ad
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.504 ms) : 0, 1504
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (709.662 ms) : 0, 709662
BytebuddyAgent [candidate] (692.568 ms) : 0, 692568
GlobalTracer [baseline] (247.696 ms) : 0, 247696
GlobalTracer [candidate] (242.935 ms) : 0, 242935
AppSec [baseline] (33.441 ms) : 0, 33441
AppSec [candidate] (32.77 ms) : 0, 32770
Debugger [baseline] (6.541 ms) : 0, 6541
Debugger [candidate] (6.381 ms) : 0, 6381
Remote Config [baseline] (697.157 µs) : 0, 697
Remote Config [candidate] (682.008 µs) : 0, 682
Telemetry [baseline] (9.426 ms) : 0, 9426
Telemetry [candidate] (9.238 ms) : 0, 9238
Flare Poller [baseline] (11.805 ms) : 0, 11805
Flare Poller [candidate] (10.805 ms) : 0, 10805
section appsec
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (717.591 ms) : 0, 717591
BytebuddyAgent [candidate] (716.181 ms) : 0, 716181
GlobalTracer [baseline] (236.174 ms) : 0, 236174
GlobalTracer [candidate] (235.539 ms) : 0, 235539
IAST [baseline] (24.932 ms) : 0, 24932
IAST [candidate] (24.759 ms) : 0, 24759
AppSec [baseline] (174.3 ms) : 0, 174300
AppSec [candidate] (173.649 ms) : 0, 173649
Debugger [baseline] (6.091 ms) : 0, 6091
Debugger [candidate] (5.995 ms) : 0, 5995
Remote Config [baseline] (646.625 µs) : 0, 647
Remote Config [candidate] (651.105 µs) : 0, 651
Telemetry [baseline] (8.594 ms) : 0, 8594
Telemetry [candidate] (9.145 ms) : 0, 9145
Flare Poller [baseline] (4.744 ms) : 0, 4744
Flare Poller [candidate] (3.983 ms) : 0, 3983
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (820.928 ms) : 0, 820928
BytebuddyAgent [candidate] (817.359 ms) : 0, 817359
GlobalTracer [baseline] (234.567 ms) : 0, 234567
GlobalTracer [candidate] (234.457 ms) : 0, 234457
IAST [baseline] (26.119 ms) : 0, 26119
IAST [candidate] (26.523 ms) : 0, 26523
AppSec [baseline] (35.036 ms) : 0, 35036
AppSec [candidate] (35.404 ms) : 0, 35404
Debugger [baseline] (6.087 ms) : 0, 6087
Debugger [candidate] (6.079 ms) : 0, 6079
Remote Config [baseline] (593.421 µs) : 0, 593
Remote Config [candidate] (594.299 µs) : 0, 594
Telemetry [baseline] (8.409 ms) : 0, 8409
Telemetry [candidate] (8.379 ms) : 0, 8379
Flare Poller [baseline] (4.241 ms) : 0, 4241
Flare Poller [candidate] (4.232 ms) : 0, 4232
section profiling
crashtracking [baseline] (1.435 ms) : 0, 1435
crashtracking [candidate] (1.413 ms) : 0, 1413
BytebuddyAgent [baseline] (724.963 ms) : 0, 724963
BytebuddyAgent [candidate] (720.588 ms) : 0, 720588
GlobalTracer [baseline] (219.741 ms) : 0, 219741
GlobalTracer [candidate] (218.536 ms) : 0, 218536
AppSec [baseline] (32.844 ms) : 0, 32844
AppSec [candidate] (32.562 ms) : 0, 32562
Debugger [baseline] (6.567 ms) : 0, 6567
Debugger [candidate] (6.586 ms) : 0, 6586
Remote Config [baseline] (847.857 µs) : 0, 848
Remote Config [candidate] (751.249 µs) : 0, 751
Telemetry [baseline] (16.532 ms) : 0, 16532
Telemetry [candidate] (16.644 ms) : 0, 16644
Flare Poller [baseline] (4.129 ms) : 0, 4129
Flare Poller [candidate] (4.279 ms) : 0, 4279
ProfilingAgent [baseline] (107.846 ms) : 0, 107846
ProfilingAgent [candidate] (106.35 ms) : 0, 106350
Profiling [baseline] (108.823 ms) : 0, 108823
Profiling [candidate] (108.442 ms) : 0, 108442
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~dde2240cc2, baseline=1.54.0-SNAPSHOT~bd0c1fb5ad
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1025518
Total [baseline] (8.684 s) : 0, 8684009
Agent [candidate] (1.027 s) : 0, 1026667
Total [candidate] (8.688 s) : 0, 8687645
section iast
Agent [baseline] (1.152 s) : 0, 1151688
Total [baseline] (9.293 s) : 0, 9292517
Agent [candidate] (1.151 s) : 0, 1151456
Total [candidate] (9.29 s) : 0, 9289905
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~dde2240cc2, baseline=1.54.0-SNAPSHOT~bd0c1fb5ad
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (698.447 ms) : 0, 698447
BytebuddyAgent [candidate] (697.865 ms) : 0, 697865
GlobalTracer [baseline] (244.406 ms) : 0, 244406
GlobalTracer [candidate] (246.224 ms) : 0, 246224
AppSec [baseline] (32.918 ms) : 0, 32918
AppSec [candidate] (33.552 ms) : 0, 33552
Debugger [baseline] (6.416 ms) : 0, 6416
Debugger [candidate] (6.529 ms) : 0, 6529
Remote Config [baseline] (674.516 µs) : 0, 675
Remote Config [candidate] (705.855 µs) : 0, 706
Telemetry [baseline] (9.306 ms) : 0, 9306
Telemetry [candidate] (9.235 ms) : 0, 9235
Flare Poller [baseline] (10.655 ms) : 0, 10655
Flare Poller [candidate] (9.771 ms) : 0, 9771
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (814.443 ms) : 0, 814443
BytebuddyAgent [candidate] (814.155 ms) : 0, 814155
GlobalTracer [baseline] (233.623 ms) : 0, 233623
GlobalTracer [candidate] (233.846 ms) : 0, 233846
IAST [baseline] (27.1 ms) : 0, 27100
IAST [candidate] (26.525 ms) : 0, 26525
AppSec [baseline] (34.513 ms) : 0, 34513
AppSec [candidate] (35.003 ms) : 0, 35003
Debugger [baseline] (6.194 ms) : 0, 6194
Debugger [candidate] (6.065 ms) : 0, 6065
Remote Config [baseline] (582.561 µs) : 0, 583
Remote Config [candidate] (594.498 µs) : 0, 594
Telemetry [baseline] (8.464 ms) : 0, 8464
Telemetry [candidate] (8.285 ms) : 0, 8285
Flare Poller [baseline] (4.193 ms) : 0, 4193
Flare Poller [candidate] (4.239 ms) : 0, 4239
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~dde2240cc2, baseline=1.54.0-SNAPSHOT~bd0c1fb5ad
dateFormat X
axisFormat %s
section baseline
no_agent (37.96 ms) : 37659, 38261
. : milestone, 37960,
appsec (47.46 ms) : 47039, 47881
. : milestone, 47460,
code_origins (44.64 ms) : 44251, 45029
. : milestone, 44640,
iast (45.064 ms) : 44670, 45458
. : milestone, 45064,
profiling (50.34 ms) : 49876, 50804
. : milestone, 50340,
tracing (44.465 ms) : 44088, 44843
. : milestone, 44465,
section candidate
no_agent (38.571 ms) : 38251, 38890
. : milestone, 38571,
appsec (47.76 ms) : 47341, 48179
. : milestone, 47760,
code_origins (44.702 ms) : 44318, 45087
. : milestone, 44702,
iast (45.767 ms) : 45365, 46168
. : milestone, 45767,
profiling (50.512 ms) : 50035, 50988
. : milestone, 50512,
tracing (45.48 ms) : 45082, 45878
. : milestone, 45480,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~dde2240cc2, baseline=1.54.0-SNAPSHOT~bd0c1fb5ad
dateFormat X
axisFormat %s
section baseline
no_agent (4.43 ms) : 4376, 4483
. : milestone, 4430,
iast (9.802 ms) : 9640, 9964
. : milestone, 9802,
iast_FULL (14.202 ms) : 13920, 14484
. : milestone, 14202,
iast_GLOBAL (10.764 ms) : 10554, 10974
. : milestone, 10764,
profiling (9.064 ms) : 8925, 9203
. : milestone, 9064,
tracing (7.818 ms) : 7705, 7930
. : milestone, 7818,
section candidate
no_agent (4.616 ms) : 4554, 4679
. : milestone, 4616,
iast (9.558 ms) : 9402, 9715
. : milestone, 9558,
iast_FULL (14.07 ms) : 13788, 14351
. : milestone, 14070,
iast_GLOBAL (10.818 ms) : 10627, 11009
. : milestone, 10818,
profiling (9.311 ms) : 9161, 9462
. : milestone, 9311,
tracing (7.722 ms) : 7597, 7847
. : milestone, 7722,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~dde2240cc2, baseline=1.54.0-SNAPSHOT~bd0c1fb5ad
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.469 ms) : 2418, 2520
. : milestone, 2469,
iast (2.202 ms) : 2139, 2265
. : milestone, 2202,
iast_GLOBAL (2.256 ms) : 2193, 2320
. : milestone, 2256,
profiling (2.076 ms) : 2023, 2128
. : milestone, 2076,
tracing (2.03 ms) : 1981, 2079
. : milestone, 2030,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.674 ms) : 3461, 3888
. : milestone, 3674,
iast (2.205 ms) : 2142, 2268
. : milestone, 2205,
iast_GLOBAL (2.246 ms) : 2183, 2310
. : milestone, 2246,
profiling (2.054 ms) : 2003, 2105
. : milestone, 2054,
tracing (2.03 ms) : 1980, 2079
. : milestone, 2030,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~dde2240cc2, baseline=1.54.0-SNAPSHOT~bd0c1fb5ad
dateFormat X
axisFormat %s
section baseline
no_agent (15.512 s) : 15512000, 15512000
. : milestone, 15512000,
appsec (14.965 s) : 14965000, 14965000
. : milestone, 14965000,
iast (18.59 s) : 18590000, 18590000
. : milestone, 18590000,
iast_GLOBAL (18.204 s) : 18204000, 18204000
. : milestone, 18204000,
profiling (15.565 s) : 15565000, 15565000
. : milestone, 15565000,
tracing (15.041 s) : 15041000, 15041000
. : milestone, 15041000,
section candidate
no_agent (15.302 s) : 15302000, 15302000
. : milestone, 15302000,
appsec (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
iast (18.557 s) : 18557000, 18557000
. : milestone, 18557000,
iast_GLOBAL (17.662 s) : 17662000, 17662000
. : milestone, 17662000,
profiling (15.482 s) : 15482000, 15482000
. : milestone, 15482000,
tracing (14.932 s) : 14932000, 14932000
. : milestone, 14932000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice perf win
communication/src/main/java/datadog/communication/serialization/Mapper.java
Outdated
Show resolved
Hide resolved
dd-trace-core/src/main/java/datadog/trace/common/writer/ddagent/TraceMapperV0_4.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow up changes!
What Does This Do
Optimises the way the process tags are sent to the agent in the tracing payload. Those tags are the same throughout the life of a process.
The agent is just looking in the first span of each payload but we were sending it on each first span of each trace.
This PR adds a way, for a writer, to send data only once per payload
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]