Skip to content

Fix Exception Probes to not emit any probe status #9669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2025
Merged

Fix Exception Probes to not emit any probe status #9669

merged 3 commits into from
Oct 6, 2025

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Oct 3, 2025 •
edited by atlassian bot
Loading

What Does This Do

filter on probe definition type

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-4559

@jpbempel jpbempel requested a review from a team as a code owner October 3, 2025 17:21
@jpbempel jpbempel added the type: enhancement Enhancements and improvements label Oct 3, 2025
@jpbempel jpbempel requested review from shatzi and removed request for a team October 3, 2025 17:21
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Oct 3, 2025
@pr-commenter
Copy link

pr-commenter bot commented Oct 3, 2025 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1759740802 1759741208
end_time 2025-10-06T08:54:42 2025-10-06T09:01:28
git_branch master jpbempel/er-no-probe-status
git_commit_sha 55230eb 2dac9e5
start_time 2025-10-06T08:53:23 2025-10-06T09:00:09
See matching parameters
Baseline Candidate
ci_job_id 1164074241 1164074241
ci_pipeline_id 78440112 78440112
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1759740168 1759740168

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-3.898ms; -3.288ms] or [-31.281%; -26.381%]		 better
[-3.921ms; -3.305ms] or [-31.158%; -26.262%]		 better
[-3.908ms; -3.293ms] or [-30.938%; -26.070%]		 better
[-3.910ms; -3.298ms] or [-30.633%; -25.837%]		 better
[+25.011op/s; +30.160op/s] or [+30.388%; +36.645%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-17.618µs; +32.946µs] or [-6.433%; +12.030%]		 unstable
[-26.927µs; +47.623µs] or [-8.675%; +15.343%]		 unstable
[-35.505µs; +64.221µs] or [-10.986%; +19.872%]		 unstable
[-184.850µs; +40.946µs] or [-18.604%; +4.121%]		 same
scenario:basic unsure
[-4.583µs; -0.618µs] or [-1.823%; -0.246%]		 same same unstable
[-218.688µs; -24.688µs] or [-26.414%; -2.982%]		 unstable
[-198.219op/s; +198.219op/s] or [-7.532%; +7.532%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (310.393 µs) : 287, 334
.   : milestone, 310,
basic (279.954 µs) : 274, 286
.   : milestone, 280,
loop (12.585 ms) : 12180, 12989
.   : milestone, 12585,
section candidate
noprobe (320.741 µs) : 276, 365
.   : milestone, 321,
basic (277.188 µs) : 272, 282
.   : milestone, 277,
loop (8.972 ms) : 8967, 8977
.   : milestone, 8972,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 310.393 µs [287.123 µs, 333.663 µs]
basic 279.954 µs [274.067 µs, 285.841 µs]
loop 12.585 ms [12.18 ms, 12.989 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 320.741 µs [276.262 µs, 365.221 µs]
basic 277.188 µs [272.213 µs, 282.163 µs]
loop 8.972 ms [8.967 ms, 8.977 ms]

@datadog-official Datadog Official
Copy link

datadog-official bot commented Oct 3, 2025 •
edited
Loading

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 57.98% (-0.13%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2dac9e5 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 3, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/er-no-probe-status
git_commit_date 1759738952 1759740168
git_commit_sha 55230eb 2dac9e5
release_version 1.54.0-SNAPSHOT~55230eb888 1.54.0-SNAPSHOT~2dac9e5ffc
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1759742009 1759742009
ci_job_id 1164074233 1164074233
ci_pipeline_id 78440112 78440112
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-3-q957sici 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-3-q957sici 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~2dac9e5ffc, baseline=1.54.0-SNAPSHOT~55230eb888

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1026957
Total [baseline] (10.673 s) : 0, 10672917
Agent [candidate] (1.018 s) : 0, 1018361
Total [candidate] (10.642 s) : 0, 10641802
section appsec
Agent [baseline] (1.192 s) : 0, 1191672
Total [baseline] (10.936 s) : 0, 10935623
Agent [candidate] (1.191 s) : 0, 1191184
Total [candidate] (10.996 s) : 0, 10996229
section iast
Agent [baseline] (1.153 s) : 0, 1152983
Total [baseline] (10.873 s) : 0, 10872657
Agent [candidate] (1.15 s) : 0, 1149758
Total [candidate] (10.979 s) : 0, 10978620
section profiling
Agent [baseline] (1.161 s) : 0, 1160640
Total [baseline] (11.035 s) : 0, 11035351
Agent [candidate] (1.165 s) : 0, 1164925
Total [candidate] (10.984 s) : 0, 10984388
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.027 s -
Agent appsec 1.192 s 164.715 ms (16.0%)
Agent iast 1.153 s 126.026 ms (12.3%)
Agent profiling 1.161 s 133.682 ms (13.0%)
Total tracing 10.673 s -
Total appsec 10.936 s 262.706 ms (2.5%)
Total iast 10.873 s 199.74 ms (1.9%)
Total profiling 11.035 s 362.434 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.018 s -
Agent appsec 1.191 s 172.823 ms (17.0%)
Agent iast 1.15 s 131.397 ms (12.9%)
Agent profiling 1.165 s 146.564 ms (14.4%)
Total tracing 10.642 s -
Total appsec 10.996 s 354.427 ms (3.3%)
Total iast 10.979 s 336.818 ms (3.2%)
Total profiling 10.984 s 342.586 ms (3.2%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~2dac9e5ffc, baseline=1.54.0-SNAPSHOT~55230eb888

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (700.215 ms) : 0, 700215
BytebuddyAgent [candidate] (693.088 ms) : 0, 693088
GlobalTracer [baseline] (243.728 ms) : 0, 243728
GlobalTracer [candidate] (243.051 ms) : 0, 243051
AppSec [baseline] (33.016 ms) : 0, 33016
AppSec [candidate] (32.489 ms) : 0, 32489
Debugger [baseline] (6.443 ms) : 0, 6443
Debugger [candidate] (6.311 ms) : 0, 6311
Remote Config [baseline] (701.358 µs) : 0, 701
Remote Config [candidate] (673.214 µs) : 0, 673
Telemetry [baseline] (9.331 ms) : 0, 9331
Telemetry [candidate] (9.229 ms) : 0, 9229
Flare Poller [baseline] (10.871 ms) : 0, 10871
Flare Poller [candidate] (10.871 ms) : 0, 10871
section appsec
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (716.944 ms) : 0, 716944
BytebuddyAgent [candidate] (715.676 ms) : 0, 715676
GlobalTracer [baseline] (233.617 ms) : 0, 233617
GlobalTracer [candidate] (235.392 ms) : 0, 235392
IAST [baseline] (24.664 ms) : 0, 24664
IAST [candidate] (24.744 ms) : 0, 24744
AppSec [baseline] (174.902 ms) : 0, 174902
AppSec [candidate] (172.958 ms) : 0, 172958
Debugger [baseline] (6.132 ms) : 0, 6132
Debugger [candidate] (6.038 ms) : 0, 6038
Remote Config [baseline] (630.878 µs) : 0, 631
Remote Config [candidate] (631.695 µs) : 0, 632
Telemetry [baseline] (8.377 ms) : 0, 8377
Telemetry [candidate] (9.262 ms) : 0, 9262
Flare Poller [baseline] (3.942 ms) : 0, 3942
Flare Poller [candidate] (3.972 ms) : 0, 3972
section iast
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (815.743 ms) : 0, 815743
BytebuddyAgent [candidate] (812.954 ms) : 0, 812954
GlobalTracer [baseline] (232.914 ms) : 0, 232914
GlobalTracer [candidate] (232.996 ms) : 0, 232996
IAST [baseline] (26.941 ms) : 0, 26941
IAST [candidate] (26.135 ms) : 0, 26135
AppSec [baseline] (35.489 ms) : 0, 35489
AppSec [candidate] (35.493 ms) : 0, 35493
Debugger [baseline] (6.017 ms) : 0, 6017
Debugger [candidate] (6.128 ms) : 0, 6128
Remote Config [baseline] (600.514 µs) : 0, 601
Remote Config [candidate] (587.84 µs) : 0, 588
Telemetry [baseline] (8.444 ms) : 0, 8444
Telemetry [candidate] (8.566 ms) : 0, 8566
Flare Poller [baseline] (4.167 ms) : 0, 4167
Flare Poller [candidate] (4.238 ms) : 0, 4238
section profiling
crashtracking [baseline] (1.418 ms) : 0, 1418
crashtracking [candidate] (1.418 ms) : 0, 1418
BytebuddyAgent [baseline] (721.328 ms) : 0, 721328
BytebuddyAgent [candidate] (722.787 ms) : 0, 722787
GlobalTracer [baseline] (217.47 ms) : 0, 217470
GlobalTracer [candidate] (219.166 ms) : 0, 219166
AppSec [baseline] (33.061 ms) : 0, 33061
AppSec [candidate] (32.728 ms) : 0, 32728
Debugger [baseline] (6.42 ms) : 0, 6420
Debugger [candidate] (8.014 ms) : 0, 8014
Remote Config [baseline] (754.119 µs) : 0, 754
Remote Config [candidate] (732.038 µs) : 0, 732
Telemetry [baseline] (16.399 ms) : 0, 16399
Telemetry [candidate] (15.068 ms) : 0, 15068
Flare Poller [baseline] (4.13 ms) : 0, 4130
Flare Poller [candidate] (4.124 ms) : 0, 4124
ProfilingAgent [baseline] (106.755 ms) : 0, 106755
ProfilingAgent [candidate] (108.216 ms) : 0, 108216
Profiling [baseline] (107.754 ms) : 0, 107754
Profiling [candidate] (109.048 ms) : 0, 109048
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~2dac9e5ffc, baseline=1.54.0-SNAPSHOT~55230eb888

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020241
Total [baseline] (8.672 s) : 0, 8672063
Agent [candidate] (1.021 s) : 0, 1020550
Total [candidate] (8.61 s) : 0, 8610051
section iast
Agent [baseline] (1.153 s) : 0, 1152744
Total [baseline] (9.225 s) : 0, 9224536
Agent [candidate] (1.152 s) : 0, 1152060
Total [candidate] (9.247 s) : 0, 9247124
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.02 s -
Agent iast 1.153 s 132.503 ms (13.0%)
Total tracing 8.672 s -
Total iast 9.225 s 552.474 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.021 s -
Agent iast 1.152 s 131.51 ms (12.9%)
Total tracing 8.61 s -
Total iast 9.247 s 637.073 ms (7.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~2dac9e5ffc, baseline=1.54.0-SNAPSHOT~55230eb888

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (695.716 ms) : 0, 695716
BytebuddyAgent [candidate] (694.128 ms) : 0, 694128
GlobalTracer [baseline] (242.277 ms) : 0, 242277
GlobalTracer [candidate] (243.598 ms) : 0, 243598
AppSec [baseline] (32.996 ms) : 0, 32996
AppSec [candidate] (32.539 ms) : 0, 32539
Debugger [baseline] (6.415 ms) : 0, 6415
Debugger [candidate] (6.339 ms) : 0, 6339
Remote Config [baseline] (686.06 µs) : 0, 686
Remote Config [candidate] (669.795 µs) : 0, 670
Telemetry [baseline] (9.373 ms) : 0, 9373
Telemetry [candidate] (9.268 ms) : 0, 9268
Flare Poller [baseline] (10.152 ms) : 0, 10152
Flare Poller [candidate] (11.462 ms) : 0, 11462
section iast
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (815.973 ms) : 0, 815973
BytebuddyAgent [candidate] (815.212 ms) : 0, 815212
GlobalTracer [baseline] (232.671 ms) : 0, 232671
GlobalTracer [candidate] (233.3 ms) : 0, 233300
AppSec [baseline] (35.278 ms) : 0, 35278
AppSec [candidate] (35.084 ms) : 0, 35084
Debugger [baseline] (6.07 ms) : 0, 6070
Debugger [candidate] (6.174 ms) : 0, 6174
Remote Config [baseline] (597.976 µs) : 0, 598
Remote Config [candidate] (592.684 µs) : 0, 593
Telemetry [baseline] (8.531 ms) : 0, 8531
Telemetry [candidate] (8.487 ms) : 0, 8487
Flare Poller [baseline] (4.13 ms) : 0, 4130
Flare Poller [candidate] (4.192 ms) : 0, 4192
IAST [baseline] (26.72 ms) : 0, 26720
IAST [candidate] (26.352 ms) : 0, 26352
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/er-no-probe-status
git_commit_date 1759738952 1759740168
git_commit_sha 55230eb 2dac9e5
release_version 1.54.0-SNAPSHOT~55230eb888 1.54.0-SNAPSHOT~2dac9e5ffc
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1759741671 1759741671
ci_job_id 1164074234 1164074234
ci_pipeline_id 78440112 78440112
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-4-odaxs67j 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-4-odaxs67j 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load better
[-220.111µs; -104.427µs] or [-4.913%; -2.331%]		 unstable
[-72.390op/s; +148.328op/s] or [-7.063%; +14.473%]		 4.318ms 1062.844op/s 4.480ms 1024.875op/s
scenario:load:insecure-bank:tracing:high_load better
[-442.833µs; -194.170µs] or [-5.525%; -2.423%]		 unstable
[-47.744op/s; +94.619op/s] or [-8.257%; +16.363%]		 7.697ms 601.688op/s 8.015ms 578.250op/s
scenario:load:petclinic:profiling:high_load better
[-3.987ms; -2.973ms] or [-7.945%; -5.923%]		 unstable
[-0.051op/s; +13.901op/s] or [-0.054%; +14.903%]		 46.709ms 100.200op/s 50.189ms 93.275op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~2dac9e5ffc, baseline=1.54.0-SNAPSHOT~55230eb888
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.48 ms) : 4428, 4532
.   : milestone, 4480,
iast (9.747 ms) : 9584, 9910
.   : milestone, 9747,
iast_FULL (14.725 ms) : 14434, 15015
.   : milestone, 14725,
iast_GLOBAL (10.596 ms) : 10392, 10800
.   : milestone, 10596,
profiling (9.113 ms) : 8957, 9269
.   : milestone, 9113,
tracing (8.015 ms) : 7897, 8134
.   : milestone, 8015,
section candidate
no_agent (4.318 ms) : 4263, 4373
.   : milestone, 4318,
iast (9.573 ms) : 9411, 9735
.   : milestone, 9573,
iast_FULL (14.401 ms) : 14113, 14690
.   : milestone, 14401,
iast_GLOBAL (10.365 ms) : 10168, 10561
.   : milestone, 10365,
profiling (8.935 ms) : 8786, 9084
.   : milestone, 8935,
tracing (7.697 ms) : 7584, 7809
.   : milestone, 7697,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.48 ms [4.428 ms, 4.532 ms] -
iast 9.747 ms [9.584 ms, 9.91 ms] 5.267 ms (117.6%)
iast_FULL 14.725 ms [14.434 ms, 15.015 ms] 10.245 ms (228.7%)
iast_GLOBAL 10.596 ms [10.392 ms, 10.8 ms] 6.116 ms (136.5%)
profiling 9.113 ms [8.957 ms, 9.269 ms] 4.633 ms (103.4%)
tracing 8.015 ms [7.897 ms, 8.134 ms] 3.535 ms (78.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.318 ms [4.263 ms, 4.373 ms] -
iast 9.573 ms [9.411 ms, 9.735 ms] 5.255 ms (121.7%)
iast_FULL 14.401 ms [14.113 ms, 14.69 ms] 10.083 ms (233.5%)
iast_GLOBAL 10.365 ms [10.168 ms, 10.561 ms] 6.047 ms (140.1%)
profiling 8.935 ms [8.786 ms, 9.084 ms] 4.618 ms (106.9%)
tracing 7.697 ms [7.584 ms, 7.809 ms] 3.379 ms (78.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~2dac9e5ffc, baseline=1.54.0-SNAPSHOT~55230eb888
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.554 ms) : 37250, 37858
.   : milestone, 37554,
appsec (47.625 ms) : 47202, 48049
.   : milestone, 47625,
code_origins (43.592 ms) : 43218, 43965
.   : milestone, 43592,
iast (45.334 ms) : 44952, 45717
.   : milestone, 45334,
profiling (50.189 ms) : 49686, 50693
.   : milestone, 50189,
tracing (43.815 ms) : 43439, 44191
.   : milestone, 43815,
section candidate
no_agent (36.53 ms) : 36239, 36820
.   : milestone, 36530,
appsec (48.446 ms) : 48023, 48870
.   : milestone, 48446,
code_origins (43.321 ms) : 42951, 43690
.   : milestone, 43321,
iast (45.225 ms) : 44836, 45614
.   : milestone, 45225,
profiling (46.709 ms) : 46272, 47146
.   : milestone, 46709,
tracing (42.982 ms) : 42612, 43353
.   : milestone, 42982,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.554 ms [37.25 ms, 37.858 ms] -
appsec 47.625 ms [47.202 ms, 48.049 ms] 10.071 ms (26.8%)
code_origins 43.592 ms [43.218 ms, 43.965 ms] 6.037 ms (16.1%)
iast 45.334 ms [44.952 ms, 45.717 ms] 7.78 ms (20.7%)
profiling 50.189 ms [49.686 ms, 50.693 ms] 12.635 ms (33.6%)
tracing 43.815 ms [43.439 ms, 44.191 ms] 6.261 ms (16.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.53 ms [36.239 ms, 36.82 ms] -
appsec 48.446 ms [48.023 ms, 48.87 ms] 11.916 ms (32.6%)
code_origins 43.321 ms [42.951 ms, 43.69 ms] 6.791 ms (18.6%)
iast 45.225 ms [44.836 ms, 45.614 ms] 8.695 ms (23.8%)
profiling 46.709 ms [46.272 ms, 47.146 ms] 10.179 ms (27.9%)
tracing 42.982 ms [42.612 ms, 43.353 ms] 6.453 ms (17.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/er-no-probe-status
git_commit_date 1759738952 1759740168
git_commit_sha 55230eb 2dac9e5
release_version 1.54.0-SNAPSHOT~55230eb888 1.54.0-SNAPSHOT~2dac9e5ffc
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1759742149 1759742149
ci_job_id 1164074235 1164074235
ci_pipeline_id 78440112 78440112
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-5-73b2kprp 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-5-73b2kprp 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~2dac9e5ffc, baseline=1.54.0-SNAPSHOT~55230eb888
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
.   : milestone, 1481,
appsec (3.69 ms) : 3475, 3904
.   : milestone, 3690,
iast (2.217 ms) : 2154, 2280
.   : milestone, 2217,
iast_GLOBAL (2.275 ms) : 2211, 2339
.   : milestone, 2275,
profiling (2.537 ms) : 2364, 2710
.   : milestone, 2537,
tracing (2.049 ms) : 1999, 2099
.   : milestone, 2049,
section candidate
no_agent (1.482 ms) : 1471, 1494
.   : milestone, 1482,
appsec (3.754 ms) : 3534, 3973
.   : milestone, 3754,
iast (2.231 ms) : 2167, 2295
.   : milestone, 2231,
iast_GLOBAL (2.276 ms) : 2211, 2340
.   : milestone, 2276,
profiling (2.065 ms) : 2014, 2117
.   : milestone, 2065,
tracing (2.053 ms) : 2003, 2103
.   : milestone, 2053,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.481 ms [1.47 ms, 1.493 ms] -
appsec 3.69 ms [3.475 ms, 3.904 ms] 2.208 ms (149.0%)
iast 2.217 ms [2.154 ms, 2.28 ms] 735.326 µs (49.6%)
iast_GLOBAL 2.275 ms [2.211 ms, 2.339 ms] 793.36 µs (53.6%)
profiling 2.537 ms [2.364 ms, 2.71 ms] 1.056 ms (71.3%)
tracing 2.049 ms [1.999 ms, 2.099 ms] 567.523 µs (38.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.471 ms, 1.494 ms] -
appsec 3.754 ms [3.534 ms, 3.973 ms] 2.271 ms (153.2%)
iast 2.231 ms [2.167 ms, 2.295 ms] 748.516 µs (50.5%)
iast_GLOBAL 2.276 ms [2.211 ms, 2.34 ms] 793.445 µs (53.5%)
profiling 2.065 ms [2.014 ms, 2.117 ms] 583.153 µs (39.3%)
tracing 2.053 ms [2.003 ms, 2.103 ms] 570.717 µs (38.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~2dac9e5ffc, baseline=1.54.0-SNAPSHOT~55230eb888
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.932 s) : 14932000, 14932000
.   : milestone, 14932000,
appsec (14.981 s) : 14981000, 14981000
.   : milestone, 14981000,
iast (18.59 s) : 18590000, 18590000
.   : milestone, 18590000,
iast_GLOBAL (18.022 s) : 18022000, 18022000
.   : milestone, 18022000,
profiling (16.004 s) : 16004000, 16004000
.   : milestone, 16004000,
tracing (14.773 s) : 14773000, 14773000
.   : milestone, 14773000,
section candidate
no_agent (15.644 s) : 15644000, 15644000
.   : milestone, 15644000,
appsec (14.851 s) : 14851000, 14851000
.   : milestone, 14851000,
iast (18.834 s) : 18834000, 18834000
.   : milestone, 18834000,
iast_GLOBAL (18.005 s) : 18005000, 18005000
.   : milestone, 18005000,
profiling (15.358 s) : 15358000, 15358000
.   : milestone, 15358000,
tracing (15.022 s) : 15022000, 15022000
.   : milestone, 15022000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.932 s [14.932 s, 14.932 s] -
appsec 14.981 s [14.981 s, 14.981 s] 49.0 ms (0.3%)
iast 18.59 s [18.59 s, 18.59 s] 3.658 s (24.5%)
iast_GLOBAL 18.022 s [18.022 s, 18.022 s] 3.09 s (20.7%)
profiling 16.004 s [16.004 s, 16.004 s] 1.072 s (7.2%)
tracing 14.773 s [14.773 s, 14.773 s] -159.0 ms (-1.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.644 s [15.644 s, 15.644 s] -
appsec 14.851 s [14.851 s, 14.851 s] -793.0 ms (-5.1%)
iast 18.834 s [18.834 s, 18.834 s] 3.19 s (20.4%)
iast_GLOBAL 18.005 s [18.005 s, 18.005 s] 2.361 s (15.1%)
profiling 15.358 s [15.358 s, 15.358 s] -286.0 ms (-1.8%)
tracing 15.022 s [15.022 s, 15.022 s] -622.0 ms (-4.0%)

@jpbempel
Fix Exception Probes to not emit any probe status
1c380db 
filter on probe definition type
@jpbempel jpbempel force-pushed the jpbempel/er-no-probe-status branch from 698665f to 1c380db Compare October 3, 2025 18:46
@jpbempel jpbempel requested a review from a team as a code owner October 6, 2025 07:23
@jpbempel jpbempel force-pushed the jpbempel/er-no-probe-status branch from 64e6575 to 7798aab Compare October 6, 2025 07:33
daniel-mohedano
daniel-mohedano requested changes Oct 6, 2025
View reviewed changes
dd-smoke-tests/maven/src/test/groovy/datadog/smoketest/MavenSmokeTest.groovy Outdated
def additionalDynamicTags = ["content.meta.['_dd.debug.error.3.snapshot_id']", "content.meta.['_dd.debug.error.exception_id']"]
verifyEventsAndCoverages(projectName, "maven", mavenVersion, mockBackend.waitForEvents(7), mockBackend.waitForCoverages(0), additionalDynamicTags)
verifySnapshotLogs(mockBackend.waitForLogs(5), 1, 2)
verifySnapshotLogs(mockBackend.waitForLogs(2), 0, 2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the CiVis smoke tests we checked for RECEIVED, INSTALLED, and EMITTING status from the probe (apart from the test snapshots). If none of these statuses are reported anymore, I think it's safe to change this call to just verifySnapshots(mockBackend.waitForLogs(2), 2), making the method protected in datadog.trace.civisibility.CiVisibilitySmokeTest. The call would need to be updated in datadog.smoketest.JUnitConsoleSmokeTest also

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jpbempel jpbempel merged commit 2c7da55 into master Oct 6, 2025
541 checks passed
@jpbempel jpbempel deleted the jpbempel/er-no-probe-status branch October 6, 2025 10:59
@github-actions github-actions bot added this to the 1.54.0 milestone Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanchooly evanchooly evanchooly approved these changes

@daniel-mohedano daniel-mohedano daniel-mohedano approved these changes

@shatzi shatzi Awaiting requested review from shatzi shatzi is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: enhancement Enhancements and improvements
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jpbempel @evanchooly @daniel-mohedano