-
Notifications
You must be signed in to change notification settings - Fork 312
Fix fallback ExecutionRequest creator in JUnit 5 instrumentation #9673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fallback ExecutionRequest creator in JUnit 5 instrumentation #9673
Conversation
🎯 Code Coverage 🔗 Commit SHA: 25f0d1b | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~25f0d1b712, baseline=1.54.0-SNAPSHOT~4386dc46f0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.033 s) : 0, 1032689
Total [baseline] (8.68 s) : 0, 8680205
Agent [candidate] (1.019 s) : 0, 1019188
Total [candidate] (8.644 s) : 0, 8644347
section iast
Agent [baseline] (1.158 s) : 0, 1158084
Total [baseline] (9.238 s) : 0, 9238177
Agent [candidate] (1.151 s) : 0, 1151489
Total [candidate] (9.281 s) : 0, 9281239
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~25f0d1b712, baseline=1.54.0-SNAPSHOT~4386dc46f0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (704.283 ms) : 0, 704283
BytebuddyAgent [candidate] (695.189 ms) : 0, 695189
GlobalTracer [baseline] (244.722 ms) : 0, 244722
GlobalTracer [candidate] (242.014 ms) : 0, 242014
AppSec [baseline] (33.509 ms) : 0, 33509
AppSec [candidate] (32.993 ms) : 0, 32993
Debugger [baseline] (6.542 ms) : 0, 6542
Debugger [candidate] (6.385 ms) : 0, 6385
Remote Config [baseline] (700.64 µs) : 0, 701
Remote Config [candidate] (682.339 µs) : 0, 682
Telemetry [baseline] (9.306 ms) : 0, 9306
Telemetry [candidate] (9.307 ms) : 0, 9307
Flare Poller [baseline] (10.986 ms) : 0, 10986
Flare Poller [candidate] (10.073 ms) : 0, 10073
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (820.569 ms) : 0, 820569
BytebuddyAgent [candidate] (814.894 ms) : 0, 814894
GlobalTracer [baseline] (233.273 ms) : 0, 233273
GlobalTracer [candidate] (232.135 ms) : 0, 232135
AppSec [baseline] (35.402 ms) : 0, 35402
AppSec [candidate] (35.459 ms) : 0, 35459
Debugger [baseline] (6.069 ms) : 0, 6069
Debugger [candidate] (6.079 ms) : 0, 6079
Remote Config [baseline] (600.072 µs) : 0, 600
Remote Config [candidate] (586.602 µs) : 0, 587
Telemetry [baseline] (8.446 ms) : 0, 8446
Telemetry [candidate] (8.42 ms) : 0, 8420
Flare Poller [baseline] (4.206 ms) : 0, 4206
Flare Poller [candidate] (4.202 ms) : 0, 4202
IAST [baseline] (26.882 ms) : 0, 26882
IAST [candidate] (26.893 ms) : 0, 26893
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~25f0d1b712, baseline=1.54.0-SNAPSHOT~4386dc46f0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017696
Total [baseline] (10.725 s) : 0, 10725464
Agent [candidate] (1.019 s) : 0, 1019382
Total [candidate] (10.71 s) : 0, 10710420
section appsec
Agent [baseline] (1.193 s) : 0, 1193239
Total [baseline] (11.016 s) : 0, 11015659
Agent [candidate] (1.202 s) : 0, 1202159
Total [candidate] (10.995 s) : 0, 10995006
section iast
Agent [baseline] (1.15 s) : 0, 1149729
Total [baseline] (10.919 s) : 0, 10919246
Agent [candidate] (1.164 s) : 0, 1164085
Total [candidate] (11.068 s) : 0, 11067694
section profiling
Agent [baseline] (1.162 s) : 0, 1162196
Total [baseline] (11.03 s) : 0, 11030315
Agent [candidate] (1.17 s) : 0, 1170300
Total [candidate] (11.069 s) : 0, 11068684
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~25f0d1b712, baseline=1.54.0-SNAPSHOT~4386dc46f0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (693.428 ms) : 0, 693428
BytebuddyAgent [candidate] (694.556 ms) : 0, 694556
GlobalTracer [baseline] (241.765 ms) : 0, 241765
GlobalTracer [candidate] (242.426 ms) : 0, 242426
AppSec [baseline] (32.939 ms) : 0, 32939
AppSec [candidate] (32.808 ms) : 0, 32808
Debugger [baseline] (6.411 ms) : 0, 6411
Debugger [candidate] (6.412 ms) : 0, 6412
Remote Config [baseline] (687.078 µs) : 0, 687
Remote Config [candidate] (684.642 µs) : 0, 685
Telemetry [baseline] (9.241 ms) : 0, 9241
Telemetry [candidate] (9.364 ms) : 0, 9364
Flare Poller [baseline] (10.684 ms) : 0, 10684
Flare Poller [candidate] (10.627 ms) : 0, 10627
section appsec
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.493 ms) : 0, 1493
BytebuddyAgent [baseline] (716.519 ms) : 0, 716519
BytebuddyAgent [candidate] (723.249 ms) : 0, 723249
GlobalTracer [baseline] (234.199 ms) : 0, 234199
GlobalTracer [candidate] (236.041 ms) : 0, 236041
AppSec [baseline] (174.975 ms) : 0, 174975
AppSec [candidate] (175.902 ms) : 0, 175902
Debugger [baseline] (6.172 ms) : 0, 6172
Debugger [candidate] (6.127 ms) : 0, 6127
Remote Config [baseline] (646.089 µs) : 0, 646
Remote Config [candidate] (642.678 µs) : 0, 643
Telemetry [baseline] (9.36 ms) : 0, 9360
Telemetry [candidate] (8.488 ms) : 0, 8488
Flare Poller [baseline] (3.962 ms) : 0, 3962
Flare Poller [candidate] (4.033 ms) : 0, 4033
IAST [baseline] (24.866 ms) : 0, 24866
IAST [candidate] (24.993 ms) : 0, 24993
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (813.973 ms) : 0, 813973
BytebuddyAgent [candidate] (823.181 ms) : 0, 823181
GlobalTracer [baseline] (231.912 ms) : 0, 231912
GlobalTracer [candidate] (235.579 ms) : 0, 235579
AppSec [baseline] (35.264 ms) : 0, 35264
AppSec [candidate] (35.636 ms) : 0, 35636
Debugger [baseline] (6.089 ms) : 0, 6089
Debugger [candidate] (6.134 ms) : 0, 6134
Remote Config [baseline] (607.465 µs) : 0, 607
Remote Config [candidate] (614.773 µs) : 0, 615
Telemetry [baseline] (8.392 ms) : 0, 8392
Telemetry [candidate] (8.591 ms) : 0, 8591
Flare Poller [baseline] (4.159 ms) : 0, 4159
Flare Poller [candidate] (4.25 ms) : 0, 4250
IAST [baseline] (26.645 ms) : 0, 26645
IAST [candidate] (27.396 ms) : 0, 27396
section profiling
crashtracking [baseline] (1.415 ms) : 0, 1415
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (721.975 ms) : 0, 721975
BytebuddyAgent [candidate] (726.457 ms) : 0, 726457
GlobalTracer [baseline] (217.909 ms) : 0, 217909
GlobalTracer [candidate] (219.697 ms) : 0, 219697
AppSec [baseline] (33.051 ms) : 0, 33051
AppSec [candidate] (33.298 ms) : 0, 33298
Debugger [baseline] (6.493 ms) : 0, 6493
Debugger [candidate] (7.319 ms) : 0, 7319
Remote Config [baseline] (692.679 µs) : 0, 693
Remote Config [candidate] (698.262 µs) : 0, 698
Telemetry [baseline] (16.597 ms) : 0, 16597
Telemetry [candidate] (15.894 ms) : 0, 15894
Flare Poller [baseline] (4.158 ms) : 0, 4158
Flare Poller [candidate] (4.22 ms) : 0, 4220
ProfilingAgent [baseline] (107.025 ms) : 0, 107025
ProfilingAgent [candidate] (108.105 ms) : 0, 108105
Profiling [baseline] (108.035 ms) : 0, 108035
Profiling [candidate] (108.98 ms) : 0, 108980
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~25f0d1b712, baseline=1.54.0-SNAPSHOT~4386dc46f0
dateFormat X
axisFormat %s
section baseline
no_agent (37.139 ms) : 36841, 37438
. : milestone, 37139,
appsec (49.312 ms) : 48881, 49743
. : milestone, 49312,
code_origins (43.652 ms) : 43288, 44015
. : milestone, 43652,
iast (45.057 ms) : 44665, 45450
. : milestone, 45057,
profiling (49.078 ms) : 48605, 49551
. : milestone, 49078,
tracing (44.104 ms) : 43730, 44477
. : milestone, 44104,
section candidate
no_agent (37.957 ms) : 37655, 38258
. : milestone, 37957,
appsec (50.009 ms) : 49551, 50467
. : milestone, 50009,
code_origins (43.443 ms) : 43076, 43810
. : milestone, 43443,
iast (45.443 ms) : 45064, 45822
. : milestone, 45443,
profiling (48.281 ms) : 47814, 48748
. : milestone, 48281,
tracing (45.834 ms) : 45448, 46220
. : milestone, 45834,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~25f0d1b712, baseline=1.54.0-SNAPSHOT~4386dc46f0
dateFormat X
axisFormat %s
section baseline
no_agent (4.419 ms) : 4369, 4470
. : milestone, 4419,
iast (10.335 ms) : 10155, 10515
. : milestone, 10335,
iast_FULL (14.677 ms) : 14384, 14970
. : milestone, 14677,
iast_GLOBAL (10.673 ms) : 10480, 10865
. : milestone, 10673,
profiling (8.839 ms) : 8699, 8978
. : milestone, 8839,
tracing (7.654 ms) : 7544, 7764
. : milestone, 7654,
section candidate
no_agent (4.267 ms) : 4217, 4317
. : milestone, 4267,
iast (10.38 ms) : 10198, 10562
. : milestone, 10380,
iast_FULL (14.382 ms) : 14099, 14665
. : milestone, 14382,
iast_GLOBAL (10.66 ms) : 10469, 10850
. : milestone, 10660,
profiling (8.733 ms) : 8598, 8869
. : milestone, 8733,
tracing (7.671 ms) : 7555, 7786
. : milestone, 7671,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~25f0d1b712, baseline=1.54.0-SNAPSHOT~4386dc46f0
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1497
. : milestone, 1486,
appsec (3.687 ms) : 3471, 3902
. : milestone, 3687,
iast (2.222 ms) : 2159, 2286
. : milestone, 2222,
iast_GLOBAL (2.266 ms) : 2202, 2330
. : milestone, 2266,
profiling (2.074 ms) : 2023, 2126
. : milestone, 2074,
tracing (2.038 ms) : 1988, 2087
. : milestone, 2038,
section candidate
no_agent (1.481 ms) : 1469, 1493
. : milestone, 1481,
appsec (3.726 ms) : 3508, 3944
. : milestone, 3726,
iast (2.206 ms) : 2143, 2269
. : milestone, 2206,
iast_GLOBAL (2.259 ms) : 2195, 2322
. : milestone, 2259,
profiling (2.064 ms) : 2014, 2115
. : milestone, 2064,
tracing (2.039 ms) : 1989, 2089
. : milestone, 2039,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~25f0d1b712, baseline=1.54.0-SNAPSHOT~4386dc46f0
dateFormat X
axisFormat %s
section baseline
no_agent (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
appsec (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
iast (18.826 s) : 18826000, 18826000
. : milestone, 18826000,
iast_GLOBAL (18.153 s) : 18153000, 18153000
. : milestone, 18153000,
profiling (15.115 s) : 15115000, 15115000
. : milestone, 15115000,
tracing (15.037 s) : 15037000, 15037000
. : milestone, 15037000,
section candidate
no_agent (15.333 s) : 15333000, 15333000
. : milestone, 15333000,
appsec (15.174 s) : 15174000, 15174000
. : milestone, 15174000,
iast (18.512 s) : 18512000, 18512000
. : milestone, 18512000,
iast_GLOBAL (18.003 s) : 18003000, 18003000
. : milestone, 18003000,
profiling (15.23 s) : 15230000, 15230000
. : milestone, 15230000,
tracing (15.264 s) : 15264000, 15264000
. : milestone, 15264000,
|
What Does This Do
ExecutionRequest
constructor instead of thecreate
method, as it is not available in the earlier versions of the framework.Motivation
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]