Skip to content

Commit 4a1ffff

Browse files
authored
chore: remove unused code (#6768)
This code is not used anymore and has no effect. Reintroducing it does not seem to be ideal. It is likely best to always name the services uniquely. Fixes: #6766
1 parent fe11901 commit 4a1ffff

File tree

4 files changed

+0
-9
lines changed

4 files changed

+0
-9
lines changed

docs/test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,6 @@ const elasticsearchOptions: plugins.elasticsearch = {
262262

263263
const awsSdkOptions: plugins.aws_sdk = {
264264
service: 'test',
265-
splitByAwsService: false,
266265
batchPropagationEnabled: false,
267266
hooks: {
268267
request: (span?: Span, response?) => {},

index.d.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1698,12 +1698,6 @@ declare namespace tracer {
16981698
* [aws-sdk](https://github.com/aws/aws-sdk-js) module.
16991699
*/
17001700
interface aws_sdk extends Instrumentation {
1701-
/**
1702-
* Whether to add a suffix to the service name so that each AWS service has its own service name.
1703-
* @default true
1704-
*/
1705-
splitByAwsService?: boolean;
1706-
17071701
/**
17081702
* Whether to inject all messages during batch AWS SQS, Kinesis, and SNS send operations. Normal
17091703
* behavior is to inject the first message in batch send operations.

packages/datadog-plugin-aws-sdk/src/base.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,6 @@ function normalizeConfig (config, serviceIdentifier) {
282282
return {
283283
...config,
284284
...specificConfig,
285-
splitByAwsService: config.splitByAwsService !== false,
286285
batchPropagationEnabled,
287286
hooks
288287
}

packages/datadog-plugin-aws-sdk/test/aws-sdk.spec.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,6 @@ describe('Plugin', () => {
254254
before(() => {
255255
return agent.load(['aws-sdk', 'http'], [{
256256
service: 'test',
257-
splitByAwsService: false,
258257
hooks: {
259258
request (span, response) {
260259
span.setTag('hook.operation', response.request.operation)

0 commit comments

Comments
 (0)