[test optimization] Do not report jest test suites as failed if a module import failed (#6924)

Author: juan-fernandez

integration-tests/jest/jest.spec.js

@@ -1055,31 +1055,32 @@ describe(`jest@${JEST_VERSION} commonJS`, () => {
           const suites = events.filter(event => event.type === 'test_suite_end')
           // this is not retried by the jest worker, so it's just 3 suites
           assert.equal(suites.length, 3)
-          const failedTestSuites = suites.filter(
+          const badImportTestSuites = suites.filter(
             suite => suite.content.meta[TEST_SUITE] ===
               'ci-visibility/jest-bad-import-torn-down/jest-bad-import-test.js'
           )
-          assert.equal(failedTestSuites.length, 1)
-          const [failedTestSuite] = failedTestSuites
+          assert.equal(badImportTestSuites.length, 1)
+          const [badImportTestSuite] = badImportTestSuites
 
-          assert.equal(failedTestSuite.content.meta[TEST_STATUS], 'fail')
+          // jest still reports the test suite as passing
+          assert.equal(badImportTestSuite.content.meta[TEST_STATUS], 'pass')
           assert.include(
-            failedTestSuite.content.meta[ERROR_MESSAGE],
+            badImportTestSuite.content.meta[ERROR_MESSAGE],
             'a file after the Jest environment has been torn down'
           )
           assert.include(
-            failedTestSuite.content.meta[ERROR_MESSAGE],
+            badImportTestSuite.content.meta[ERROR_MESSAGE],
             'From ci-visibility/jest-bad-import-torn-down/jest-bad-import-test.js'
           )
           // This is the error message that jest should show. We check that we don't mess it up.
-          assert.include(failedTestSuite.content.meta[ERROR_MESSAGE], 'off-timing-import')
-          assert.include(failedTestSuite.content.meta[ERROR_MESSAGE], 'afterAll')
-          assert.include(failedTestSuite.content.meta[ERROR_MESSAGE], 'nextTick')
+          assert.include(badImportTestSuite.content.meta[ERROR_MESSAGE], 'off-timing-import')
+          assert.include(badImportTestSuite.content.meta[ERROR_MESSAGE], 'afterAll')
+          assert.include(badImportTestSuite.content.meta[ERROR_MESSAGE], 'nextTick')
 
           const passedTestSuites = suites.filter(
             suite => suite.content.meta[TEST_STATUS] === 'pass'
           )
-          assert.equal(passedTestSuites.length, 2)
+          assert.equal(passedTestSuites.length, 3)
         })
 
       childProcess = exec(runTestsCommand, {

packages/datadog-plugin-jest/src/index.js

@@ -282,11 +282,7 @@ class JestPlugin extends CiPlugin {
         log.warn('"ci:jest:test-suite:finish": no span found for test suite absolute path %s', testSuiteAbsolutePath)
         return
       }
-      const hasStatus = testSuiteSpan.context()._tags[TEST_STATUS]
-      if (!hasStatus) {
-        // The status may have been set in 'ci:jest:test-suite:error'
-        testSuiteSpan.setTag(TEST_STATUS, status)
-      }
+      testSuiteSpan.setTag(TEST_STATUS, status)
       if (error) {
         testSuiteSpan.setTag('error', error)
         testSuiteSpan.setTag(TEST_STATUS, 'fail')
@@ -323,7 +319,6 @@ class JestPlugin extends CiPlugin {
       } else if (errorMessage) {
         runningTestSuiteSpan.setTag('error', new Error(errorMessage))
       }
-      runningTestSuiteSpan.setTag(TEST_STATUS, 'fail')
     })
 
     /**