Skip to content

Commit fe11901

Browse files
authored
fix: do not include peer dependencies of a dependency (#6760)
The dependency itself may list it as dependency and we can include the library in our devDependencies for testing purposes. Fixes: #6743
1 parent 53714a1 commit fe11901

File tree

3 files changed

+8
-27
lines changed

3 files changed

+8
-27
lines changed

package.json

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -158,25 +158,13 @@
158158
"tlhunter-sorted-set": "^0.1.0",
159159
"ttl-set": "^1.0.0"
160160
},
161-
"peerDependencies": {
162-
"@openfeature/core": "^1.9.0",
163-
"@openfeature/server-sdk": "~1.20.0"
164-
},
165-
"peerDependenciesMeta": {
166-
"@openfeature/core": {
167-
"optional": true
168-
},
169-
"@openfeature/server-sdk": {
170-
"optional": true
171-
}
172-
},
173161
"devDependencies": {
174162
"@babel/helpers": "^7.27.6",
175163
"@eslint/eslintrc": "^3.3.1",
176164
"@eslint/js": "^9.29.0",
177165
"@msgpack/msgpack": "^3.1.2",
178-
"@openfeature/core": "^1.8.1",
179-
"@openfeature/server-sdk": "~1.20.0",
166+
"@openfeature/core": "^1.9.0",
167+
"@openfeature/server-sdk": "^1.20.0",
180168
"@stylistic/eslint-plugin": "^5.0.0",
181169
"@types/chai": "^4.3.16",
182170
"@types/mocha": "^10.0.10",

packages/datadog-esbuild/index.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -113,13 +113,6 @@ module.exports.setup = function (build) {
113113
${build.initialOptions.banner.js}`
114114
}
115115

116-
try {
117-
require.resolve('@openfeature/core')
118-
} catch (error) {
119-
build.initialOptions.external ??= []
120-
build.initialOptions.external.push('@openfeature/core')
121-
}
122-
123116
const esmBuild = isESMBuild(build)
124117
if (esmBuild) {
125118
if (!build.initialOptions.banner.js.includes('import { createRequire as $dd_createRequire } from \'module\'')) {

yarn.lock

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -691,21 +691,21 @@
691691
"@octokit/request-error" "^7.0.0"
692692
"@octokit/webhooks-methods" "^6.0.0"
693693

694-
"@openfeature/core@^1.8.1":
694+
"@openfeature/core@^1.9.0":
695695
version "1.9.1"
696696
resolved "https://registry.yarnpkg.com/@openfeature/core/-/core-1.9.1.tgz#9925a04ed0745e92dd7b3793b35cff1ed89d54c1"
697697
integrity sha512-YySPtH4s/rKKnHRU0xyFGrqMU8XA+OIPNWDrlEFxE6DCVWCIrxE5YpiB94YD2jMFn6SSdA0cwQ8vLkCkl8lm8A==
698698

699+
"@openfeature/server-sdk@^1.20.0":
700+
version "1.20.0"
701+
resolved "https://registry.yarnpkg.com/@openfeature/server-sdk/-/server-sdk-1.20.0.tgz#43a5d3cffd915742ff64eeef53b7132279df4823"
702+
integrity sha512-95L9CCaGVKC6+7rNCmDxjthFvUyPLOUkoYyjg9Y/Cmy0G9D63xrJBsmH6fqHtLifzAu4+E7fWAZ3TIBnnCtr7A==
703+
699704
"@openfeature/server-sdk@~1.18.0":
700705
version "1.18.0"
701706
resolved "https://registry.yarnpkg.com/@openfeature/server-sdk/-/server-sdk-1.18.0.tgz#5fed5f1d0900b2535878db18a78295bbaebb997b"
702707
integrity sha512-uP8nqEGBS58s3iWXx6d8vnJ6ZVt3DACJL4PWADOAuwIS4xXpID91783e9f6zQ0i1ijQpj3yx+3ZuCB2LfQMUMA==
703708

704-
"@openfeature/server-sdk@~1.20.0":
705-
version "1.20.0"
706-
resolved "https://registry.yarnpkg.com/@openfeature/server-sdk/-/server-sdk-1.20.0.tgz#43a5d3cffd915742ff64eeef53b7132279df4823"
707-
integrity sha512-95L9CCaGVKC6+7rNCmDxjthFvUyPLOUkoYyjg9Y/Cmy0G9D63xrJBsmH6fqHtLifzAu4+E7fWAZ3TIBnnCtr7A==
708-
709709
"@opentelemetry/api-logs@<1.0.0":
710710
version "0.207.0"
711711
resolved "https://registry.yarnpkg.com/@opentelemetry/api-logs/-/api-logs-0.207.0.tgz#ae991c51eedda55af037a3e6fc1ebdb12b289f49"

0 commit comments

Comments
 (0)