Skip to content

Conversation

estherk15
Copy link
Contributor

@estherk15 estherk15 commented Oct 7, 2025

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

Do not merge Pending PM approval

@estherk15 estherk15 requested a review from a team as a code owner October 7, 2025 15:22
@github-actions github-actions bot added the Images Images are added/removed with this PR label Oct 7, 2025
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Preview links (active after the build_preview check completes)

New or renamed files

Copy link
Contributor

@git-thuerk-done git-thuerk-done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @estherk15 looks good just a few suggestions!

This feature supports logs archived through:

- [Datadog Log Management archives][1]
- [Observability Pipelines archives][2]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Observability Pipelines archives][2]
- [Observability Pipelines archives][2]

this links to https://docs.datadoghq.com/observability_pipelines/destinations/amazon_s3/, just want to ensure this is correct ?

Co-authored-by: Alicia Thuerk <26307719+git-thuerk-done@users.noreply.github.com>
Copy link
Contributor

@git-thuerk-done git-thuerk-done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, looks good! I had one last comment on this link but approved :)
#32032 (comment)


### Typical use cases

Archive Search is ideal when you need to query logs that are stored but not indexed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we say "Stored in External Archive" to make it clearer ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Archive Search is ideal when you need to query logs that are stored but not indexed.
Archive Search is ideal when you need to query logs that are stored in an external archive but not indexed.


To improve query performance and reduce scan volume:
- Narrow the time range and use selective filters.
- Filter on **indexed attributes** such as `transaction_id` or `user_id`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will not be available day 1 of the preview

(configuring indexed attribute and optimize search against it) - can we remove it for now? should come end of the quarter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Filter on **indexed attributes** such as `transaction_id` or `user_id`.


### Adding role delegation to S3 archives

Datadog only supports rehydrating from archives that have been configured to use role delegation to grant access. After you have modified your Datadog IAM role to include the IAM policy above, ensure that each archive in your [archive configuration page][3] has the correct AWS Account + Role combination.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename to "searching"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Datadog only supports rehydrating from archives that have been configured to use role delegation to grant access. After you have modified your Datadog IAM role to include the IAM policy above, ensure that each archive in your [archive configuration page][3] has the correct AWS Account + Role combination.
Datadog only supports searching from archives that have been configured to use role delegation to grant access. After you have modified your Datadog IAM role to include the IAM policy above, ensure that each archive in your [archive configuration page][3] has the correct AWS Account + Role combination.


## Cloud-specific permissions

Datadog requires the permission to read from your archives to rehydrate content from them. This permission can be changed at any time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to "searching"?


### Typical use cases

Archive Search is ideal when you need to query logs that are stored but not indexed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Archive Search is ideal when you need to query logs that are stored but not indexed.
Archive Search is ideal when you need to query logs that are stored in an external archive but not indexed.

From the **Archive Search list view**, you can:

- **Stop** a running search: preserves logs already retrieved.
- **Delete** a completed search: removes results and metadata.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Delete** a completed search: removes results and metadata.

- **Delete** a completed search: removes results and metadata.
- **Duplicate** a search: opens the Archive Search creation form with the same parameters for efficient reruns.

{{< img src="logs/archive_search/list_view.png" alt="Archive Search list view showing stop, delete, and duplicate options" style="width:90%;" >}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this image since delete is not going to be available as an option

Suggested change
{{< img src="logs/archive_search/list_view.png" alt="Archive Search list view showing stop, delete, and duplicate options" style="width:90%;" >}}


To improve query performance and reduce scan volume:
- Narrow the time range and use selective filters.
- Filter on **indexed attributes** such as `transaction_id` or `user_id`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Filter on **indexed attributes** such as `transaction_id` or `user_id`.


## Cloud-specific permissions

Datadog requires the permission to read from your archives to rehydrate content from them. This permission can be changed at any time.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Datadog requires the permission to read from your archives to rehydrate content from them. This permission can be changed at any time.
Datadog requires the permission to read your archives to search content from them. This permission can be changed at any time.


### Adding role delegation to S3 archives

Datadog only supports rehydrating from archives that have been configured to use role delegation to grant access. After you have modified your Datadog IAM role to include the IAM policy above, ensure that each archive in your [archive configuration page][3] has the correct AWS Account + Role combination.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Datadog only supports rehydrating from archives that have been configured to use role delegation to grant access. After you have modified your Datadog IAM role to include the IAM policy above, ensure that each archive in your [archive configuration page][3] has the correct AWS Account + Role combination.
Datadog only supports searching from archives that have been configured to use role delegation to grant access. After you have modified your Datadog IAM role to include the IAM policy above, ensure that each archive in your [archive configuration page][3] has the correct AWS Account + Role combination.


{{% tab "Azure Storage" %}}

Datadog uses an Azure AD group with the Storage Blob Data Contributor role scoped to your archives' storage account to rehydrate log events. You can grant this role to your Datadog service account from your storage account's Access Control (IAM) page by [assigning the Storage Blob Data Contributor role to your Datadog integration app][1].
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Datadog uses an Azure AD group with the Storage Blob Data Contributor role scoped to your archives' storage account to rehydrate log events. You can grant this role to your Datadog service account from your storage account's Access Control (IAM) page by [assigning the Storage Blob Data Contributor role to your Datadog integration app][1].
Datadog uses an Azure AD group with the Storage Blob Data Contributor role scoped to your archives' storage account to search log events. You can grant this role to your Datadog service account from your storage account's Access Control (IAM) page by [assigning the Storage Blob Data Contributor role to your Datadog integration app][1].


{{% tab "Google Cloud Storage" %}}

In order to rehydrate log events from your archives, Datadog uses a service account with the Storage Object Viewer role. You can grant this role to your Datadog service account from the [Google Cloud IAM Admin page][1] by editing the service account's permissions, adding another role, and then selecting **Storage > Storage Object Viewer**.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In order to rehydrate log events from your archives, Datadog uses a service account with the Storage Object Viewer role. You can grant this role to your Datadog service account from the [Google Cloud IAM Admin page][1] by editing the service account's permissions, adding another role, and then selecting **Storage > Storage Object Viewer**.
In order to search log events from your archives, Datadog uses a service account with the Storage Object Viewer role. You can grant this role to your Datadog service account from the [Google Cloud IAM Admin page][1] by editing the service account's permissions, adding another role, and then selecting **Storage > Storage Object Viewer**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants