Skip to content

Fix env var setting #32039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
Merged

Fix env var setting #32039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7a97d0
feat: fix vuln branch setting
devindford Oct 7, 2025
739b0fa
Merge branch 'master' into devin.ford/update-vuln
devindford Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/gif_check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@ jobs:
# Branch Name Validation to be run prior to workflow
- name: Validate branch name and set output
id: validate
env:
BRANCH: ${{ github.head_ref }}
run: |
BRANCH="${{ github.head_ref }}"
BRANCH="${{ env.BRANCH }}"
# Allow: letters, numbers, dots, hyphens, underscores, and forward slash
# This supports the required <name>/<description> format like "user.name/test-this-new-feature"
if [[ "$BRANCH" =~ ^[a-zA-Z0-9._/-]+$ ]] && [[ ${#BRANCH} -le 200 ]]; then
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/preview_link.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,10 @@ jobs:
# Branch Name Validation to be run prior to workflow
- name: Validate branch name and set output
id: validate
env:
BRANCH: ${{ github.head_ref }}
run: |
BRANCH="${{ github.head_ref }}"
BRANCH="${{ env.BRANCH }}"
# Allow: letters, numbers, dots, hyphens, underscores, and forward slash
# This supports the required <name>/<description> format like "user.name/test-this-new-feature"
if [[ "$BRANCH" =~ ^[a-zA-Z0-9._/-]+$ ]] && [[ ${#BRANCH} -le 200 ]] && [[ "$BRANCH" == *"/"* ]]; then
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/synthetics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@ jobs:
# Branch Name Validation to be run prior to workflow
- name: Validate branch name and set output
id: validate
env:
BRANCH: ${{ github.event.pull_request.head.ref }}
run: |
BRANCH="${{ github.event.pull_request.head.ref }}"
BRANCH="${{ env.BRANCH }}"
# Allow: letters, numbers, dots, hyphens, underscores, and forward slash
# This supports the required <name>/<description> format like "user.name/test-this-new-feature"
if [[ "$BRANCH" =~ ^[a-zA-Z0-9._/-]+$ ]] && [[ ${#BRANCH} -le 200 ]]; then
Expand All @@ -42,9 +44,11 @@ jobs:
- name: Check preview status
id: check-status
if: steps.validate.outputs.valid == 'true'
env:
BRANCH: ${{ steps.validate.outputs.branch }}
run: |
# Use the validated branch name from previous step
BRANCH="${{ steps.validate.outputs.branch }}"
BRANCH="${{ env.BRANCH }}"
URL="https://docs-staging.datadoghq.com/${BRANCH}"
SUCCESS_CODES=("200" "302" "304")
for i in {1..30}
Expand Down
Loading