Skip to content

Commit 905570e

Browse files
committed
Reusable workflows' improvements
1 parent b0601be commit 905570e

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

.github/workflows/reusable-storage-dependant-tests.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ on:
1616
target_framework:
1717
description: 'Target framework'
1818
required: true
19-
default: 'net6.0'
19+
default: 'netcoreapp2.0'
2020
type: string
2121
specific_sha:
2222
description: 'Commit SHA to checkout'
@@ -171,10 +171,9 @@ jobs:
171171

172172
- name: Make Final Test report
173173
if: |
174-
(github.event_name == 'push' && (steps.reprocessing.outcome != 'cancelled' && steps.complex_tests.outcome != 'cancelled'))
175-
|| (github.event_name == 'pull_request' && (steps.reprocessing.outcome != 'cancelled' && steps.complex_tests.outcome != 'cancelled'))
176-
|| (github.event_name == 'workflow_dispatch' && (steps.reprocessing.outcome != 'cancelled' && steps.complex_tests.outcome != 'cancelled'))
177-
|| (steps.reprocessing.outcome == 'failure' || steps.complex_tests.outcome == 'failure')
174+
!cancelled()
175+
&& ((github.event_name == 'push') || (github.event_name == 'pull_request') || (github.event_name == 'workflow_dispatch')
176+
|| (steps.reprocessing.outcome == 'failure' || steps.complex_tests.outcome == 'failure'))
178177
timeout-minutes: 1
179178
uses: dorny/test-reporter@v2.1.1
180179
with:

.github/workflows/reusable-storage-independant-tests.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ on:
1111
target_framework:
1212
description: 'Target framework'
1313
required: true
14-
default: 'net6.0'
14+
default: 'netcoreapp2.0'
1515
type: string
1616
test_output_verbosity:
1717
description: 'Verbosity for dotnet test command'
@@ -122,10 +122,9 @@ jobs:
122122

123123
- name: Make Final Test report
124124
if: |
125-
(github.event_name == 'push' && steps.complex_tests.outcome != 'cancelled')
126-
|| (github.event_name == 'pull_request' && steps.complex_tests.outcome != 'cancelled')
127-
|| (github.event_name == 'workflow_dispatch' && steps.complex_tests.outcome != 'cancelled')
128-
|| steps.complex_tests.outcome == 'failure'
125+
!cancelled()
126+
&& ((github.event_name == 'push') || (github.event_name == 'pull_request') || (github.event_name == 'workflow_dispatch')
127+
|| (steps.reprocessing.outcome == 'failure' || steps.complex_tests.outcome == 'failure'))
129128
timeout-minutes: 1
130129
uses: dorny/test-reporter@v2.1.1
131130
with:

0 commit comments

Comments
 (0)