Skip to content

fix: set reason detail as 'Error' on 404 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2025
Merged

fix: set reason detail as 'Error' on 404 #97

merged 2 commits into from
Jul 30, 2025

Conversation

phaym
Copy link
Contributor

@phaym phaym commented Jul 30, 2025 •
edited
Loading

404 can be received from cloud bucketing in two cases: when user isn't bucketed or when the variable doesn't exist.

  • Return error as detail instead of specifying missing variable.
  • remove capability overrides for test-harness

@phaym phaym changed the title fix: cloud bucketing set reason detail as error on 404 fix: set reason detail as 'Error' on 404 Jul 30, 2025
@phaym phaym marked this pull request as ready for review July 30, 2025 14:57
@phaym phaym requested a review from a team as a code owner July 30, 2025 14:57
@phaym phaym merged commit 4486168 into main Jul 30, 2025
14 of 15 checks passed
@phaym phaym deleted the fix/detail-for-404 branch July 30, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsalaber jsalaber jsalaber approved these changes

@kaushalkapasi kaushalkapasi kaushalkapasi approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phaym @jsalaber @kaushalkapasi