Skip to content

fix: set reason detail as 'Error' on 404 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025
Merged

fix: set reason detail as 'Error' on 404 #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3ff194
report generic error for reason detail when 404
phaym Jul 30, 2025
5bbb8ae
remove override capabilities
phaym Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/run-test-harness.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,3 @@ jobs:
with:
sdks-to-test: python
sdk-github-sha: ${{github.event.pull_request.head.sha}}
sdk-capabilities: '["cloud", "edgeDB", "clientCustomData","v2Config", "allVariables", "allFeatures", "evalReason", "cloudEvalReason", "eventsEvalReason"]'
2 changes: 1 addition & 1 deletion devcycle_python_sdk/cloud_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def variable(self, user: DevCycleUser, key: str, default_value: Any) -> Variable
return Variable.create_default_variable(
key=key,
default_value=default_value,
default_reason_detail=DefaultReasonDetails.MISSING_VARIABLE,
default_reason_detail=DefaultReasonDetails.ERROR,
)
except BeforeHookError as e:
self.eval_hooks_manager.run_error(context, e)
Expand Down
1 change: 0 additions & 1 deletion devcycle_python_sdk/models/eval_reason.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ class DefaultReasonDetails:
MISSING_CONFIG = "Missing Config"
USER_NOT_TARGETED = "User Not Targeted"
TYPE_MISMATCH = "Variable Type Mismatch"
MISSING_VARIABLE = "Missing Variable"
ERROR = "Error"


Expand Down
2 changes: 1 addition & 1 deletion test/test_cloud_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def test_variable_exceptions(self, mock_variable_call):
self.assertEqual(result.value, "default_value")
self.assertTrue(result.isDefaulted)
self.assertEqual(result.eval.reason, "DEFAULT")
self.assertEqual(result.eval.details, "Missing Variable")
self.assertEqual(result.eval.details, "Error")

# other exception - return default
mock_variable_call.reset_mock()
Expand Down
Loading