coderabbit optimization

Author: maparent

packages/database/supabase/migrations/20250616212706_generate-arity.sql

@@ -1,21 +1,17 @@
-ALTER TABLE "public"."Concept" DROP COLUMN "arity";
-
-ALTER TABLE "public"."Concept" ADD COLUMN "arity" smallint GENERATED ALWAYS AS (compute_arity_local(schema_id, literal_content)) STORED;
-
 CREATE OR REPLACE FUNCTION public.compute_arity_id(p_schema_id bigint)
 RETURNS smallint
 LANGUAGE sql
 IMMUTABLE
 AS $function$
-  WITH q AS (SELECT jsonb_path_query(literal_content, '$.roles[*]') FROM public."Concept" WHERE id=p_schema_id) SELECT count(*) FROM q;
+  SELECT COALESCE(jsonb_array_length(literal_content->'roles'), 0) FROM public."Concept" WHERE id=p_schema_id;
 $function$;
 
 CREATE OR REPLACE FUNCTION public.compute_arity_lit(lit_content jsonb)
 RETURNS smallint
 LANGUAGE sql
 IMMUTABLE
 AS $function$
-  WITH q AS (SELECT jsonb_path_query(lit_content, '$.roles[*]')) SELECT count(*) FROM q;
+  SELECT COALESCE(jsonb_array_length(lit_content->'roles'), 0);
 $function$;
 
 CREATE OR REPLACE FUNCTION public.compute_arity_local(schema_id bigint, lit_content jsonb)
@@ -26,6 +22,10 @@ AS $function$
   SELECT CASE WHEN schema_id IS NULL THEN compute_arity_lit(lit_content) ELSE compute_arity_id(schema_id) END;
 $function$;
 
+ALTER TABLE "public"."Concept" DROP COLUMN "arity";
+
+ALTER TABLE "public"."Concept" ADD COLUMN "arity" smallint GENERATED ALWAYS AS (compute_arity_local(schema_id, literal_content)) STORED;
+
 CREATE OR REPLACE FUNCTION public.extract_references(refs jsonb)
 RETURNS bigint []
 LANGUAGE sql

packages/database/supabase/schemas/concept.sql

@@ -17,12 +17,12 @@ CREATE OR REPLACE FUNCTION extract_references(refs JSONB) RETURNS BIGINT [] LANG
 $$;
 
 CREATE OR REPLACE FUNCTION compute_arity_lit(lit_content JSONB) RETURNS smallint language sql IMMUTABLE AS $$
-  WITH q AS (SELECT jsonb_path_query(lit_content, '$.roles[*]')) SELECT count(*) FROM q;
+  SELECT COALESCE(jsonb_array_length(lit_content->'roles'), 0);
 $$;
 
 SET check_function_bodies = false;
 CREATE OR REPLACE FUNCTION compute_arity_id(p_schema_id BIGINT) RETURNS smallint language sql IMMUTABLE AS $$
-  WITH q AS (SELECT jsonb_path_query(literal_content, '$.roles[*]') FROM public."Concept" WHERE id=p_schema_id) SELECT count(*) FROM q;
+  SELECT COALESCE(jsonb_array_length(literal_content->'roles'), 0) FROM public."Concept" WHERE id=p_schema_id;
 $$;
 SET check_function_bodies = true;