Fix/spidermonkey-build: SpiderMonkey build system breaks on Python 3.11 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…longer accepts 'U' in the file mode
|
see also: |
|
https://github.com/Distributive-Network/PythonMonkey/actions/runs/5084446135/jobs/9136751622 doesn't fail because it uses a cached SpiderMonkey built with Python 3.10 |
Hamada-Distributed
approved these changes
May 28, 2023
wesgarland
reviewed
May 28, 2023
| echo "Building spidermonkey" | ||
| cd firefox-102.2.0/python/mozbuild/mozbuild | ||
| # the build system breaks on Python 3.11 (`io.open()` no longer accepts 'U' in the file mode) | ||
| sed -i 's/"rU"/"r"/g' util.py preprocessor.py action/process_define_files.py backend/base.py |
There was a problem hiding this comment.
This is awfully broad: you're better off with a tighter expression like
sed -i 's/\(io\.open(\)\([^,]*,\)\( *["']rU['"] *\)/\1\2 "r"/g'
wesgarland
reviewed
May 28, 2023
| sed -i 's/"rU"/"r"/g' util.py preprocessor.py action/process_define_files.py backend/base.py | ||
| cd - | ||
| cd firefox-102.2.0/js | ||
| sed -i 's/bool Unbox/JS_PUBLIC_API bool Unbox/g' ./public/Class.h # need to manually add JS_PUBLIC_API to js::Unbox until it gets fixed in Spidermonkey |
There was a problem hiding this comment.
Has a bug been filed with Mozilla? It should have been. A link to the bug should be in a comment here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Distributive-Network/PythonMonkey/actions/runs/5084218550/jobs/9136227002#step:6:1102
https://docs.python.org/3/whatsnew/3.11.html#porting-to-python-3-11