Skip to content

Fix/spidermonkey-build: SpiderMonkey build system breaks on Python 3.11 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2023
Merged

Fix/spidermonkey-build: SpiderMonkey build system breaks on Python 3.11 #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
825c48c
chore: the build system breaks on Python 3.11 because `io.open()` no …
Xmader May 25, 2023
330eb4e
chore: fix the SpiderMonkey build system on Python 3.11
Xmader May 25, 2023
9f9080c
ci: do not fail-fast (cancel all in-progress jobs) if any matrix job …
Xmader May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:
jobs:
test-suite:
strategy:
fail-fast: false
matrix:
os: [ 'ubuntu-latest' ] # , 'windows-latest', 'macos-latest' ]
python_version: [ '3.9', '3.10', '3.11' ]
Expand Down
4 changes: 4 additions & 0 deletions setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ tar xf firefox-102.2.0esr.source.tar.xz
echo "Done downloading spidermonkey source code"

echo "Building spidermonkey"
cd firefox-102.2.0/python/mozbuild/mozbuild
# the build system breaks on Python 3.11 (`io.open()` no longer accepts 'U' in the file mode)
sed -i 's/"rU"/"r"/g' util.py preprocessor.py action/process_define_files.py backend/base.py
Copy link
Collaborator

@wesgarland wesgarland May 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awfully broad: you're better off with a tighter expression like
sed -i 's/\(io\.open(\)\([^,]*,\)\( *["']rU['"] *\)/\1\2 "r"/g'

cd -
cd firefox-102.2.0/js
sed -i 's/bool Unbox/JS_PUBLIC_API bool Unbox/g' ./public/Class.h # need to manually add JS_PUBLIC_API to js::Unbox until it gets fixed in Spidermonkey
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has a bug been filed with Mozilla? It should have been. A link to the bug should be in a comment here.

sed -i 's/bool js::Unbox/JS_PUBLIC_API bool js::Unbox/g' ./src/vm/JSObject.cpp # same here
Expand Down