Skip to content

Conversation

SvenKlaassen
Copy link
Member

  • Added DIDCSMultiCoverageSimulation to montecover
  • Updated did section with corresponding qmd file
  • minor fixes

@SvenKlaassen SvenKlaassen requested a review from Copilot June 13, 2025 07:09
@SvenKlaassen SvenKlaassen marked this pull request as ready for review June 13, 2025 07:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new cross-sectional DiD simulation (DIDCSMultiCoverageSimulation) spanning multiple periods, integrates its results and config into the repository, and updates documentation and CI workflows to support it.

  • Introduce DIDCSMultiCoverageSimulation class and export in montecover.did
  • Add new result files, config, and metadata for the cross-sectional multi-period simulation
  • Update documentation (.qmd) and CI (did_sim.yml) to include the new simulation

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
monte-cover/src/montecover/did/did_cs_multi.py New simulation class for cross-sectional multi-period coverage
monte-cover/src/montecover/did/init.py Exported the new DIDCSMultiCoverageSimulation
results/did/did_cs_multi_*.csv & .yml Added new result, metadata, and config files
doc/did/did_cs_multi.qmd & doc/_website.yml Added documentation pages and navigation entries
.github/workflows/did_sim.yml Included scripts/did/did_cs_multi.py in workflow
Comments suppressed due to low confidence (1)

results/did/did_pa_multi_config.yml:2

  • There are two repetitions entries under simulation_parameters (1000 and 500), which can cause YAML parsing conflicts or unintended overrides. Remove or consolidate the duplicate key.
repetitions: 500

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SvenKlaassen SvenKlaassen merged commit 4989b28 into dev Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant