fix: prevent 'cd ..' from moving above root directory #36
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanjadiya1102
added
bug
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the CdCommand to prevent users from navigating above the root directory when using cd .., improving shell reliability and user experience.
- Adds root directory boundary checking to prevent navigation above filesystem root
- Implements special handling for
cd ..command with clear user feedback - Includes workaround for
cd..(without space) command parsing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@Harushii16, Please view above suggestions given by Copilot. |
|
I have resolved the copilot suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary #35
This PR improves the
CdCommandin MyCMD to prevent users from navigating above the root directory. Now, when users executecd ..at the root, the shell correctly prevents moving further up and shows a clear message.Changes
Notes
cd ..(with space).cd..(without space) is not affected because the shell does not parse it separately. Supporting it would require changes to the core input parser.Motivation
Currently, executing
cd ..at the root directory could cause unexpected behavior. This fix ensures the shell behaves reliably, preventing potential user errors and improving usability.Hacktoberfest 2025
This contribution is submitted as part of Hacktoberfest 2025. 🎉
Excited to contribute and improve open-source software!