Skip to content

fix: prevent 'cd ..' from moving above root directory #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −3
Open

fix: prevent 'cd ..' from moving above root directory #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6912e1
fix: prevent 'cd ..' from moving above root directory
Harushii16 Oct 13, 2025
b363c9a
fix: clean up CdCommand logic and remove redundant code
Harushii16 Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/main/java/com/mycmd/commands/CdCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,31 @@
public class CdCommand implements Command {
@Override
public void execute(String[] args, ShellContext context) {
// If no argument, print current directory
if (args.length == 0) {
System.out.println(context.getCurrentDir().getAbsolutePath());
return;
}
File newDir = new File(args[0]);
if (!newDir.isAbsolute()) {
newDir = new File(context.getCurrentDir(), args[0]);

String dir = args[0];
File newDir;

// Handle "cd .." (go to parent directory)
if (dir.equals("..")) {
File parent = context.getCurrentDir().getParentFile();
if (parent == null) {
System.out.println("Already at the root directory.");
return;
}
newDir = parent;
} else {
newDir = new File(dir);
if (!newDir.isAbsolute()) {
newDir = new File(context.getCurrentDir(), dir);
}
}

// Change directory if valid
if (newDir.exists() && newDir.isDirectory()) {
context.setCurrentDir(newDir);
} else {
Expand Down