Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataManagementSetup implementation should be independent #24

Open
mpostol opened this issue Aug 14, 2020 · 2 comments
Open

DataManagementSetup implementation should be independent #24

mpostol opened this issue Aug 14, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mpostol
Copy link
Collaborator

mpostol commented Aug 14, 2020

From the description, I can guess that the project provides two independent implementations of the DataRepository, According to the ReferenceApplication example and the architecture presented in https://commsvr.gitbook.io/ooi/reactive-communication/semanticdata#reactive-networking-application-architecture both need independent implementation of the DataManagementSetup. It promotes separation of concerns and reusability. Unfortunately, I can find only one implementation of this class, namely NetworkEventsManager.

It must be recognized as a data error, so some comments are required.

@mpostol mpostol added the bug Something isn't working label Aug 14, 2020
@Drutol
Copy link
Owner

Drutol commented Aug 24, 2020

That's true, I acknowledge that it should be separate, yet I have run into a bit of trouble which I have described here: mpostol/OPC-UA-OOI#468

@mpostol
Copy link
Collaborator Author

mpostol commented Sep 14, 2020

Not sure if adding abstract may be recognized as a real relief. Anyway, it is done. I have also improved documentation in this respect.

@mpostol mpostol removed their assignment Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants