-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PackagePaths as Parameter of ExecutionSession #10836
Conversation
add test add data when execute session is created
all tests pass on self serve, but parallel has a concurrency issue with file deletion - will take a look. |
I ran the parallel self serve again and all passed - so I think this is good to review now: |
@@ -69,5 +69,11 @@ public class ParameterKeys | |||
/// The duration of an execution covered by an <see cref="IExecutionSession"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make this class static as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but I think that would sadly break the API. Do you prefer I obsolete this class, create a static version and use that one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or just risk the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a TODO to add it later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added and task created.
Purpose
Try to address DynamoDS/DynamoWishlist#71
Declarations
Check these if you believe they are true
*.resx
files