Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PackagePaths as Parameter of ExecutionSession #10836

Merged
merged 4 commits into from
Jul 6, 2020

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Jul 1, 2020

Purpose

Try to address DynamoDS/DynamoWishlist#71

  • add parameter key for packagePaths
  • add parameter
  • add test
  • add python test asserting we can reference and use this parameter.

Screen Shot 2020-07-01 at 1 20 38 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

add test
add data when execute session is created
@mjkkirschner
Copy link
Member Author

mjkkirschner commented Jul 1, 2020

all tests pass on self serve, but parallel has a concurrency issue with file deletion - will take a look.

@mjkkirschner
Copy link
Member Author

I ran the parallel self serve again and all passed - so I think this is good to review now:
https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/837

@mjkkirschner mjkkirschner added the PTAL Please Take A Look 👀 label Jul 1, 2020
@@ -69,5 +69,11 @@ public class ParameterKeys
/// The duration of an execution covered by an <see cref="IExecutionSession"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make this class static as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I think that would sadly break the API. Do you prefer I obsolete this class, create a static version and use that one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or just risk the change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a TODO to add it later?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, will do.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added and task created.

@mjkkirschner mjkkirschner merged commit 9d0001a into DynamoDS:master Jul 6, 2020
@mjkkirschner mjkkirschner deleted the packageLocAPI branch July 6, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PTAL Please Take A Look 👀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants