Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#1569 AArch64: Follow-up to 428b896: Use opndset for ADR and ADRP. #2516

Merged
merged 2 commits into from
Jul 10, 2017

Conversation

egrimley
Copy link
Contributor

This is neater than hacking the potentially general-purpose formalism
to treat "adr" and "adrp" differently and is also more consistent with
how branch instructions are handled.

Change-Id: I085cf7627dd7d165816b7163ed53498c5c53153a

This is neater than hacking the potentially general-purpose formalism
to treat "adr" and "adrp" differently and is also more consistent with
how branch instructions are handled.

Change-Id: I085cf7627dd7d165816b7163ed53498c5c53153a
@egrimley egrimley requested a review from fhahn July 10, 2017 11:30
Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming encode_opnd_adr_page checks the argument type.

@fhahn
Copy link
Contributor

fhahn commented Jul 10, 2017

Can one of the admins verify this patch?

@egrimley egrimley merged commit aec4977 into master Jul 10, 2017
@egrimley egrimley deleted the i1569-opnds-adrp branch July 10, 2017 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants