Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#224 #226

Closed
wants to merge 8 commits into from
Closed

#224 #226

wants to merge 8 commits into from

Conversation

seasoftjapan
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Aug 18, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 22.435% when pulling 964b24d on seasoftjapan:#224 into 212fb1f on EC-CUBE:improve/php7.

@okazy okazy added this to the 2.17.0 milestone Aug 23, 2018
@nobuhiko nobuhiko requested review from nobuhiko and removed request for nobuhiko September 11, 2018 13:30
@nobuhiko
Copy link
Contributor

このプルリクはダメです。

@seasoftjapan
Copy link
Contributor Author

このPRは削除して、新たにPR立てる予定です。

が、削除の方法が分からん。。。

ブランチ消せばよいのか。
https://qiita.com/Yorinton/items/adf1ebf922c26ddb26a0

試してみよう。

@nobuhiko nobuhiko closed this Sep 11, 2018
@seasoftjapan
Copy link
Contributor Author

@nobuhiko 何やらクローズいただいたようで、ありがとうございます。仕組みを理解できていませんが、ブランチを消さずとも、再度 PR できました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@seasoftjapan @coveralls @nobuhiko @okazy @ryo-endo