Skip to content

Commit c8f0094

Browse files
authored
Merge pull request #132 from bedroge/remove_gromacs_sve_workaround
Remove workaround/hook for GROMACS SVE issue
2 parents 710b8fd + 71ba332 commit c8f0094

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

eb_hooks.py

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -885,27 +885,6 @@ def pre_configure_hook_gobject_introspection(self, *args, **kwargs):
885885
raise EasyBuildError("GObject-Introspection-specific hook triggered for non-GObject-Introspection easyconfig?!")
886886

887887

888-
def pre_configure_hook_gromacs(self, *args, **kwargs):
889-
"""
890-
Pre-configure hook for GROMACS:
891-
- avoid building with SVE instructions on Neoverse V1 as workaround for failing tests,
892-
see https://gitlab.com/gromacs/gromacs/-/issues/5057 + https://gitlab.com/eessi/support/-/issues/47
893-
"""
894-
if self.name == 'GROMACS':
895-
cpu_target = get_eessi_envvar('EESSI_SOFTWARE_SUBDIR')
896-
if (
897-
(LooseVersion(self.version) <= LooseVersion('2024.1') and cpu_target == CPU_TARGET_NEOVERSE_V1) or
898-
(LooseVersion(self.version) <= LooseVersion('2024.4') and cpu_target == CPU_TARGET_NVIDIA_GRACE)
899-
):
900-
self.cfg.update('configopts', '-DGMX_SIMD=ARM_NEON_ASIMD')
901-
print_msg(
902-
"Avoiding use of SVE instructions for GROMACS %s by using ARM_NEON_ASIMD as GMX_SIMD value",
903-
self.version
904-
)
905-
else:
906-
raise EasyBuildError("GROMACS-specific hook triggered for non-GROMACS easyconfig?!")
907-
908-
909888
def pre_configure_hook_llvm(self, *args, **kwargs):
910889
"""Adjust internal configure options for the LLVM EasyBlock to reinstate filtered out dependencies.
911890
In the LLVM EasyBlock, most checks concerning loaded modules are performed at the configure_step.
@@ -1649,7 +1628,6 @@ def post_easyblock_hook(self, *args, **kwargs):
16491628
'GObject-Introspection': pre_configure_hook_gobject_introspection,
16501629
'Extrae': pre_configure_hook_extrae,
16511630
'GRASS': pre_configure_hook_grass,
1652-
'GROMACS': pre_configure_hook_gromacs,
16531631
'libfabric': pre_configure_hook_libfabric_disable_psm3_x86_64_generic,
16541632
'LLVM': pre_configure_hook_llvm,
16551633
'ROCm-LLVM': pre_configure_hook_llvm,

0 commit comments

Comments
 (0)