Fix tarball naming for CPU-only tarballs #65
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:zen2 |
|
New job on instance
|
|
New job on instance
|
boegel
requested changes
Aug 19, 2025
boegel
reviewed
Aug 19, 2025
| raise ValueError(f"Invalid environment variable name: {var_name}") | ||
| list_string = os.getenv(var_name, '[]') | ||
|
|
There was a problem hiding this comment.
I guess this is just so there's something to include in generated tarball?
There was a problem hiding this comment.
Yes, remove any changes to eb_hooks.py after testing...
Also, this removal of whitespace is some vim feature that @smoors recommended to me, I think XD
There was a problem hiding this comment.
(there's a reason I opened the PR in draft mode ;-) I'll put it on ready to review after removing this)
|
Closing in favor of #67 |
boegel
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When introducing the new tarball naming to make sure tarball names were unique per GPU architecture, I did not realize that
${EESSI_ACCELERATOR_TARGET_OVERRIDE//\//-}would simply be completely empty for a CPU build, and thus the string formatting would be short on value. This caused tarball names to be incorrect, as they ended with-0.tar.gz, see e.g. https://github.com/EESSI/staging_bundles/pull/9 . That's problematic, since the bot assumes the item after the last-to be the timestamp. So, with the policy to only upload the last tarball every tarball would be uploaded, since all had identical timestamp (0) according to the bot.Fixed in this PR by making the number of formatting specs conditional on the accelerator override being non-empty.