-
Notifications
You must be signed in to change notification settings - Fork 13
fix condition in EESSI-extend so environment variable to configure EasyBuild 5.1+ are only defined when EasyBuild >= 5.1 is used #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This will probably fail, as I don't think the new bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:zen2 |
New job on instance
|
…I#54. This will make sure the rebuild of EESSI-extend is done before building the CUDA in host-injections. That's essentially, as the fix in EESSI-extend is needed to make the CUDA in host-injections step pass
Indeed
Changed the order back to what it was prior to #54 |
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:zen2 |
New job on instance
|
Still the same failure. Either the updated EESSI-extend isn't properly used (module caching?) or the fix just doens't work. |
Interactively, the fix seems to work, which makes me suspect module caching. We can do two things:
|
Hm, it is ignoring cache (or should be, at least):
|
I'll start placing echo's, see where things go wrong... |
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:zen2 |
New job on instance
|
Well that is stupid:
It does not get unset, and the reason is that the version-check isn't satisfied! I.e. because we first swap to a different EasyBuild and then do the unload, the env vars don't get unset. Should we do the unset unconditionally upon unload? I'm not sure... this may lead to other weird behavior. Maybe:
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:zen2 |
New job on instance
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:zen2 |
New job on instance
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:zen2 |
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
bot: build repo:eessi.io-2025.06-software instance:eessi-bot-mc-aws arch:zen2 |
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closing in favor of #67 |
edit: also reverting change of when
install_cuda_and_libraries
andlink_nvidia_host_libraries.sh
are called, that was changed in #54 but wasn't correct