This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Chrome build likely broken #2220
Assignees
Comments
jsha
added a commit
that referenced
this issue
Jul 14, 2015
Also, expand trivial-validate to catch this case. Fixes #2220
|
Good catch, thanks! Fixed and test added in #2222. |
jcs
added a commit
to jcs/endless
that referenced
this issue
Jul 15, 2015
Will save us from errors like this upstream one: EFForg/https-everywhere#2220
jsha
added a commit
that referenced
this issue
Jul 15, 2015
Also, expand trivial-validate to catch this case. Fixes #2220
jsha
added a commit
that referenced
this issue
Jul 15, 2015
This will help mitigate future bugs like #2220, so an error processing a single ruleset doesn't break the whole extension.
jcs
added a commit
to jcs/endless
that referenced
this issue
Sep 12, 2015
Will save us from errors like this upstream one: EFForg/https-everywhere#2220
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
FYI, @jsha -- it looks like 08a1f4a broke the Chrome build because of the unterminated:
<securecookie host="^\.paste2\.org$" name="^(?:__cfduid|__qca$" />This throws:
Uncaught SyntaxError: Invalid regular expression: /^(?:__cfduid|__qca$/: Unterminated groupI'm guessing the version submitted to the Chrome store (and stuck) is broken (!)
The text was updated successfully, but these errors were encountered: