[Hotfix] Illusion Revert #1398
Merged
[Hotfix] Illusion Revert #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgtw
approved these changes
Jun 13, 2021
ghost
approved these changes
Jun 13, 2021
…endIllusionPacket which should alleviate some inconsistencies for new clients zoning in and seeing the entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a revert #1389
Tested this and this is working fine. The previous revert was hurting more than it was helping so it makes sense to keep what I had patched in from last October for now unless there is something that warrants taking a closer look
Time boxing investing time in this but for the most part we should be good and should get this merged back in to fix previous regressions on master
This also fixes an issue where Illusions were improperly setting size for a specific Illusion. The Illusion would update properly for one client but would not set the size properly. We're not calculating the proper size for the Race / Gender combination and size shows up correctly for new clients also entering the zone