Repair unwanted buff side effects from BuffFadeStruct. Repair buff formula 11. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2015 10:12
amount of reserach. Sending level has odd effects on the actual buffs themselves. Take lesser shielding. Cast it with a EE I item worn. When the server updates duration using this struct, the max HP goes out of whack. I tried various values for effect like effectdec num, played with it as an efefctive level, etc. None worked. Setting it to a large # seems to remove ill effects and has the update duration part still work. Secondly - buff duration formula 11 seemed to be wrong (not matching client).
|
And comments/concerns? |
|
Can't merge but would if I could. |
|
Can't meaning permissions or folks decided it wasn't appropriate? Im guessing the merge conflicts is just the changelog.txt. |
joligario
added a commit
that referenced
this pull request
Mar 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog pretty much says it all. I can see how these could both have large impacts if I am wrong about these. They've bene working fine for me for about a week, but I have a tiny player base.
+Buff Duration Formula 11. I noticed this was giving incorect results for
+a bunch of low level spells. 11 was setting the duration to max duration.
+This seemed to match Zam for a bunch of low level spells, but does not match
+what the client thinks. I asked in channels and demonstar indicated a formula
+of (level +3) * 30 was what the GUI has been using since 2003. I change\d the
+code to match this and all the low level spells I was seeing wrong were all
+fixed.
+
+Changed the code that updates buff duration once after a cast for focus effects
+to send an arbitrary latge value for the effect field. Previosuly level was
+sent and it caused very odd behaviour on some spells like lesser shielding
+where it would actually adjust max HP when the packet arrived at the GUI. I
+tried to figure out what the effect field should be by trying various values,
+diff levels to se if it was effective level, effect desc num to see if that
+was expected, etc. Found no meaningful value that didnt have side effects. By
+sending this large value all my side effects went away, but the diration updated
+correctly.