RRTMGP data transfer optimization #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the data directives in the RRTMGP-CAM interface, the variables on the GPUs were created and destroyed multiple times causing a performance penalty. In this commit, structured data regions were added above and below the increment, rte_sw, rte_lw calls. After adding data directives,the nsys profile indicates, only a single data transfer at the begining and the kernel executions. SW: 414.055ms → 77.66ms LW: 443.532ms → 200.637ms
gdicker1
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Looks good to me. Thanks for all the work on this @supreethms1809!
I also appreciate the timing info you shared here.
gdicker1
added a commit
that referenced
this pull request
Aug 1, 2024
This is a follow-up for PR #24. It reduces additional data movement in the rte_sw() and rte_lw() subroutines. It also eliminates data movement within the calls to gas_optics() by moving the data movement outside of the subroutine call tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the data directives in the RRTMGP-CAM interface, the variables on the GPUs were created and destroyed multiple times causing a performance penalty. In this commit, structured data regions were added above and below the increment, rte_sw, rte_lw calls. After adding data directives,the nsys profile indicates, only a single data transfer at the begining and the kernel executions.
SW: 414.055ms → 77.66ms
LW: 443.532ms → 200.637ms