Eliminated additional data movement in RRTMGP #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdicker1
reviewed
Aug 1, 2024
There was a problem hiding this comment.
Thanks @johnmauff this looks good.
Would you mind if I also add an update to the Externals_CAM.cfg to bring in the EWOrg/rte-rrtmgp #1 changes?
|
Dylan,
Yes, that would be a good idea. The changes to radiation_tend() depend
on the use of the rte-rrtmgp PR.
John
…On Thu, Aug 1, 2024 at 1:11 PM G. Dylan Dickerson ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks @johnmauff <https://github.com/johnmauff> this looks good.
Would you mind if I also add an update to the Externals_CAM.cfg to bring
in the EWOrg/rte-rrtmgp #1
<EarthWorksOrg/rte-rrtmgp#1> changes?
—
Reply to this email directly, view it on GitHub
<#25 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADH7NUTU73IT3DW67ZQCXGDZPKB7LAVCNFSM6AAAAABLZNTYG2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMJTGY4TGMBQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
These changes include removing a (now unneeded) temp variable and some unnecessary OpenACC copyout directives.
gdicker1
force-pushed
the
rrtmgp_data_opt_phase1b_ew
branch
from
5b267b8 to
044002f
Compare
gdicker1
changed the title
gdicker1
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for PR #24. It reduces additional data movement in the rte_sw() and rte_lw() subroutines. It also eliminates data movement within the calls to gas_optics() by moving the data movement outside of the subroutine call tree.