Elimination of conflicting external references #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
external references at the link step of compilation. They go hand in hand with branches of the same name in mpas-ocean and mpas-seaice. In brief, the modules that generate the duplicate external references have a unique dummy string, MPASAOS, in place of the mpas in the module names, and the module use statements. This modified source is place in new directories so that sed can be applied to all files in the new directory. Sed replaces the new dummy string with mpaso (ocean) or mpass (seaice) and renames the file so that dependency analysis continues to work.
dazlich
requested review from
sherimickelson,
supreethms1809,
gdicker1 and
areanddee
|
See also: EarthWorksOrg/mpas-seaice#9 and EarthWorksOrg/mpas-ocean#7 |
This was referenced Mar 29, 2024
gdicker1
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
I now think my issue with the term "external reference" in the commit message isn't worth these changes waiting any longer. Without further discussion or thoughts, I plan to merge these PRs and EWOrg/EW #39 later this afternoon.
|
Sounds good
On Apr 2, 2024, at 10:54 AM, G. Dylan Dickerson ***@***.***> wrote:
** Caution: EXTERNAL Sender **
@gdicker1 approved this pull request.
I now think my issue with the term "external reference" in the commit message isn't worth these changes waiting any longer. Without further discussion or thoughts, I plan to merge these PRs and EWOrg/EW #39<EarthWorksOrg/EarthWorks#39> later this afternoon.
—
Reply to this email directly, view it on GitHub<#7 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADS3XWGF7XYX7AETLCJM3G3Y3LPDZAVCNFSM6AAAAABENZ4I32VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZUGQYTAMRRGU>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modifications allow for the elimination of conflicting external references at the link step of compilation. They go hand in hand with branches of the same name in mpas-ocean and mpas-seaice. In brief, the modules that generate the duplicate external references have a unique dummy string, MPASAOS, in place of the mpas in the module names, and the module use statements. This modified source is place in new directories so that sed can be applied to all files in the new directory. Sed replaces the new dummy string with mpaso (ocean) or mpass (seaice) and renames the file so that dependency analysis continues to work.