Elimination of conflicting external references #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
external references at the link step of compilation. They go hand in hand with branches of the same name in mpas-framework and mpas-seaice. The buildlib now has some sed statements that replace a dummy string through the framework files and rename them in the bld/ocn/source directory. Module use statements in the ocean source are changed from 'use mpas_...' to 'use mpaso_...' to match processing of the framework.
This was referenced Mar 29, 2024
|
See also: EarthWorksOrg/mpas-seaice#9 and EarthWorksOrg/mpas-framework#7 |
|
I now think my issue with the term "external reference" in the commit message isn't worth these changes waiting any longer. Without further discussion or thoughts, I plan to merge these PRs and EWOrg/EW #39 later this afternoon. (NOTE: This counts as my "review" since I can't self-request) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modifications allow for the elimination of conflicting external references at the link step of compilation. They go hand in hand with branches of the same name in mpas-framework and mpas-seaice. The buildlib now has some sed statements that replace a dummy string through the framework files and rename them in the bld/ocn/source directory. Module use statements in the ocean source are changed from 'use mpas_...' to 'use mpaso_...' to match processing of the framework.