Merge MPAS-framework dev into main for EWv2.2 Release #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is reverted to its previous version to undo mistaken match to mpasa framework in last commit.
Removed to match the new v2.1 mpasa framework.
Removed to match the new v2.1 mpasa framework.
Removed to match the new v2.1 mpasa framework.
Modified to match the new v2.1 mpasa framework.
Modified to match the new v2.1 mpasa framework.
Modified to match the new v2.1 mpasa framework.
Modified to match the new v2.1 mpasa framework.
Modified to match the new v2.1 mpasa framework.
Modified to match the new v2.1 mpasa framework.
Modified to match the new v2.1 mpasa framework.
Modified to match the new v2.1 mpasa framework.
Modified to match the new v2.1 mpasa framework.
Modified to match the new v2.1 mpasa framework.
Modify mpas framework to match mpasa in EW v2.1
external references at the link step of compilation. They go hand in hand with branches of the same name in mpas-ocean and mpas-seaice. In brief, the modules that generate the duplicate external references have a unique dummy string, MPASAOS, in place of the mpas in the module names, and the module use statements. This modified source is place in new directories so that sed can be applied to all files in the new directory. Sed replaces the new dummy string with mpaso (ocean) or mpass (seaice) and renames the file so that dependency analysis continues to work.
Modify all module names in use statments in source files to begin with the token/string "MPASAOS_" which is replaced within the buildlib scripts of mpas-seaice and mpas-ocean using sed. This allows for OpenACC builds to succeed and not trigger the "Multiple definition" error. See EarthWorksOrg/EarthWorks Issue #36.
Compilation of model compsets that include mpas-ocean or -seaice components was failing at the link step. Commenting out a couple routines that are not called anywhere resolves this. This has been tested with gnu, intel, intel-oneapi, and nvhpc compilers.
Comment out routines to fix linking step issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.