Modify default files for all QU resolutions. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add free format options for ifx and nvhpc compilers.
|
I’ve got a one line fix to buildlib that takes care of the intel compilation issue with the one seaice file.
Can you replace line 114 (for compiler = intel) with:
fixedflags = '"-UCPRINTEL -free"'
Thanks
Don
On Sep 15, 2023, at 11:24 AM, gdicker1 ***@***.***> wrote:
** Caution: EXTERNAL Sender **
@gdicker1<https://github.com/gdicker1> requested your review on: #2<#2> Modify default files for all QU resolutions..
—
Reply to this email directly, view it on GitHub<#2 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADS3XWHQHJRGMOOGXUVQ6EDX2SFLTANCNFSM6AAAAAA42DSHEU>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
Just to elaborate, this is a hack that insures the -UCPRINTEL gets placed after the -DCPRINTEL for intel.
On Sep 16, 2023, at 9:24 AM, Don Dazlich ***@***.***> wrote:
I’ve got a one line fix to buildlib that takes care of the intel compilation issue with the one seaice file.
Can you replace line 114 (for compiler = intel) with:
fixedflags = '"-UCPRINTEL -free"'
Thanks
Don
On Sep 15, 2023, at 11:24 AM, gdicker1 ***@***.***> wrote:
** Caution: EXTERNAL Sender **
@gdicker1<https://github.com/gdicker1> requested your review on: #2<#2> Modify default files for all QU resolutions..
—
Reply to this email directly, view it on GitHub<#2 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADS3XWHQHJRGMOOGXUVQ6EDX2SFLTANCNFSM6AAAAAA42DSHEU>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
@dazlich, I'm testing that fix now. I think it would be fine to add to this PR, but I can't actually push to your branch. I get a "permission denied" error |
…ation.F The omp directives in mpas_seaice_velocity_solver_constitutive_relation.F are mishandled by the intel compiler so we disable them here.
|
I’ve got it committed now in my branch on GitHub. Is that sufficient for you to work with it?
On Sep 18, 2023, at 11:23 AM, gdicker1 ***@***.***> wrote:
** Caution: EXTERNAL Sender **
@dazlich<https://github.com/dazlich>, I'm testing that fix now. I think it would be fine to add to this PR, but I can't actually push to your branch. I get a "permission denied" error
—
Reply to this email directly, view it on GitHub<#2 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADS3XWA6QEK4L2HNK3W5SY3X3B7SDANCNFSM6AAAAAA42DSHEU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
gdicker1
added a commit
that referenced
this pull request
Oct 3, 2023
Updates default decomp files for oQU meshes and adds 'free' options to ifx and nvhpc compilers
|
Closed by merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the setup/build process of oQU{120,60,30,15,7.5,3.75} mesh compsets easier by selecting the correct decomp files by default.
Also adds free format options for ifx and nvhpc compilers.