Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update externals based on CESM tag 'cesm2_3_alpha16d' and add default files #17

Merged
merged 5 commits into from
Oct 3, 2023

Conversation

gdicker1
Copy link
Contributor

@gdicker1 gdicker1 commented Sep 7, 2023

Advance the tags used in Externals.cfg to match with the versions used in ESCOMP/CESM tag 'cesm2_3_alpha16d'.

EXCEPT: cam based on cam6_3_124 and not cam6_3_125

@gdicker1
Copy link
Contributor Author

gdicker1 commented Sep 7, 2023

Related Pull Requests in externals:

This updates the basis of the externals we share with CESM like so:

  • ccs_config_cesm0.0.71 -> ccs_config_cesm0.0.76
  • cam6_3_111 -> cam6_3_124
  • cesm_cice6_4_1_8 -> cesm_cice6_4_1_10
  • cmeps0.14.34 -> cmeps0.14.39
  • cdeps1.0.14 -> cdeps1.0.21
  • cpl77.0.5 -> cpl77.0.6
  • pio2_5_10 -> pio2_6_2
  • cime6.0.125 -> cime6.0.156
  • cismwrap_2_1_95 -> cismwrap_2_1_96
  • ctsm5.1.dev123 -> ctsm5.1.dev139

@gdicker1 gdicker1 marked this pull request as ready for review September 14, 2023 02:26
@gdicker1 gdicker1 requested a review from dazlich September 14, 2023 02:26
@gdicker1
Copy link
Contributor Author

Added default file changes for mpas-o and mpas-si to this PR:

@dazlich
Copy link
Contributor

dazlich commented Sep 15, 2023

Intel, gnu, and nvhpc compilers work for the fully coupled case at 120km if:

    • I modify the long hemco line;
    • I comment out the omp directives in seaice file src/shared/mpas_seaice_velocity_solver_constitutive_relation.F

I really want to get the second issue resolved for V2. It's not a problem with this PR - I've been commenting those lines out for a while.

I'm gonna run a couple tests at 15km, fully coupled. I expect them to run, and then I will approve this.

@dazlich
Copy link
Contributor

dazlich commented Sep 15, 2023

Oh, and as this has my mpaso/mpassi default file updates, approval for those is implicit in approval for this PR.

@gdicker1
Copy link
Contributor Author

Intel, gnu, and nvhpc compilers work for the fully coupled case at 120km if:

    • I modify the long hemco line;
    • I comment out the omp directives in seaice file src/shared/mpas_seaice_velocity_solver_constitutive_relation.F

I really want to get the second issue resolved for V2. It's not a problem with this PR - I've been commenting those lines out for a while.

I'm gonna run a couple tests at 15km, fully coupled. I expect them to run, and then I will approve this.

Understood and noted on the Intel OpenMP issue. I agree that we want few/none "User, before building, modify these files..." instructions for the V2 release.

I want to make sure I can setup a standard FullyCoupled run on Derecho and I'm good with it too.

@dazlich
Copy link
Contributor

dazlich commented Sep 15, 2023

You added defaults for fsurdat in clm, right? I'm having to specify it.

@dazlich
Copy link
Contributor

dazlich commented Sep 15, 2023

Looks like what I'm testing only has cam defaults for 120km. I guess there will be future PRs for cam and clm default files?

120km looking good across the board and I approve! Thanks

@gdicker1
Copy link
Contributor Author

You added defaults for fsurdat in clm, right? I'm having to specify it.

Looks like what I'm testing only has cam defaults for 120km. I guess there will be future PRs for cam and clm default files?

Apologies, I didn't get these added this afternoon. They should be good to go now.

Added PRs:

@dazlich
Copy link
Contributor

dazlich commented Sep 16, 2023 via email

@dazlich
Copy link
Contributor

dazlich commented Sep 16, 2023 via email

@dazlich
Copy link
Contributor

dazlich commented Sep 18, 2023

Is there ccs_config code involved in updating to alpha16d? If not we need to edit config_machines.xml to get pio2.6.2. It currently has 2.6.0 and cam history is going too slow at 30km.

@gdicker1
Copy link
Contributor Author

I see what you're talking about with modules. No ccs_config tag I've seen updates that module beyond 2.6.0. I know we're picking up pio/2.6.2 in our externals now, but I don't know how that is used in our builds.

@sherimickelson
Copy link

I noticed that on the NCAR machines, the esmf module also loads pio. You could double check the esmf version that cime is bringing in to see which version of pio is being used. I think there's also a script you can run in a cesm case directory to see which modules are being used.

@dazlich
Copy link
Contributor

dazlich commented Sep 18, 2023 via email

@gdicker1
Copy link
Contributor Author

Yeah I'm not sure either...

For now I think I can fix this by using ncarenv/23.09 and using parallelio/2.6.2. For consistency (and maybe to share with ESMCI/ccs_configs) I'll do this in another ccs_configs PR and include that here.

@gdicker1
Copy link
Contributor Author

@dazlich I think I got PIO addressed. It was a smaller change than I thought see:

@gdicker1
Copy link
Contributor Author

I made the decision to merge all the "update/cesm2_3_alpha16d/${EXT}" branches and some of the other updates. The currently open PRs affecting this are:

I'm trying to run some tests this afternoon to make sure parallelio/2.6.2 is being picked up correctly and that the 15km files are being seen/used. I think the mpas-o and mpas-si PRs can be merged as is?

@dazlich
Copy link
Contributor

dazlich commented Sep 19, 2023 via email

@gdicker1 gdicker1 changed the title Update externals based on CESM tag 'cesm2_3_alpha16d' Update externals based on CESM tag 'cesm2_3_alpha16d' and add default files Sep 21, 2023
@gdicker1 gdicker1 merged commit 374556a into develop Oct 3, 2023
@gdicker1 gdicker1 deleted the update/cesm2_3_alpha16d branch October 6, 2023 21:51
@gdicker1 gdicker1 added the external Has to do with externals label Aug 20, 2024
@gdicker1 gdicker1 added EW specific This has to do with EarthWorks only - files, goals, code that probably won't be wanted upstream upstream Related to the upstream repo (ESCOMP/CESM) labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EW specific This has to do with EarthWorks only - files, goals, code that probably won't be wanted upstream external Has to do with externals upstream Related to the upstream repo (ESCOMP/CESM)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants