-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prescribed seaice mode #8
Conversation
…s is intended as an EarthWorks-specific alternative to CICE%PRES in the F2000climo compset. The necessary code was imported from the E3SM version of prescribed mode and the necessary translations made to the cesm/nuopc environment. To specify this compset, in create_newcase: --compset 2000_CAM60_CLM50%SP_MPASSI%PRES_DOCN%DOM_MOSART_CISM2%NOEVOLVE_SWAV
Re: "Caveat: this compset will be susceptible to the same mpas framework issues just like the fully coupled model until they get resolved." In PR #8 can you add a more detailed description of the "mpas framework issues" or a pointer to one. |
More specifically, the mpas-framework issue refers to compilers objecting to namespace collisions - duplicate module names among the mpas components. This is being addressed. Example: The intel ifort compiler is not so rigid and accepts these multiple definitions for CPU compilation and execution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this Don!
I think this needs a few changes and then it will be ready to go. If you want, I could even make these changes to the branch.
@@ -3715,3 +3728,4 @@ Default: Defined in namelist_defaults.xml | |||
</entry> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this config_prescribed_ice_stream_fldfilename
entry being properly closed now? I think it should also have the Valid values:
and Default:
keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
I just got it to go. Your comments should all be implemented now.
On Mar 8, 2024, at 3:36 PM, G. Dylan Dickerson ***@***.***> wrote:
** Caution: EXTERNAL Sender **
@gdicker1 commented on this pull request.
________________________________
In src/Registry.xml<#8 (comment)>:
@@ -2515,7 +2523,7 @@
<var name="verticalSalinity" type="real" dimensions="nBioLayers nCategories nCells Time" name_in_code="verticalSalinity" packages="pkgTracerZSalinity"/>
</var_struct>
<var_struct name="tracers_aggregate" time_levs="1">
- <var name="iceAreaCell" type="real" dimensions="nCells Time" name_in_code="iceAreaCell"/>
+ <var name="iceAreaCell" type="real" dimensions="nCells Time" name_in_code="iceAreaCell"/>
Corrected. Set of diff lines now much smaller.
I do the git push --force ... but it tells me 'Everything up-to-date'
Hmmm that's odd. Could you point me to the directory?
—
Reply to this email directly, view it on GitHub<#8 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADS3XWEOAAMFTDCLXIKDENTYXI4QJAVCNFSM6AAAAABEMF7CKCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRVHE3DQMRTGA>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple other changes
…_stream_fldfilename.
eb5cf9f
to
299b84d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'll do the merge and tagging
Great! In time for the weekend. Enjoy yours
On Mar 8, 2024, at 4:03 PM, G. Dylan Dickerson ***@***.***> wrote:
** Caution: EXTERNAL Sender **
@gdicker1 approved this pull request.
Looks good! I'll do the merge and tagging
—
Reply to this email directly, view it on GitHub<#8 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADS3XWCJR5WEASH4WCUR3BDYXI7VJAVCNFSM6AAAAABEMF7CKCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRVHE4DQOBVGM>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
@dazlich, just a check on the tag I create. For
Is this accurate? Do you know what version of E3SM these changes came from? (This doesn't block anything, just trying to keep track of "Upstream status" in some repos.) |
yes, MPASSI came from E3SM v2.0 (not sure about the extra .0)
On Mar 8, 2024, at 4:18 PM, G. Dylan Dickerson ***@***.***> wrote:
** Caution: EXTERNAL Sender **
@dazlich<https://github.com/dazlich>, just a check on the tag I create. For mpassi-ew2.1.001 I was planning to use:
Add prescribed mode (PR #8<#8>)
Last changes from upstream 'E3SM-Project/E3SM' tag:'v2.0.0'
Is this accurate? Do you know what version of E3SM these changes came from? (This doesn't block anything, just trying to keep track of "Upstream status" in some repos.)
—
Reply to this email directly, view it on GitHub<#8 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADS3XWEJJM7GSW55GCFDGU3YXJBMPAVCNFSM6AAAAABEMF7CKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWGU2TIOBWGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This PR implements the prescribed seaice cover mode in mpas-seaice. This was already an option in E3SM. The hooks in the nuopc cap had to be uncommented, and routines brought over from the E3SM source and translated to their cesm and nuopc equivalents.
With the PR, users will able to specify MPASSI%PRES in the F2000climo compset in place of CICE. In create_newcase use:
--compset 2000_CAM60_CLM50%SP_MPASSI%PRES_DOCN%DOM_MOSART_CISM2%NOEVOLVE_SWAV
The seaice cover produced by MPASSI and CICE is near identical in test runs; it appears MPASSI introduces a perturbation that gets reset each timestep. The climates differ slightly, as to be expected with a different physics package.
This PR should permit us to bypass NVHPC issues with CICE.
Caveat: this compset will be susceptible to the same mpas framework issues just like the fully coupled model until they get resolved.
This PR replaces the previous one for branch seaice-prescribed-mode.