Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prescribed seaice mode #8

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Prescribed seaice mode #8

merged 2 commits into from
Mar 8, 2024

Conversation

dazlich
Copy link
Contributor

@dazlich dazlich commented Mar 8, 2024

This PR implements the prescribed seaice cover mode in mpas-seaice. This was already an option in E3SM. The hooks in the nuopc cap had to be uncommented, and routines brought over from the E3SM source and translated to their cesm and nuopc equivalents.

With the PR, users will able to specify MPASSI%PRES in the F2000climo compset in place of CICE. In create_newcase use:
--compset 2000_CAM60_CLM50%SP_MPASSI%PRES_DOCN%DOM_MOSART_CISM2%NOEVOLVE_SWAV

The seaice cover produced by MPASSI and CICE is near identical in test runs; it appears MPASSI introduces a perturbation that gets reset each timestep. The climates differ slightly, as to be expected with a different physics package.

This PR should permit us to bypass NVHPC issues with CICE.

Caveat: this compset will be susceptible to the same mpas framework issues just like the fully coupled model until they get resolved.

This PR replaces the previous one for branch seaice-prescribed-mode.

…s is intended as an EarthWorks-specific alternative to CICE%PRES in the F2000climo compset. The necessary code was imported from the E3SM version of prescribed mode and the necessary translations made to the cesm/nuopc environment.

    To specify this compset, in create_newcase:
            --compset 2000_CAM60_CLM50%SP_MPASSI%PRES_DOCN%DOM_MOSART_CISM2%NOEVOLVE_SWAV
@dazlich dazlich self-assigned this Mar 8, 2024
@areanddee
Copy link

Re: "Caveat: this compset will be susceptible to the same mpas framework issues just like the fully coupled model until they get resolved." In PR #8 can you add a more detailed description of the "mpas framework issues" or a pointer to one.

@dazlich
Copy link
Contributor Author

dazlich commented Mar 8, 2024

More specifically, the mpas-framework issue refers to compilers objecting to namespace collisions - duplicate module names among the mpas components. This is being addressed.

Example:
nvlink error : Multiple definition of 'mpas_dmpar_mpas_dmpar_exch_halo_3d_real_acc_8350_gpu' in '/glade/derecho/scratch/gdicker/2024Feb20_113609_EWMTesting_FullyCoupled.mpasa120.derecho.nvhpc/bld/lib/libocn.a:mpas_dmpar.o', first defined in '/glade/derecho/scratch/gdicker/2024Feb20_113609_EWMTesting_FullyCoupled.mpasa120.derecho.nvhpc/bld/lib/libice.a:mpas_dmpar.o'

The intel ifort compiler is not so rigid and accepts these multiple definitions for CPU compilation and execution.

Copy link
Contributor

@gdicker1 gdicker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this Don!

I think this needs a few changes and then it will be ready to go. If you want, I could even make these changes to the branch.

@@ -3715,3 +3728,4 @@ Default: Defined in namelist_defaults.xml
</entry>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this config_prescribed_ice_stream_fldfilename entry being properly closed now? I think it should also have the Valid values: and Default: keys.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@dazlich dazlich changed the base branch from ew-main to ew-develop March 8, 2024 22:00
@dazlich
Copy link
Contributor Author

dazlich commented Mar 8, 2024 via email

Copy link
Contributor

@gdicker1 gdicker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple other changes

@dazlich dazlich force-pushed the prescribed-seaice-mode branch from eb5cf9f to 299b84d Compare March 8, 2024 22:57
Copy link
Contributor

@gdicker1 gdicker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll do the merge and tagging

@dazlich
Copy link
Contributor Author

dazlich commented Mar 8, 2024 via email

@gdicker1
Copy link
Contributor

gdicker1 commented Mar 8, 2024

@dazlich, just a check on the tag I create. For mpassi-ew2.1.001 I was planning to use:

Add prescribed mode (PR #8)

Last changes from upstream 'E3SM-Project/E3SM' tag:'v2.0.0'

Is this accurate? Do you know what version of E3SM these changes came from? (This doesn't block anything, just trying to keep track of "Upstream status" in some repos.)

@dazlich
Copy link
Contributor Author

dazlich commented Mar 8, 2024 via email

@gdicker1 gdicker1 merged commit ea4028c into ew-develop Mar 8, 2024
@gdicker1 gdicker1 deleted the prescribed-seaice-mode branch April 23, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants