modernize tests #50
Merged
modernize tests #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get rid of unittest usage (which is inconsistent between py26 and py-not26 anyway) - get rid of "classes" that weren't actually classes - use conftest.py to configure api_key consistently and remove a bunch of duplicated code
…up window marginally better
…lient-User-Agent header
- fix indendation to look like Python instead of Ruby - clarify version support - linkify links - add release procedures
victoryftw
approved these changes
Mar 1, 2017
att14
approved these changes
Mar 1, 2017
dlc37
reviewed
Mar 1, 2017
| print e.message | ||
| if e.param != None: | ||
| print 'Specifically an invalid param: ' + e.param | ||
| print(e.message) |
There was a problem hiding this comment.
print(str(e)) works in python3
Roguelazer
added a commit
that referenced
this pull request
Mar 1, 2017
Merge remote-tracking branch 'origin/no_unittest' Closes #50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @att14