Dicts iterate differently on python 2 vs. 3. Let's sort. #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… very same regardless of version.
|
I actually manually added the I'm fine with this if tests pass, though. |
|
One of the tests failed; I've fixed the test. Not sure if Travis is rerunning the tests automagically... |
|
Tests pass. |
Roguelazer
suggested changes
Mar 2, 2017
tests/test_webhook.py
Outdated
| # Index webhooks | ||
| webhooks = easypost.Webhook.all(url=expected_url) | ||
| assert webhooks["webhooks"][len(webhooks["webhooks"]) - 1].id == webhook.id | ||
| for wh in webhooks["webhooks"]: |
There was a problem hiding this comment.
how about just
assert any(wh.id == webhook.id for wh in webhooks['webhooks'])
Roguelazer
approved these changes
Mar 3, 2017
…ost-python into dlc37_unite_python2_and_3
dlc37
commented
Mar 3, 2017
|
|
||
| assert report.object == "ShipmentReport" | ||
| assert report.status == "available" | ||
| assert report.status in ("available", "new") |
There was a problem hiding this comment.
Do you think this is sufficient, or will the retrieve() call fail for new reports? I can't reproduce new reports.
There was a problem hiding this comment.
I think it's sufficient. If not, we'll fix it next time it breaks.
|
🛳it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by python3 test failures before @Roguelazer modernized them. The order of 'all()' changes.