Fix broken native midiout playback after playing a song that alters pitch bend#3090
Merged
3 commits merged intoEasyRPG:masterfrom Sep 26, 2023
Merged
Fix broken native midiout playback after playing a song that alters pitch bend#30903 commits merged intoEasyRPG:masterfrom
3 commits merged intoEasyRPG:masterfrom
Conversation
This sometimes appears to break the volume of Midi on Windows as it is timing sensitive.
All sound off is never sent. After the GM reset harmony sends Pitch Bend Range 256 to all channels. Resetting the pitch bend fixes the corrupted audio after playing the tracks zerotwo and timetolearn in "Toilet in Wonderland". These songs indeed alter the pitch bend. Fix EasyRPG#2910
ghost
approved these changes
Sep 22, 2023
Merged
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pitch bend reset fixes the broken music after playing some Toilet in Wonderland tracks because these songs indeed alter the pitch bend.
There are some further inaccuracies: The timing when we send volume changes for fade (and pan is completely missing) but system command wise we should be doing exactly the same now.
Frida hook for reference:
@Mimigris please check if this fixes the tracks for you.