Fix broken native midiout playback after playing a song that alters pitch bend #3090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pitch bend reset fixes the broken music after playing some Toilet in Wonderland tracks because these songs indeed alter the pitch bend.
There are some further inaccuracies: The timing when we send volume changes for fade (and pan is completely missing) but system command wise we should be doing exactly the same now.
Frida hook for reference:
@Mimigris please check if this fixes the tracks for you.